From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E5B8E784AF for ; Mon, 2 Oct 2023 10:17:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8C9476B013D; Mon, 2 Oct 2023 06:17:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 851D96B015D; Mon, 2 Oct 2023 06:17:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6F30C6B015E; Mon, 2 Oct 2023 06:17:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 591C56B013D for ; Mon, 2 Oct 2023 06:17:00 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 0DABBC01E6 for ; Mon, 2 Oct 2023 10:17:00 +0000 (UTC) X-FDA: 81300118200.07.7F1657B Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf25.hostedemail.com (Postfix) with ESMTP id F3BE7A0002 for ; Mon, 2 Oct 2023 10:16:57 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf25.hostedemail.com: domain of cmarinas@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696241818; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gli/JT5QxIyyR/f1rdtAbW0iLqLfU5usMUc1tdgF/FA=; b=2ETLNlXgnNVH3B3RlaWh2tw478b1A57xK7dvhGE6vznjr4H4/CBhw16OjsAlVyUAd6rMyM LKqtynL9oVnYeDDIVCFeFCg/BD+l7rZ8Pg1AL/h5NaaIAAuHwtdSizgiVsBLWBPPzrV6hS SbCsLBsn1wHJVmNpXRTG0MASle54xeQ= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf25.hostedemail.com: domain of cmarinas@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696241818; a=rsa-sha256; cv=none; b=oua7KFfWucV0ELTJcAGWrxNV6b17VBjNUwtEAwrp04oaVubffdj5OHDORnMwi2vXDHL+W/ r75MpI8DkcbkVMiBSyJhHzYfhU38T5DExvL+tPy3y6o7fn0HqXQsTaIH9txWsf7roB+ibh dhzD2hrOqfvw6cfWU5PI7JXYqOkkv0E= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 6AA76CE0F28; Mon, 2 Oct 2023 10:16:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 90F01C433CA; Mon, 2 Oct 2023 10:16:50 +0000 (UTC) Date: Mon, 2 Oct 2023 11:16:48 +0100 From: Catalin Marinas To: Lorenzo Stoakes Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Will Deacon , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , Oleg Nesterov , Richard Cochran , Jason Gunthorpe , John Hubbard , Arnd Bergmann Subject: Re: [PATCH 4/4] mm/gup: adapt get_user_page_vma_remote() to never return NULL Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: F3BE7A0002 X-Stat-Signature: mkcq4ikfhodaxx55tsnzm81hp36bqowk X-HE-Tag: 1696241817-484299 X-HE-Meta: U2FsdGVkX18CjVYRHqu+xz7sfzJEYYrP/T7Prmgw/Q8AJkEuoI36ec2DhCV6l6HCJANWLJa2oUxFHyrRIGm92HGWemGaFvP8OZYT8oFb7c34sHgJRwdz2S6UT8pIIioDW+0P+FiESvPMIu/L+y7zSSL+X7Nn4U0IfgonBJpPq3A77AsmQg/DAb2j1bPJZJup0z7+uoH3DxxC6oP3+qhlNma6PUaz8eo+4fuOGDIz0UHkf6+csF4jpZjiIqOgYHWf1KKcl6qWZ3y8ddNhKIcDBH1K/UtcH2//3Dn+HamAzubBq6Yx/a8wfWKRTXZl4DI0YESnNnjwOFKLuwRKkmRLv9MvHxlETtecYnhXOJbqLAkDfc/WD+UBoTEENjGrbF18AKkUm8LgYWlEuO0Ws2PBf9yN3LRSwRQXDEoAfHiafgQFBWfvyLkHBOW5/euEf0GaCsMFV8rLF2znT1/e4LvgTGdUCwtrwHKvc4e6sWwT36EQV5pAJj77jpOFZbcFvAIhM0YdUS8DEiygDOhik7G1u1WFjR6/UdJDlNkwbVsJGlU54zwMYQ2MWsSVU7hksrzUUBbUbDLpfppQHsb+lj/v4x3lCnwvRW8iw3xrOMRLy048ja8J9HJMJhndtcpXg/S5WOnElWUVMp8wRoS4CqyKUvczWzP8eCZ8jq7OMRaHgrr92yYzqy2nDSyX0G72+TkFoTsDPbMau6gLgBip2XpOwrJFyqxEBsH1UMC7abxmdsdess6bn96mh7Y4gHdLcEKNsu/bagfWrUwKlEdlGVYsnW2DsnaHVtGxX3uQSU4ZvfOwpRyvMmhF0e/nWktEhbApDK0mAR9a3PmX7kO2hk3N2L4ND4fU8LD6Oit8g8i+IASrZ0o8KhALVXSAlOKVXdgtqjuzzUCIhnFmuM5qPhAbnsGL6qK/by/uZLmvhoUv2JZCI+vXYFzFH1W+piZfxx63zOmzapPfkg0BarvIZyu LmomiuN4 o7NTnMu/0fqNr3WX7G+79V80Q0FOWlk6AtuobXx46PqnfUo8DUu34UbESrotRtX/clsCpE1th4buglQAV0FRt2LYDh0XrV3N87dSxHpy7lOAozQAItcZUu7PFRmJjLjYAnWmhfR3uhxmaBDDXWq0ZaqnDqAmtdtXKXcdQQLychCPwwAPnaMfjVasI0SF9qXaBEMiNvpyLZP+RA+jHvag5I0ze+w9nyHntoA80JBKf4QLQmEuDi8ysipVzM0CofDXGQp5goNPdBwoNTCH0fR8zy36rlxTlbT2ovdT9NMMxtKLh/rNEXSYhE1BO6zLaCFiEJFH5hMw1m2fz4aHf5pRhJeKspCoYg5t9yl0raNl1Zy7/hKf9q37hud+CSFf80//wysZifaJFI3y4FIfhbDUWWh/2yEQY3UIAx1MIY58Cb43QRyvlxKLdSznHUChz2XBJDxV9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Oct 01, 2023 at 05:00:05PM +0100, Lorenzo Stoakes wrote: > get_user_pages_remote() will never return 0 except in the case of > FOLL_NOWAIT being specified, which we explicitly disallow. > > This simplifies error handling for the caller and avoids the awkwardness of > dealing with both errors and failing to pin. Failing to pin here is an > error. > > Suggested-by: Arnd Bergmann > Signed-off-by: Lorenzo Stoakes > --- > arch/arm64/kernel/mte.c | 4 ++-- For arm64: Acked-by: Catalin Marinas