From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A257E784A4 for ; Mon, 2 Oct 2023 06:26:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 339916B014F; Mon, 2 Oct 2023 02:26:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2E94F6B0179; Mon, 2 Oct 2023 02:26:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1B1476B0197; Mon, 2 Oct 2023 02:26:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0B0386B014F for ; Mon, 2 Oct 2023 02:26:24 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C6152C012C for ; Mon, 2 Oct 2023 06:26:23 +0000 (UTC) X-FDA: 81299537046.12.E3776F6 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf27.hostedemail.com (Postfix) with ESMTP id 004314000E for ; Mon, 2 Oct 2023 06:26:21 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=QZLNWR45; dmarc=none; spf=none (imf27.hostedemail.com: domain of BATV+bce677bc24b4e8506042+7344+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+bce677bc24b4e8506042+7344+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696227982; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=g+PPt0PZHmo02mh9GogQC8Pu3uCPDQcILPNZPjjYZfY=; b=KKguoIJ2nXr0GmCXlNXh+1ZPiObBplYhgnj14GihlNawaLTzcxpsu4SzfvPOaaghvFGmID Ys89RvfXYG0mYhaEnQDsQ2XsZKfUBfKX1TlLyBJBOH3QGirMyt64nIy7lQ5X5VSrv4bPx2 ipMcYlnAo4psgqlw0od/WnJGJ7ypXtM= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=QZLNWR45; dmarc=none; spf=none (imf27.hostedemail.com: domain of BATV+bce677bc24b4e8506042+7344+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+bce677bc24b4e8506042+7344+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696227982; a=rsa-sha256; cv=none; b=rCNGrBc78SXXKAhKP9lbzzGLxqJToHDwFD+h7ULzZ/LWfVaH1SeScS5OgAdjIbOehv0bTV 7M/6EhsRShZKF04YhuQN7X/LYNuo0dN1cwkqYMNOJbzWUIxXAU2yQpP6Oigqd62VXT0YWn vYtNbFGqxo5n9BlsYxeQJkNfSuzha6g= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=g+PPt0PZHmo02mh9GogQC8Pu3uCPDQcILPNZPjjYZfY=; b=QZLNWR45DDwYvykpS/pQrIHlYn mj7UEVifF3CRoZh+GTU2halUtIsz0RFEYT8v08k3nXOiAEWb6eosJrR1EIt5esZpyfH03W+aD7sHu WeS0dyqm4vNW9nsi2spY+r5jRN5dQHM5iuiR2vEBTmJMFJYaFeMvoNQmL4kLh/YNkdPuGlWi3S0EB DTN+eYNP47lN9MhrB4yfAdYk1lU5gCLLQCmsg4BywY4x7HTAAl4R39FTy26gEJEAABVl/iRaSVRKC OeK1gV7NWkwfAA9bwLzfuGLQLAAbvuoOaQHOVIVukzvG/PGFcAi39Szi8XC+ZyFz/dyraN94lxKqU 9NTJEROw==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qnCNm-00C1a2-3B; Mon, 02 Oct 2023 06:26:18 +0000 Date: Sun, 1 Oct 2023 23:26:18 -0700 From: Christoph Hellwig To: Lorenzo Stoakes Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Matthew Wilcox , Jan Kara Subject: Re: [PATCH] mm/filemap: clarify filemap_fault() comments for not uptodate case Message-ID: References: <20230930231029.88196-1-lstoakes@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230930231029.88196-1-lstoakes@gmail.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Stat-Signature: q3em1xjq4xejg9bouqt79bnbqys1xhha X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 004314000E X-HE-Tag: 1696227981-324738 X-HE-Meta: U2FsdGVkX1+3lIeesz540qNUp2ajh9j6DCB+JC9k1yIcRIZnrG3neJJzylrAAiyZGXcXb7kRpKtu+qT0Z1squ873EtNA1HJmlAe4PDbrePwWkaDCYxow+UQYaVXovE1Gyu3CYxwpVvQwghPwiVCm/bONbGG7orwvJrSIOVSQ/6hWE1qKuPSHj0YmPVupnmqnzxf9J9YhwDF9/IDG2b0a+KFF3RjZctuxP2Uaq8hAklUJXYcHxBsGPEr3ZC3xU0cC3kzYe0fvUPuXxgA+3nWWLyKGRJ1t11gyWQz7haiPJkpQ0RsLWY7gdkI7+CuRlQAQ/viRuClzzOahtsdOrFhSOY9R6pxIt1QDKHDJoPVmxOukvlXZ3rpjcv2L4/3hpFELIPzuG/gmteUnMqpq60/BAUSpH63K8ySG+FB24JltsoFVX7MV5x8VdybEXCGh39SkVQXpdHT0XjJOcCrgr6xV04GwINyqg882n3Swq2IY7i6EZEi4WZWEcG+OkJ0pyL0uboWZiCjerG74RqleNsiathkWXmPpGUdUcFNJERDFDkOcolW021omzQJ9e1xkq50Nwry5mrGg9zFlPqL6FD8a6U+IRD4C0OQLnZaH2d/HiQI7u+Tb82ZhiPgSbEfmDgF+QVKRtijVaMVHsDb/hIDasQiM2vRiDLyK+YRHrt0x6rGN0XWgIQuKth5/hR2K2kkuonXbWq3td1E8K7HWpGHccIY+4GYOG5uzM6ttzFH7Zzyu0EfJMsrpax5rdGBrT5eZApJ6Yju1So/cCkEf+pC4lvt4xjm+GqYp/WDb8GsqpmO0okZNxSr27AAUAwzkP7J8MJEWvn8H0ANGXiDC+URxJ7gRe3ZV81x6wjFWHhrUSt56PMV7NVoM9OzIMiLWqfVIE5KxyA67S4Wgn/UHOZTzzk9CEPqtzw0t6fFTbiuxFrsI9Y4IBMh6n1FXm1WqO5MZsmo4fmfAF009PgunAIt CT16/Ef1 YF870ZcvhaTEiqAZ28gfCP5/ofWORdwMxiehdXcFlBVDniYB9IArEhbGv/MejiQDhEjEZDCFsm+BCRyyUTLWnwWg51REd6AE68ElWKMNrF9MN/05P8wKwP4xrL+ofpCfCylNksCovkCv/kIoYM83SKNlOsu2R0aJ3YYRPokBFWb/rT0nKlMr9EDnQJv0223bwHWd/CoRVE+TRiHyP4Wd2hXg59l3MXgRnjz82o5L/MmcbSP/4bOvNVYfcXvAa+dFaunA9IH3WRJaCh6Z5Ozvdc4NNBVB3yVlZyTAZ/kxPx8LFYzskh1GCp38i/hQ8j1G62i4JBkjp2Kc9PX6cGjMaRSvDhimYJT8I6T6WQn0HgpxCN0Rs1tgKHcH893S4Ln5qWfWprA3KYwBacIzyI7GsX5sA3u+tyrcnuqGnNyMSwKZvY24NULc5v8TZ2Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > + * If the invalidate lock is not held, the folio was in cache and > + * uptodate and now it is not. Strange but possible since we Please don't spill block comments ôver the 80 charater limit, that makes them impossible to read nicely.