From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DE26E743F1 for ; Fri, 29 Sep 2023 07:51:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8FB508D00B9; Fri, 29 Sep 2023 03:51:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8AB218D008D; Fri, 29 Sep 2023 03:51:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 799FE8D00B9; Fri, 29 Sep 2023 03:51:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 6AB878D008D for ; Fri, 29 Sep 2023 03:51:01 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 1E9A7A11ED for ; Fri, 29 Sep 2023 07:51:01 +0000 (UTC) X-FDA: 81288863922.26.5F5F4CC Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf04.hostedemail.com (Postfix) with ESMTP id 0F5F84001F for ; Fri, 29 Sep 2023 07:50:58 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=DAesCVn5; spf=pass (imf04.hostedemail.com: domain of broonie@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695973859; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GGbpHYnnHtkusyGSK6jQIjPmfyLPGabIgOAYFgPfq1A=; b=3gAe4665d8SwJsfql6u4OlTUYUIJrt9Xzr6Tr/aNuR/NASQHt95aSvf/c77Qgn1n2jZGDf /Y24118FAxT177t/Vc5ZSgGV3stB8fQNHb3uC5TfSrZtEd/v++zrghjI4sOXXvrTT5svbh qziRAV4+Fm8nMV+zid+g5SeM7yRXKHk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695973859; a=rsa-sha256; cv=none; b=fIE17hmqrXJrgD3utyLZoRJqkXTtTrTPZDRTtzsEQbsdQYCgGMSH1Gym1rc+UrZCCm76M4 gbanHScsMGuGpvjprMjCO3Wltc2kT9niF1svG4sb7/V/CdCWhJ6oG+ltsRHNsUmnkE6maW v6vBdWv6C0u7srG1LXS6sL427jDbFeE= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=DAesCVn5; spf=pass (imf04.hostedemail.com: domain of broonie@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 84B3FCE223F; Fri, 29 Sep 2023 07:50:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 391AAC433C8; Fri, 29 Sep 2023 07:50:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695973854; bh=GGbpHYnnHtkusyGSK6jQIjPmfyLPGabIgOAYFgPfq1A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DAesCVn5p/1cB0JR2N4tEHjJbvZVaCWqQiGgTvbTgJzI5lrdY+DS6OkYDWAQIvvzF C2L8vLOYIxuRxVRhjHoBQRLRU1KYQYlPjevbu8OkDaIFIgdtQAhQd4fJBp8YslIF/o jdv59SXlX+HXbyo/iFPv3R+fEQZ74YsMCgqj+FSnndZETMTuwC1R37zapsituVSo/X Gp8G3pvE+B/R76+2tRThEvQL9PMGnXI0phbx2wcPd3Hm+pFAeTB05K8kg9vwXcaDhz 8wObjn3LfRGwTtzFwUQGRh5tIvQDk+5n8Q63ZWNs6TzfjcNEPkw1+d7JZBA0r+KHtn mUuaxqOrQ3dlw== Date: Fri, 29 Sep 2023 09:50:53 +0200 From: Mark Brown To: Kees Cook Cc: Shuah Khan , Eric Biederman , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/2] kselftest: Add a ksft_perror() helper Message-ID: References: <20230928-ktap-exec-v1-0-1013a2db0426@kernel.org> <20230928-ktap-exec-v1-1-1013a2db0426@kernel.org> <202309281747.594B3352@keescook> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="x9263VfYFBG144cp" Content-Disposition: inline In-Reply-To: <202309281747.594B3352@keescook> X-Cookie: Save energy: Drive a smaller shell. X-Stat-Signature: 56ztnq33gsgcw1apzqkn6o3e4nowz9ec X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 0F5F84001F X-Rspam-User: X-HE-Tag: 1695973858-134873 X-HE-Meta: U2FsdGVkX19+YU8RUEe9ZXp5uAkSXPmyjZfZlyAW/uEfYAZ7Oh2KswOPoTcIO6I1YlG5QfQmXenQdxg7mSmXYrKUAHt21VKhbJid38/ElwGwWkOtDuRH4HGyYuLqdJCA3TiXdBJkRYGSIPzxjty4C8zJp1cHVf36VkIAs0IEv0mKj2SgsT9vi4l+UnaxUyrZ8Ohz1gJinWo8Qls4+wJLNqz7oDA9dyvU3rpt5qwc5ZcAtZcaoSSZ3td8EtgVIoYg1UCl2Z3mGGe+y6X+dO4m8hbKdeqEtggF3q+llHyPe1jc9EN+SSFKP0VMEbz5c9PsNrhSCPA3i+YBDnyRPogarmWQt6ttcr37X33bIaB7pub7sRmklXoshT/5f0aonMdhvZ33+2bDi3FOeKdYbjdCi0YyCZvaoYhgs1AdG9zOrdPUE61Ssc+hskoMGiIgU95q1Wz+bz3Panxze6hb7JiqwQnvzoxyDvMkRsa7vBGEv6mYawL6kJw+aR3uZ8CfY+yrhuK68Kp7Od8FwqEXLNB8rnkrNzqyfbH5mdb07t++ilpGswSjeG44x3CxEw1UcKO4cBerwKCWpsSvUGWF4AEE+pMcCJQEQVhRuC85A614ONQx8OYlEY/DksZ3IZgMlJqRpYoiDocDa7Ek1Z65RV2UQDct8hT8wPMRouOVhF+GAXNsi4gCxHWG4Qp4xPDSe885Y+3bKynR22JK3Oe+RppgW//E3Wy+bsYjfqucxunM+muh/X88UM1Fz7xY5bxE8eKQZhhdKzouHYBJx9zFvcaKgGz+IEZu7G5xe9IY/vA8RcuvHC3LzmEAb4F5xhkN7yiMxbhtzPqORImJPv3pB6oacAnVh3MHdEp4DzJ17oM5dEaTphx+xyCMaL5KT2Hgx9Rg4XYh1ptQ0OnVQaDTwUswXww+JWsGMM//z43+jcpc44ZWQO7bxb5gZ4zbbQtNVdSpNLj1BwQ9JAqpdGVqd8v MVJISR3U QNtHWPDtIPbcBEwlA4OJWJl5nMsh3PLx9ncLC3dQ05wtwbOlJcUYe0b1a21viLcPBrSZ+W4aL0r9CLSNugsWTu8/Ok6IedmkiT4rhJhMYAYmdvY5f93DGAXdOvkMCzewW4BzNqibh+ri/og3XiZjyFsGf/N+DohP4/OH3R6DML4jiDNVAh9Q6I0S3lcdde9x5p+KsDDUaOPvKrDgreWuK5Cdpa9jjGH6jTr1vxZYkAEfAddSwN2OMq6Dn8QQML+q/L4kxsMBr42oySM9cebLMultgqew2tjACtZYZdLNipRWTCJ8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --x9263VfYFBG144cp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Sep 28, 2023 at 05:48:22PM -0700, Kees Cook wrote: > > nolibc doesn't have a strerror() and adding the table of strings required > > doesn't seem like a good fit for what it's trying to do so when we're using > > that only print the errno. > Oh, interesting... what environment ends up without strerror()? Like I say it's for nolibc - it's just some header files (all in the kernel source), while it generally aims to be libc compatible it's intentionally very small. --x9263VfYFBG144cp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmUWgdoACgkQJNaLcl1U h9DSKQf+Nwu+SS/OWR23p6efn+V6eqT6BHD6pcarmjnNkHqSzy9l3Ygy4S6Fbny+ eE8I8uhXrP345bqn0SdeNI05MiO/qH2F5qDM7nnt2h6Lnm9JnyIEybeu8tXMKxGA q9EfIdKsJoY3EjJPVLU6xTj9z/9c1v+3JeDKFYiM+548twGcVuWvQ0I2rpoE60kY c8OiWo6fa9klyrhKUazGjL0HdWGel7j9JNppMnY5946rxkaR5Mfjc0kiYtlGlYdy A1Q8DNgk/z9N5bdbBHtYK9TNeGlJ1wZAfIYOwNlWFgKO+iUl+anJNedA5C0ldYnZ DJtFu//F0HRs9f6y671Y9mzI2jxrjg== =bjp7 -----END PGP SIGNATURE----- --x9263VfYFBG144cp--