From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F09C1E82CCD for ; Wed, 27 Sep 2023 20:06:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 635FE8D008F; Wed, 27 Sep 2023 16:06:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5DB088D001C; Wed, 27 Sep 2023 16:06:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4A1D98D0072; Wed, 27 Sep 2023 16:06:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 375778D001C for ; Wed, 27 Sep 2023 16:06:39 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 1374B1A0133 for ; Wed, 27 Sep 2023 20:06:39 +0000 (UTC) X-FDA: 81283460118.07.005F611 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf05.hostedemail.com (Postfix) with ESMTP id 065D1100013 for ; Wed, 27 Sep 2023 20:06:36 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="XaLZv/B8"; dmarc=none; spf=none (imf05.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695845197; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5CIG4IN+NULdj6GDXp85UVQu/M7lEt+lk7D7J1xFff4=; b=JsntuHmby5Rbjw/Tziresf38KOT04KOLhv9X4v1vmnE7RThOI0Z+cW0WwNIxZmgJ4BFMe8 0gmJnPMHvy3pDTzsaTHAGTYwcbKWbvv4wAoVFa+f4c91SynhWIXmBoExG+Oog4G2zh3mfu Y+slaAXinNtGUFpA+EQWOQKQbI+Gt8M= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="XaLZv/B8"; dmarc=none; spf=none (imf05.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695845197; a=rsa-sha256; cv=none; b=6VIIpMVG8AuorBVmIGNPgEclkBBXxzadTRCecr7HAp5MGqUmJLQbZp+eOqrp4R1Q2Wc31K k6vrZnZytztRDu0+bvWlBqNtQ1/4/HijD7aMCnhNkK60v5LDrSQwK8zq517WuOEg674baV F5mKMV8C9tgZIWLIS7kNsBRrC7HhRYM= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=5CIG4IN+NULdj6GDXp85UVQu/M7lEt+lk7D7J1xFff4=; b=XaLZv/B8s0zD31RKwX7U3qW6VG oPGodBmh1pBJJkZTC/2i1KbCUy6vQCsLB0t7I4bMeJdms5EFe/GltInDYHWXOU/bzjLVKBc+olvuv 7I7By2Uqq49Mi+lsIyXmK7jIU+C9S00LOK0BLgL4raNGWaTMoElaQNBh0sU5G6xMwBuNqsG3VHpdp f7S8rjtHGp92uNjrdFUtI7LQIOITCTjzVZtWN3n7CpKReC2vEco3ZYJnVSbT2364P1TLeoQ+7ptGY vf+zn3B1Q2sc51++AFk+ASRSV9eehPszFOHr7m4uNpfhi++XKXeLAlANvz3+B/FXHvdMBvS18ZZqJ WQiyvykA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qlank-00FpkC-EK; Wed, 27 Sep 2023 20:06:28 +0000 Date: Wed, 27 Sep 2023 21:06:28 +0100 From: Matthew Wilcox To: "Liam R. Howlett" Cc: Andrew Morton , maple-tree@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Jann Horn , Lorenzo Stoakes , Vlastimil Babka , Suren Baghdasaryan , stable@vger.kernel.org Subject: Re: [PATCH 1/3] mmap: Fix vma_iterator in error path of vma_merge() Message-ID: References: <20230927160746.1928098-1-Liam.Howlett@oracle.com> <20230927160746.1928098-2-Liam.Howlett@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230927160746.1928098-2-Liam.Howlett@oracle.com> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 065D1100013 X-Stat-Signature: f43itet4auhyq7indrjh4wkidds1hkjc X-HE-Tag: 1695845196-964772 X-HE-Meta: U2FsdGVkX1+aXQuURLAtpoqc7Gcjz24qiSk9a8qIHfbUe68aSLUWQiuRweJJrYeE71nkxU5f67nqd00CQ6tC8APwyBD0Aepte0TWZi0+fl4AYZispbXfZAOltoyemF5n68CYsj/2lZ0/5EgkNLycsBS5VtWfs7lzbn0W3rD+lwkv6ThUuA7E9inKjTfLibdy8yXv3r1x1gw3cCFY4xcl3vbxuHRvrJkpUHERXixEp+xMB4IhWtbuqwbGvH5/wbWWbsa0CSPs2MngudOKi1rrN+O1NfvdF97Q/S1JcJI4DjpF/BW448QuQVX1u5RY9OA9T7HTYhNxDOAckv3ncW4Hj1q1/X1bKxQcU7KCI7FDQYX4ngHybWlkxdka7WYdmb++s+LT+R3gc3aRcypuV7VvYxRenanON/M+uZgp2xuV2WbPhXNytW80kQS7uGT9wDYavYcg13zy4YSlEu6cwRy5C5AvPbvQMZZ4tVP2TFO54SaRHMax5F1W524hm3Upk6+PWedzbjHMEiLXAtYX+ImXYVU5ukm4bc9cN3/PURNfHaCkWjoBwDspeSJ2WKVRETiBu/HDv239S2d/vz2CSG1Iwhev/xQnZ58/hjKlH5IvA6OiRRuQEMAYza3vkmo2N6NvFLShMv34bLg8asDyrRgpfyfZ3T+IzxO08KsNIS9WTFIwUFS2CzTD0UrMt70XeB1cPY/QykKXfMp5sWVP/Yeebd1Vyn5jKByNCUn7q0X/8NJAvZueDSj2sLlBF0Qi4S2PE2ZBnlhhqxqYdcxsjSu5F2fQbjlMsD2C42khxzRWliZPJDBTxnlFfw5J+7QFVqPOSdDaFMhVlkvYofaQgYFAplFAe5zuwh+KXyN1ffEcjudwxR0mEY5a/i2iMPGmv4EHChXR7W2xep1dK/VMc48FDHSGlRc67ba8Dtm77lm31jH87vTd4+9tomv0SyGfG5G+uZLucgrLLdb2KsyhOiY HsrYxMmg H3/aQJwbSfuniRzyaCGHFx58LVfVw3RJr/9hLejZ3caC+yqR3Pkc+2UXcN2rKXC/kI0NH8V8CcDu2+fws0LEhveNbFqw8T9Khtrd0pyAFqpzHkhQnTZAHbQpdYsf6vKVGs+p4WyOU/8yqIgtNUi3UBi4WeAHFeooU6hKVvdWatgOWB6exG60N72FNKOl+WGMW0ZNXdyVvTgVsmAkzoA5HE3mchA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 27, 2023 at 12:07:44PM -0400, Liam R. Howlett wrote: > +++ b/mm/mmap.c > @@ -968,14 +968,14 @@ struct vm_area_struct *vma_merge(struct vma_iterator *vmi, struct mm_struct *mm, > vma_pgoff = curr->vm_pgoff; > vma_start_write(curr); > remove = curr; > - err = dup_anon_vma(next, curr); > + err = dup_anon_vma(next, curr, &anon_dup); This isn't bisectable. dup_anon_vma() doesn't gain a third argument until patch 2.