From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1F3FE7D242 for ; Tue, 26 Sep 2023 07:30:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 660EB6B017B; Tue, 26 Sep 2023 03:30:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6108E6B017C; Tue, 26 Sep 2023 03:30:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4FF8F6B017D; Tue, 26 Sep 2023 03:30:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 39B9A6B017B for ; Tue, 26 Sep 2023 03:30:16 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id E50801410E9 for ; Tue, 26 Sep 2023 07:30:15 +0000 (UTC) X-FDA: 81277925190.21.148420B Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf12.hostedemail.com (Postfix) with ESMTP id 223D440003 for ; Tue, 26 Sep 2023 07:30:13 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=ETp0Judb; dmarc=none; spf=none (imf12.hostedemail.com: domain of BATV+2a2c9b7848046cbd39dd+7338+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+2a2c9b7848046cbd39dd+7338+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695713414; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VB02rfAqrCwJrrIDo94dHomdWocZV8cYbgBNccAUQMk=; b=4/TXdbkSvHdI9fjiXN5fSSWWUf74jfrFNKUmPDOu8vv7gKcu62fSHkbNLVOoG7GcjQlssV mdN0VS2ArApsk1KLS8u6xcwYf2xFV2xNgOMkAIm0nUNtxye5xRRORgAVtIcN3S9TtlwEO5 7GWGczQbIj9xMnq3OPAoNIe/Uwla80g= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=ETp0Judb; dmarc=none; spf=none (imf12.hostedemail.com: domain of BATV+2a2c9b7848046cbd39dd+7338+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+2a2c9b7848046cbd39dd+7338+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695713414; a=rsa-sha256; cv=none; b=txDz07AGTkymGozfwYk2CZFCnj+vVMID/k9BDBWgJRjcu63MOLwD1hbvuFiMYIErsOiyv8 JSnjnWkuDaZr/mEvWzIz5LTuZH/Gb46gJvJXqyx8TDN2lGbeskOKC8ffuIcUgh382MexMx a6JRbek98PbzZDRUfKizS+nVewRQi0w= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=VB02rfAqrCwJrrIDo94dHomdWocZV8cYbgBNccAUQMk=; b=ETp0JudbYO6jWOHR8dt1yjNuuo ANXen3hdy7Mz22SUO98P7L9/e4iniE1lGCr1mPQXHUkSKDEIyC8GY8Su3mmKooq6UR8d6xFR85zcx //zTrG/P1LfB768hKeFtlJYLjY1/58D/ZAf3KCd5yCxzkYcLzfmAHHJvTw7e2NyONn1XN2fQJr2uK 1uTsOWjHzM8iM2ZucnmHgkM4qVJOq36oRA7/r5QB4Nrisp3bzJzsRfSdJd/TJhlS3ToCjWIUHuDxb tl+k39Lts3qdYVgNiAWcnvm4qw3dYglXtHRpPYpchgRBAglGDQn3Nc9zQA5wO31Lc1qe7EsvI8gd/ d3wjnD1g==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1ql2W5-00FnWf-1E; Tue, 26 Sep 2023 07:29:57 +0000 Date: Tue, 26 Sep 2023 00:29:57 -0700 From: Christoph Hellwig To: Liu Shixin Cc: Yosry Ahmed , Tejun Heo , Zefan Li , Johannes Weiner , Jonathan Corbet , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Kefeng Wang , Andrew Morton , cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mm, memcg: expose swapcache stat for memcg v1 Message-ID: References: <20230902100728.3850149-1-liushixin2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230902100728.3850149-1-liushixin2@huawei.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: 223D440003 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: pzgj1nsudah7g6zmsd9ykyaouh7wu4zg X-HE-Tag: 1695713413-175165 X-HE-Meta: U2FsdGVkX1+w/8oXtwwG/O1k3uDL4bfj1g5I6SYs8SDUlxuAtGqvXFZY5nWx3GIPNZYfwq0Am3vGnibFmQlxrOaN5jh2va2xhK7vnI+u4bcAGM/0nzHO3fWUkO3AoIHNRg2U2dmCM9HtINQx2kVumsZHWFdWcfL4aou72VH0u7OW4likmGWnvehNzoSP+k8hF4DeehxkQnkHOzZf8A+LWHo6ah32NB8j/ijjunyMwpd1qzFKrkr5rtTwlEmbnmFtJ2ugGNkMDqjRQMP//euoLgjMKuUEv1T7uBLNRwP4EBDdRGn7v9/Yr1RsYszRWr5QmdfW75I1jpvhWbTbcqSp3CjkJiJ2TZAH+eqIp0xm0hw/k19fhYuJ49btaP2e05rDXV17B5R8Vl6s6gdBOSzEbFBzKSDNxGfnuFwzSJgj9T+riAO/E03CBe5zh29XcxK2mm9fcKVU9gGIB/qzKxLNevDaVOue/65Lrs8HptP9By3b7EsT57W7xX22jeZjKsYyjnMx9e3LE1avL+pIZTk9RYMvm+X90QM/kMyYG/E/8XGY0jgMbodMBesm/VZ8nsYvirKTr/k2FeDbOZsPu1yODxU2E2Zy1IF4p0urM6gs/7zV2vm4Bg3Zo1VIzvU71tYN/R6eNfdtyBmNAF9G9VPj4nhd3nLxoEVWQx37Xtx2f7NxvhGQtLXaCt/OJT9qB2JnvzXuE1SdN9HsNJMJFgsb82PEgUMWmhyBRhMe3cWlEPISDHislpuyoGhaHwqhi+MvmtJXLlb7lhWp/IQ/SYU3LX4TyUiskgSK7MOE9qJs+rvfffekpfoUrEDBFp2OlvqozvP3sGjq+1PKMLf4ycRe6bDf6CGiXiO6qRkkRqUQxRGP63KZYKjvDYwppDjtZqpRwUDTg7PZ1kEWK4E1kbf6rEiSL8VWM8Y/AoNU0t7jU/ACmtmfFl0lnmbEdU3M4vWQwNHTyMzRrDf9O2YEKsy uKmmfdSp 8glEZnwvpOLdQQULH/+w11OrxmJnoCtrPHejxbbtiGAiM4jYWPuq+19X5tVZ8OMHzB39jbt6JEjgmYwc9pXEu3PKONZGl6O6F/DIoKnR60O+G87qTqLoJWWQ6CVhk9Akg9PSdztawr6EJVseKcWmTXdJsKMvPrbypAp0n7NtO+kZo7L+uexs82aImkLvCqhO7zD44/PpdE0amfzWEJHpe13+F+YoCqn3cINt2BBXMsG2utJeeIr6HmN9tZI6NCP0nWftjTFLqvkI7NtnaSxBRgHFM4yI9mg3nxLWzeT4vRGcej1aAiviEuUVwI1jiN6FBQa/z7+2wymBgPjL13wCs2nHyPpw8G8nk/eLUQoHmiv4kqTbryGuWt9YnOVlzP0RDrt2JP+h+4PDbH5s= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Sep 02, 2023 at 06:07:28PM +0800, Liu Shixin wrote: > Since commit b6038942480e ("mm: memcg: add swapcache stat for memcg v2") > adds swapcache stat for the cgroup v2, it seems there is no reason to > hide it in memcg v1. Conversely, with swapcached it is more accurate to > evaluate the available memory for memcg. Why are we adding new features to the long deprecated cgroup v1?