From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6336FCE7A89 for ; Mon, 25 Sep 2023 22:58:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C056B6B0144; Mon, 25 Sep 2023 18:58:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B8E616B0145; Mon, 25 Sep 2023 18:58:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A2EC06B0146; Mon, 25 Sep 2023 18:58:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 8D8D86B0144 for ; Mon, 25 Sep 2023 18:58:41 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 6461A1402DC for ; Mon, 25 Sep 2023 22:58:41 +0000 (UTC) X-FDA: 81276636042.09.D780879 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf30.hostedemail.com (Postfix) with ESMTP id CDA0980003 for ; Mon, 25 Sep 2023 22:58:39 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=K0VyEqlp; dmarc=none; spf=none (imf30.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695682719; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XwCjcncnJ5ZxZIUi6jjYCedQryoBULwBfDgkVT6PDZ8=; b=SrO+XpgzK9dwC68mYLPqkqBZne3H15dRrX89LNifASmGQXRDuOfgt4wJLubpPGk9F1+9Wk YSu8ssxeLgzEU9nyEK6RC1z7qefvJreXJii/e3RBNGYA1qj+Apji0JOZLEcZzL0OwuWhP4 RzccB6YMr9Dyber2Z18/KvzLwfanuls= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=K0VyEqlp; dmarc=none; spf=none (imf30.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695682719; a=rsa-sha256; cv=none; b=QodLpTaX2rmY7TVC9kVvV7H4nRPD6kF9rCJpuBz2gTz0Y3RJzza1KRArpGf57Upal17Cyv jVbFDgGgJJrhRBW766UjWjxp2l82wyd7G3HI23OhXBv+wzHgB5d+DT2iK2RbonHJRxFe2S pSN8LRfVOviwmleiLfbbbClMGQBib1o= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=XwCjcncnJ5ZxZIUi6jjYCedQryoBULwBfDgkVT6PDZ8=; b=K0VyEqlpKIUcb2s2ECR+gWwU3f K0R/AOu77KZXhWs1Pe0jCYCUqt1Pj42flLAciC+v+CLJt34xmR0PG884riCWfyqVhjCZFONwni9Ls kZs7kCMxQ3m/EutNC1eVjka01AruF7G7/8yrOrnipePwRYFwkWkLumMF4RrAYdxn4WzQGD7UaG25x iC+AR/0lbjoaYISMaIX1aRcCHWkdCmIS4wU+cf/hSKqmZE1tO6TN8Yizg59suEIKO3vwDg6DmOxSt rAl6GW/wol4im9XzL1kJ1Fd3gKp4ayblZAIavwv+xCgTjCRqPNGzx+pCj4TF1PMOrxZyQr44ZUO7L wOkrmtlQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qkuWz-0048m2-On; Mon, 25 Sep 2023 22:58:21 +0000 Date: Mon, 25 Sep 2023 23:58:21 +0100 From: Matthew Wilcox To: Hugh Dickins Cc: Andrew Morton , Andi Kleen , Christoph Lameter , Mike Kravetz , David Hildenbrand , Suren Baghdasaryan , Yang Shi , Sidhartha Kumar , Vishal Moola , Kefeng Wang , Greg Kroah-Hartman , Tejun Heo , Mel Gorman , Michal Hocko , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 09/12] mm: add page_rmappable_folio() wrapper Message-ID: References: <2d872cef-7787-a7ca-10e-9d45a64c80b4@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: CDA0980003 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 1ateu7a4atxkuizs98zmkx15puja8ah1 X-HE-Tag: 1695682719-402398 X-HE-Meta: U2FsdGVkX1889Gzea67e2mIrm7YqFRoQXb7LkKYv3tlRYpHEoPDgvs4DY2whAbeuWjxR15RCDqQygBbS85j/DSSeJoD+UNBwukDwfPXY6GzgEJ02nV8HXVEsy9pBRAxmXzq1y4insICZ75obFZl07pPEyQK2TM1fJVJd0Vl6F43T4MenYiLafQo2hiGcNHZXTf4K6zIyVz5ZS8DPQ4IdQRalZnEDQuGweTts2aDphFUsrLlTnJXbgkFYDqQ5VAN/jrIFJjpaTEosHpDMIkqaHrKBy27MmD1WrmXZA/n3RqyJWExFTj2KBo3oajdRmZ1EvVynbXppmqwo1rYylvnRd/WB5x+RnFUiPGc8XjKwZIKLOunhqFN5ybUuxtRKXLYxU7eVAxxMwY5O16est1tljCd4V6HyG4kIbsgrokXbBeRLynZnUu9d1dCCjABLNsni1SQtDPdGAMKj3vOzhDsy8L5Q32iZbM52H2ZrTmp4nS+qpT+0JrGokGulM1NRp33pIDoL18fsEXLaDprxCeSjWJg2fFfDfUFvpA2DrDxB8mRSYHDtwM58mfWuPZ21GqmvHB3EaYYjC4+0+WdR+NTIyVxzHE6FuOpUkj6zmQi1lZtI4IAH6DZ+17C5jP1pOCDXDIyPH8A+HIcxhXpbEQqMuRqgapTiNv3041AgYMCtIRObXP9q0yvDqTJyk2ulzdFj2+cBmQOab0YgbahdIAIo5bgRDJEn+EOzu/mhQrlcgMZBaM41pQNE+Z0m/SaW4R1QRT/dsFEfesUalhSrwxBTQLThTG6aLzwhydfSEp7lTk64pc7VrcpUwbmgHvdv11enDdFKYoMGajzBok6zRBvBGUmA2cnVEvmOdi4yl4xXYTvZ+j//gnC9uP8tvzkuC6IUG3PRhMHozyH+en6Zf+sCJNwKsIbJQoinJBxq8qdENHxgHtYuFaAOgL9rpwvXYW1Otv01OocUSU82YhX9sn7 HBjXOGNG A1o9jTJzNLNB0BE8J9m+ZW3zAofIHdxDiZMqmHQncJhMS7o1T/r/HF5wqim2tscaxjfSVQZjQ9/LdrvsvYVrPvzcPn2AtJVQnha8hvDLiGbo+1nbH8XxcS56ZgbqQO6c4P6O5f5l3PR/UT/HKobOTN6MKLKTTY4lwi+Xr960AfepsP3X/veAtfQnNlinmT/60MkumDSMzPIE9/ygLnM32kUNIwZ1V5AEYkl7KP85VYitFX0UzSzCV68Mw3hfTXBqaZ/IL X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Sep 25, 2023 at 01:32:02AM -0700, Hugh Dickins wrote: > { > struct page *page = __alloc_pages(gfp | __GFP_COMP, order, > - preferred_nid, nodemask); > + preferred_nid, nodemask); I really prefer not to do this "align arguments with opening bracket" style. As long as they're indented enough to make them visually distinct from indentation-for-if-blocks, I find it annoying when functions get renamed to something with a different length and somebody then wastes time reindenting all the arguments to match. > + return page_rmappable_folio(page); I don't particularly object to the main thrust of this patch. I'm not sure I like it in huge_mm.h though. Maybe in mm/internal.h? I wouldn't want anyone outside mm/ calling it.