From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D37BCE79A4 for ; Mon, 25 Sep 2023 22:29:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 052838D004C; Mon, 25 Sep 2023 18:29:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0026E8D000A; Mon, 25 Sep 2023 18:29:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E0C6F8D004C; Mon, 25 Sep 2023 18:29:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D1D758D000A for ; Mon, 25 Sep 2023 18:29:11 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A9D99A0714 for ; Mon, 25 Sep 2023 22:29:11 +0000 (UTC) X-FDA: 81276561702.01.4836928 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf17.hostedemail.com (Postfix) with ESMTP id 1E20C40005 for ; Mon, 25 Sep 2023 22:29:09 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Yxyn0YvH; dmarc=none; spf=none (imf17.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695680950; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vThqe82wFHQYIn4iDqh4uJHLDDFlNPpTiNpJ978Vj4w=; b=i2xH4QjdoieiPIpq35r0YgjmI78NfkTVF7K1F6ZhkzobCRPsA8LGaysblVODq45z6d6fHj AyeJdzCoKPwsk2JeGLbi+Vfy2sLzXSJ9MIEt4xhezszY6Cagrb6MtjrsXoaVKMsFL1E9XY 9H4VyTssfUKFCYS1nXHwItXDbcaHC8Q= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Yxyn0YvH; dmarc=none; spf=none (imf17.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695680950; a=rsa-sha256; cv=none; b=4oLrD114XgrItaAj+gZHG6s8TpZsMVbcOKsOKKQJQ6EzM3TSN2LFAPhycT7MsSzQpoo3Xf eCeJmHTSJZ5YsncO3JZwVgLwgFAEKIqxwdtxQK27tz5qi0RPSKimZO8IVZVvI2U3RFQB2Q UMo6etfawK5dRwVz8l10cguVVp5JRbQ= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=vThqe82wFHQYIn4iDqh4uJHLDDFlNPpTiNpJ978Vj4w=; b=Yxyn0YvHU4ijOJFKxi40NVpG6M 10klXG5q6CbXoKlZpEsiC4AWoeYkjSu132p0eMfW+ZAxsOmDmeYwKI6dNPA3d2tfgkNfSDAKnB2wR DjQesKO6BHO4cB0jcWm+aeDhgN67vj8/Rp03RudAOWasWtUB/QGq1Oq1j1mUUkzrMLXS6/HO/ZddY +bCIB7v1bXRyyI4Kdpt1rgIGsItdmHsTLkW697DshfEMLKUzq4BbXOZ/yUxTipdnAz7cVv0EIkmm2 b/gO6ecZMT0m3fmjJUWoS5Yk++88IhoKeBLFGo1JEaO2OjpFFOZi/XG/PXaMjR9tWmiSCjx6HCbKK BNMPCCqA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qku4G-0040tr-Jy; Mon, 25 Sep 2023 22:28:40 +0000 Date: Mon, 25 Sep 2023 23:28:40 +0100 From: Matthew Wilcox To: Hugh Dickins Cc: Andrew Morton , Andi Kleen , Christoph Lameter , Mike Kravetz , David Hildenbrand , Suren Baghdasaryan , Yang Shi , Sidhartha Kumar , Vishal Moola , Kefeng Wang , Greg Kroah-Hartman , Tejun Heo , Mel Gorman , Michal Hocko , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 05/12] mempolicy trivia: slightly more consistent naming Message-ID: References: <2d872cef-7787-a7ca-10e-9d45a64c80b4@google.com> <1a75d3dd-7fa-7a41-c76b-1232198a9a4a@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1a75d3dd-7fa-7a41-c76b-1232198a9a4a@google.com> X-Rspamd-Queue-Id: 1E20C40005 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 34p9ehdxzi8sys3s1ew6eaia85axodzf X-HE-Tag: 1695680949-408934 X-HE-Meta: U2FsdGVkX1/+rr/TjrEjq+KYKY2JMdppnYHDXbdfiyUtjityjuxz93HX2D2ofaj0wrZtsEj8UnMfntedyphvwYyuAgaBHN6a4OQ6SEbgsA5vsN6juCRGT5xU7KQeZZYDQ7BjeVGTNeU1XyK7H3e1Ujnot0YRQASqDZWnNc6PnfxLwS1lfKPB0n3mJzNo5e8myc2ZvansJj+v8BkdJtHc3bwy4J6ATzJYqb4EQfErS4VexuTpCmM53NLr632fe2AaxCPjerQicwcNXVe47VM4yWwTJaIdyIijDhR12cN0bRVWw9k5HfWbF5aBRQc6zoV5xUM/EMC2/ac4QAY0fMdJt4WQ07qZhSH0KkE2CDnmSFV1AKUVB/3hiUBzMuWzYoijpRicMhxa55NmzL7tOImsbIDJBM7HGvS5w6HAyr+o67BjNXHSV5ei42G8tN+RHhaL7i1NMLIszsODTGYg1lmpC51l9zZo7fx+0b7XHvBjSsrZwRra6td7hWbI08WpQDTYBy3sS2iwUnztRhHC1d/BNQbIypMMBKcJKC6GCycYoImmOlcsZgH4uhdIo2ZqpqF4mtfVfoMZJieuTnWT28rakcCTFV1lhDUgvP3nXL2frDsBJmWaswLvaWjwLaULcbIdVBPRyQvWpt0NYy9QA3DY9ORTS8QxAog2s4qLnTq8JYzq/CMH9oXsM8jbbl3Ecc1vzQjEhYI4OTxwfCN9JyjYa+vFYI/qUG7EUjJA3Rz7voPUDg+4PjqYERtjMYiUceoTbUywWTYxbwTDi+WcOJFj3YkX7xTG3kGM45QKOMuMvi1H2WCyC0DsIYZPSjlTn6igT8fDBaLaA1I1groTmCJl5eVKof5qAdewe2Fyh5AJMdo/4D91w1ftjNceMTQ4MeqAbEWs3+vQFxyfhqhNEutyHVVVbhVBU6M2rxnbuf8iNjERyCNAUeta1Z3wos4IC/n57kF1ceJZq8jIRq8I/gc bILTrA/k bnOJUSox0eKz4E908X7C39Cqgl2owZ96V82oI2OOlVYbU4LHKGYE5A5CztWA/aUqLMaAEIBCVlZ7se6zMcI9qgbrd+E38bqtu6dVqkxyh/GPNoZUDSB6nK9Av7CcE1ORl6yxcUZBJVRQJ343q9dOJ2PRegsUCLEmPROanPpJ7XTHrmTN0nMr+HPOuiVDuncX+cCJnlbLNxSiQQRQCcm8XQDNooqnfPyiEv6sohogFywkbJCBMMlgl6bmVz1RgJiPEjOKByHmtwWcHyy8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Sep 25, 2023 at 01:26:55AM -0700, Hugh Dickins wrote: > Before getting down to work, do a little cleanup, mainly of inconsistent > variable naming. I gave up trying to rationalize mpol versus pol versus > policy, and node versus nid, but let's avoid p and nd. Remove a few > superfluous blank lines, but add one; and here prefer vma->vm_policy to > vma_policy(vma) - the latter being appropriate in other sources, which > have to allow for !CONFIG_NUMA. That intriguing line about KERNEL_DS? > should have gone in v2.6.15, when numa_policy_init() stopped using > set_mempolicy(2)'s system call handler. Reviewed-by: Matthew Wilcox (Oracle)