From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F7A9CE7A95 for ; Mon, 25 Sep 2023 13:50:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9E5728D002B; Mon, 25 Sep 2023 09:50:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 995EF8D0001; Mon, 25 Sep 2023 09:50:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 85CB08D002B; Mon, 25 Sep 2023 09:50:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 70D048D0001 for ; Mon, 25 Sep 2023 09:50:33 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 41C6BA076A for ; Mon, 25 Sep 2023 13:50:33 +0000 (UTC) X-FDA: 81275254746.22.A2B838F Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf28.hostedemail.com (Postfix) with ESMTP id 4A450C000A for ; Mon, 25 Sep 2023 13:50:31 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=Y+Ze5tZa; spf=pass (imf28.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695649831; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jcHoHaiIokbvVhLAntZeHFBs/mSZ9sLRljn4JH46n+8=; b=a7YXGEKoKR5n5DDWMjMoZlFJIGarbpUgn0xb38vTp9aGX0ZVv2Lg0eahHr9MIFH4aeSIaJ GkzQrWuubMBl80YaFr/SmhcmqQPPbQD13in1ter2cGcntacONYSbfNKBJlyuetLI/8q6ma HPKx/sgVI3l/ED+TAWSptuzn2669XHQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695649831; a=rsa-sha256; cv=none; b=Q7UXe3ksUQswWWa9cEN1ZCUtH3liyYfwvWB7P80JuRiW+vq8NJa0txAE6vLcgGHscTHfdy QvZbttHKgXJEUy0WwOismHqeUvkMZgH4fTQShqvQFoti1CliR9P/r4rv4OMUfqLUAcJ9pW BB0rJQ2y7xtffdD6OacosdEh2rym6cU= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=Y+Ze5tZa; spf=pass (imf28.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 2880021857; Mon, 25 Sep 2023 13:50:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1695649829; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jcHoHaiIokbvVhLAntZeHFBs/mSZ9sLRljn4JH46n+8=; b=Y+Ze5tZaa/vhJYJpUpwQ0pZmKaOFR5s0ikzu9g5De+vsjp3KrPoNIbfEpJEqnpebKz7H2H cXibuPUBw6pEV4FasYGv0okod+puihW3ODDK0rw/6LlqrOe6N0+uNiT2vmYKLuq3S8sK/b e+u3WHYLF6e4U7Ku6SU3U1Iwmz9SDMY= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0246A1358F; Mon, 25 Sep 2023 13:50:28 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id F8kFOSSQEWXiHQAAMHmgww (envelope-from ); Mon, 25 Sep 2023 13:50:28 +0000 Date: Mon, 25 Sep 2023 15:50:26 +0200 From: Michal Hocko To: Yosry Ahmed Cc: Andrew Morton , Shakeel Butt , Johannes Weiner , Roman Gushchin , Muchun Song , Michal =?iso-8859-1?Q?Koutn=FD?= , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/2] mm: memcg: fix tracking of pending stats updates values Message-ID: References: <20230922175741.635002-1-yosryahmed@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230922175741.635002-1-yosryahmed@google.com> X-Rspamd-Queue-Id: 4A450C000A X-Rspam-User: X-Stat-Signature: o5xxtej6ania88cnpbczu1e43n8urc84 X-Rspamd-Server: rspam03 X-HE-Tag: 1695649831-778909 X-HE-Meta: U2FsdGVkX18PABVkikDIO7WZy7KsceY+qTzOw3QaEGuVNAZfMDsK0lmCvYn1y2tY0cNlnifjUQl9pPenN5uw8XGPUY8Cud63WrkatZqpja+e8mjreY0C00AiLXX10EXyuJRiavezmmxVFEjS4hevgxdAkN0qofqh3OV3aEPoTV/U7vljl23fRcFTsV6Xy9AYU6bFBVIawnzQhp9Y1LwNsTdbGIlRoOLDECNtb/zOJ2nD6RgI3MzgXlc0Y/iLP5HJrhBEByfrrCMGlXbZ6wyrjNHqMCMUJbKuUd4DGKfMGFjButv3p4CZzsFSpERZKyYXyNN3AtV/lSxR2lkMAVo0k+8DrY46CupAU7UT+n7D6eiNiG+0TYkpheS5n+Xszpr3vto9BdsFZNsbtj+cvR12jU0yoMl+wt8QzoeT8Y9vkbQWjOJYz0bnd6jzgo7YX/TJzEie/eQ5vhBZL0T9T1E5ih1CFvGG9/4QlKAChLlSVLf2KaP+PVkEMgSI804ehPtg0cb4rR18dGBZ8be+TtdH9mQYqCZ3t0o9MjE/DCFOzsegEdJmgeapnpHpALufkdDHgPGy8/aeHtV+lcqGn3QOliVzGqQtxmDrfkWPbUGhE2nrH3+e/avvSWfFddR6Xkt2ppcS5JOzE88LYT3CpnZ3PPIF67Tr1BWBVj3Rn3vk/gqOwg4xBXiWHK9XR+JW6lKu9xtu02VPfcdojMY8Z+aCbBfGMY0ZrpB4mgyouP/rhYlUrLaVb9BpULjL9ibFdMhc5Tso6K1whMJ7MRqsgf4yOzBdMjMTa81JwMGNRwBvnmu3RPUw84k3fl26NNvCDzhRvL/0p8sdLKWOZJrkoDfMpGQHA6kq/f0aK4FLLaerz0zJrl0djVASdZhf79L9tmLToc3E6o2SuhjMJjm1mWwpZUjKvaOzF6hr0vg9X7NFacgbyo6U0XzLrWeyNJ+yxn4FTtV850c5gaQUo1lj0wE EnVzdJj3 Mu3ot9uBVWnxSetLRUhMRWsN9lvt/F0KFS2jc1NtLghmlxaKPBRE+nz3o0u+f/Q9ZPHg9ycXCIeUe4XzMk0cf6J2zbE9L+lYuJSvm51QwK5gcbsOlBJVBR0DYSig8U2aTK7ZMUnKh0OFYYrcICy0UPkvOTFbcJ9ulRKh29+0TrZMLNbPLEle+uPoaQHZJ9fRJuadzOvwpwMkbw8sGzEM9po9358Uc8eRfVY25VMQ+ccOIr72brqgSJuPaDmuTa8fn7jtPCYoMpOZ+Cyza2RMJH93HGh5TUh0A1ykISUr+vECFsbw9ssbS1wcO+S5OmX4dMSL9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri 22-09-23 17:57:38, Yosry Ahmed wrote: > While working on adjacent code [1], I realized that the values passed > into memcg_rstat_updated() to keep track of the magnitude of pending > updates is consistent. It is mostly in pages, but sometimes it can be in > bytes or KBs. Fix that. What kind of practical difference does this change make? Is it worth additional code? > Patch 1 reworks memcg_page_state_unit() so that we can reuse it in patch > 2 to check and normalize the units of state updates. > > [1]https://lore.kernel.org/lkml/20230921081057.3440885-1-yosryahmed@google.com/ > > v1 -> v2: > - Rebased on top of mm-unstable. > > Yosry Ahmed (2): > mm: memcg: refactor page state unit helpers > mm: memcg: normalize the value passed into memcg_rstat_updated() > > mm/memcontrol.c | 64 +++++++++++++++++++++++++++++++++++++++---------- > 1 file changed, 51 insertions(+), 13 deletions(-) > > -- > 2.42.0.515.g380fc7ccd1-goog -- Michal Hocko SUSE Labs