From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D622EE9370C for ; Thu, 5 Oct 2023 12:20:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 26C6D6B02B2; Thu, 5 Oct 2023 08:20:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 21C326B02B3; Thu, 5 Oct 2023 08:20:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 10C136B02B4; Thu, 5 Oct 2023 08:20:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 02E996B02B2 for ; Thu, 5 Oct 2023 08:20:08 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C421480178 for ; Thu, 5 Oct 2023 12:20:07 +0000 (UTC) X-FDA: 81311314854.23.3E380A1 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf28.hostedemail.com (Postfix) with ESMTP id 1A06EC002A for ; Thu, 5 Oct 2023 12:20:04 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ob2iAc3p; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696508405; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UsVE557PzrNyYPiLJjrpDiv6e1odj4+yvG6YntgxdCg=; b=n5eY2dCBd5ePtISCzlsUwbv9+ecQPM4p+g+VrPO/MqHgqHOCidTZWwmLYvNZaADE1/BFBA 7mqmt2bMuUWdr+mbthAvg9hDtC/YfSiMXYQ8oaSlvvXcvgOBtX+pkfdyRDGboS++ywUy71 jq6Mq/iFDfH8IQjSOYuu5RVl/z6iplg= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ob2iAc3p; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696508405; a=rsa-sha256; cv=none; b=mlshhHP8Pt4xW4fcWdi6+W63YtgIYUBwNpY9kHI/KFQH8RQ4BDtCFlPXaUnBC9AYpRCKdn qdeoo2jkCaSyi+7LDb3K90YiLaDS4C9bfH99DZT8cDCRKjOC3OKJqzsJ8Yq9gtgEbk4CXb 6AgkyEVnR0V0Lvd4MExt6d4Rz9nHuSk= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=UsVE557PzrNyYPiLJjrpDiv6e1odj4+yvG6YntgxdCg=; b=ob2iAc3pk+z+RLvlwJM5ZEIvGo 1xjlUmYsHVt79MNTw4fGTMR0RYJ9EwHjkC8TchD6JndeNF9j7AL1U3YCLbp1cCTTPnSxL+D9XEjOz T2sXoNyUQjP4sXh2lkD/iqCFjHrfBqeIGpf9fdLQhjmwQX1ZzGnhB+C1SlebzOsIODjoZBD5Y0Cah oi6qGj3u6Dkn9AZ9iOkLgfcFEtKORAT1NAnzJlwUfCVQQZyqSAUE8tQTBRAJqj9Ts0hBfCxNPz35E FGLRIWC3XppZ0LoiouEOuc4j5NIaBhHZzY7aFkvgE/YWal0MMIJfbB3fG4pIIBrDnIuE6RkpeSBy0 4gZf7Lfg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qoNKS-009IID-A4; Thu, 05 Oct 2023 12:19:44 +0000 Date: Thu, 5 Oct 2023 13:19:44 +0100 From: Matthew Wilcox To: Oleksandr Natalenko Cc: Thomas Zimmermann , Linux Regressions , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Christian =?iso-8859-1?Q?K=F6nig?= , linaro-mm-sig@lists.linaro.org, linux-mm@kvack.org, Maxime Ripard , Bagas Sanjaya , Andrew Morton , Sumit Semwal , linux-media@vger.kernel.org Subject: Re: [REGRESSION] BUG: KFENCE: memory corruption in drm_gem_put_pages+0x186/0x250 Message-ID: References: <13360591.uLZWGnKmhe@natalenko.name> <2160215.irdbgypaU6@natalenko.name> <3254850.aeNJFYEL58@natalenko.name> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3254850.aeNJFYEL58@natalenko.name> X-Rspamd-Queue-Id: 1A06EC002A X-Rspam-User: X-Stat-Signature: m4iw65ccw3goecumb1by1oz3t8e5fc58 X-Rspamd-Server: rspam01 X-HE-Tag: 1696508404-505605 X-HE-Meta: U2FsdGVkX1+ca1jHdbHufiNt+T6zgpEgt82ykI7ZSBIWvpDpmOZsRndRJBb0HllP+sITz8abSJL4s13F49CsR8ZMN/7eIZgfutDhRoKlCCVc6IlsM7hNlmcYrEGb6ZZtlVzpoIe/q4y5KiUfrrHj+HwMXlnSY2CkepjfyHCfXSEDn65YBrKJQYNNAPocrLR/4Ai/gbY/mFxmbP6iYtX6OMKGYa33f1txFOCN4oDUiYmJwqvgaUHVeqq5kgHv+QmHQzhVC0QtKd3onQtLXLzguLt8pXFvQY5qPPQ2fW4tjaQiOOG2RRvSwkgEatkxmFLwSR6kk+MwLGP/aPWn1IPSZ+GvOxfretBl044Nv8VAyr82LOo/zGIM+lkQLCGJbq6Oep2zGqNlnkjFr07b8RGWJZ1ZKQfCQcfUhQmDqIhdcvtOC5bt63hwvlcWzWBZ35yYEkERrf8+HOuapPNtznCLVZTPfJa4CwZBq0ckQK4wRjRUc7crLzutI09uxlRzQysE/eiwx7YwvcBgTpU2hbPA5da54Kq4GDkuVpRDA1RPLx39uKZ59LON0DC9haYaO8Eb3BIGJ4kRSz/KgnUzDB1b4GseovPsZLky96avoy5DuRUdSrDfVai9hIq7pdljlgrK8D/M/quMYatwb4kFoewcNLtgxWYv7uloZWrjoKbyQXeneqkVZBSpEex2VBRea+w9Gpm2saIeylmfCz5s7qHBH/6Qumfq3ZhhEjUJEqExzdbmcWN6E40VdKVXrtHyG2xmXcL6AEf4JVxtKxr7caxihiU4VSj4kUxDMv8aAFYJd4e8jUA3YxfRpjPulT7faO2p2OT/ZSO+3GawMZ7Sjzb4kkbBEIdx6ScTrohcpAbaD0930Gt19zYxk+3a4UL7hF+9pZD28Tf4gh3vw7O0e4JVcrelgTfdNNz/7zDEzCVs42bEtwEnH9ENI6L/yOFJXW/uR0wDGT0DTba42Mn1zyv TYGHsLPs 9gCs/Oc5akaekivn0ssM6Na3+RH+m+r8Abg97pch5Kofp2fo/TAfK76iohiSg9QWa1UyHIETPz67g1oibpBsaGHbP8gBzWSsdCBcQYgHg6ummBeKqeFJomlA7fo/YG7nvOJLPQIi3mbnw0AqpPOQzjAB5f3W4++FCjjoWSlcOpZMaE633CqtiliwElg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 05, 2023 at 09:56:03AM +0200, Oleksandr Natalenko wrote: > Hello. > > On čtvrtek 5. října 2023 9:44:42 CEST Thomas Zimmermann wrote: > > Hi > > > > Am 02.10.23 um 17:38 schrieb Oleksandr Natalenko: > > > On pondělí 2. října 2023 16:32:45 CEST Matthew Wilcox wrote: > > >> On Mon, Oct 02, 2023 at 01:02:52PM +0200, Oleksandr Natalenko wrote: > > >>>>>>> BUG: KFENCE: memory corruption in drm_gem_put_pages+0x186/0x250 > > >>>>>>> > > >>>>>>> Corrupted memory at 0x00000000e173a294 [ ! ! ! ! ! ! ! ! ! ! ! ! ! ! ! ! ] (in kfence-#108): > > >>>>>>> drm_gem_put_pages+0x186/0x250 > > >>>>>>> drm_gem_shmem_put_pages_locked+0x43/0xc0 > > >>>>>>> drm_gem_shmem_object_vunmap+0x83/0xe0 > > >>>>>>> drm_gem_vunmap_unlocked+0x46/0xb0 > > >>>>>>> drm_fbdev_generic_helper_fb_dirty+0x1dc/0x310 > > >>>>>>> drm_fb_helper_damage_work+0x96/0x170 > > >>> > > >>> Matthew, before I start dancing around, do you think ^^ could have the same cause as 0b62af28f249b9c4036a05acfb053058dc02e2e2 which got fixed by 863a8eb3f27098b42772f668e3977ff4cae10b04? > > >> > > >> Yes, entirely plausible. I think you have two useful points to look at > > >> before delving into a full bisect -- 863a8e and the parent of 0b62af. > > >> If either of them work, I think you have no more work to do. > > > > > > OK, I've did this against v6.5.5: > > > > > > ``` > > > git log --oneline HEAD~3.. > > > 7c1e7695ca9b8 (HEAD -> test) Revert "mm: remove struct pagevec" > > > 8f2ad53b6eac6 Revert "mm: remove check_move_unevictable_pages()" > > > fa1e3c0b5453c Revert "drm: convert drm_gem_put_pages() to use a folio_batch" > > > ``` > > > > > > then rebooted the host multiple times, and the issue is not seen any more. > > > > > > So I guess 3291e09a463870610b8227f32b16b19a587edf33 is the culprit. > > > > Ignore my other email. It's apparently been fixed already. Thanks! > > Has it? I think I was able to identify offending commit, but I'm not aware of any fix to that. I don't understand; you said reverting those DRM commits fixed the problem, so 863a8eb3f270 is the solution. No?