From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6647FE7C4EC for ; Wed, 4 Oct 2023 19:02:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F162D8D00AD; Wed, 4 Oct 2023 15:02:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EC7338D0002; Wed, 4 Oct 2023 15:02:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D8ECB8D00AD; Wed, 4 Oct 2023 15:02:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C8B8E8D0002 for ; Wed, 4 Oct 2023 15:02:46 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 83C48C0424 for ; Wed, 4 Oct 2023 19:02:46 +0000 (UTC) X-FDA: 81308700732.03.988189B Received: from out-192.mta1.migadu.com (out-192.mta1.migadu.com [95.215.58.192]) by imf07.hostedemail.com (Postfix) with ESMTP id 591524001C for ; Wed, 4 Oct 2023 19:02:44 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=GPvMdCBd; spf=pass (imf07.hostedemail.com: domain of roman.gushchin@linux.dev designates 95.215.58.192 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696446164; a=rsa-sha256; cv=none; b=pz5bclfgidKfEhCU6th4szHzkLl6EKth599Bk9JtgX5ouFJvGyL4LfD7qz2Cu3143ysYhU H13urc5NAxfdPyPlTE6hGrcY5lU86E0UZ7LdHtZEwcAHGQtphled/NoSduvC1mSHwf48EY PhYFFTr9NP64/cLohY+aKtSktVSWUOc= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=GPvMdCBd; spf=pass (imf07.hostedemail.com: domain of roman.gushchin@linux.dev designates 95.215.58.192 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696446164; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jkCd19CwQrPmu8oeXBKgORvhKgKP0KURMRX76XbJ8X4=; b=Ul5OiDLREgiTyBMzOPJfBfKKPrinvomp0HpKtdQ8A1w8X7SLiezT6UZ2UOYl73Ccm3q4uv hA4paZQZIufMK/VZgIvjRy5KjvHLEw3G+QswfDMGVNTJ6ZWKIN4j1bsWPKE0yL4walBmai ewuV8hRLW3ROL7+fjHQxT0aszsUKdFY= Date: Wed, 4 Oct 2023 12:02:25 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1696446162; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jkCd19CwQrPmu8oeXBKgORvhKgKP0KURMRX76XbJ8X4=; b=GPvMdCBdjfSQr376dX+S6ZkziYW6v58FjLd6pXRyRfIAjZwWPfOYUCigqgOEVLXM4Iq1CR /E4fW+l2mj2UbQ0fEPjsPSl7MjKRgF4s5GrszkP2p0Pzb8/v8PFxTRuCLTw5MQVIJXbbtH d/pR3EHSoW9yJY/LV7jLBB3swXFa09I= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Michal =?iso-8859-1?Q?Koutn=FD?= Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, Johannes Weiner , Michal Hocko , Shakeel Butt , Muchun Song , Dennis Zhou , Andrew Morton , David Rientjes , Vlastimil Babka Subject: Re: [PATCH v1 0/5] mm: improve performance of accounted kernel memory allocations Message-ID: References: <20230929180056.1122002-1-roman.gushchin@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 591524001C X-Stat-Signature: 1z6hkinippibmjsdn6b4xg866ykmck56 X-Rspam-User: X-HE-Tag: 1696446164-971525 X-HE-Meta: U2FsdGVkX18bNpcw25DTKFCFxLmpAG+0WHDpmBh/ixhrtVGlQFwk/g9dPYd2oL6Khnw71veQgXNmYpMUR3YopaHPSIQ20fFNmKbHmJNsrSYP9UG33N0uqUHg0X3iJasRyV0IVWQdPm1yIAskumMkokWnXEUVb7cAvrWV2qr35xH18vz08pmNpyOYdlOzXmKy/vPIHBe4SVOnICPAMKTHIPkxJ/E2JSeejONTdOOn/LRe+6jveRBDx7kFcyg0cB7l8m3iw5/u1Z9cA0MEm+hwvg9DPbXq0AhxLm5LWVE3kE5+taKhsLU3w7yQHUmZcdbZIo/gBy/tOjVQ5LtwueJocC8QIx7K3bICwpwzgXfuYRxXdbyMAHtKT2Je8RzUYHX6bFiUWaOwPoWJrIHGEjd6jW+S7NWCaPxnNChfjrQ+2kl3yJLbFLW9p6nK2s8fhyRt+v9UcIPYDNXBOZ3tcZbkVXv39dpMO5coaDDjLpIlkBqK0XFucDlzNJ6DAqP+OWiskof5maB5FPhNq86kgFvzVZnNhukAgqsse2wbCymS2IarTSa/tOR68YQn6Qck+O4Vv0AXx9xmrkGbrinmDhToIEjP3LDjkLaOCjS79gln5aCIeBHzWQY3CrwxUI/0ypfTDwau3CBeRh2xcLTDEv43N03hIyPLQNWS33eVw2nYLQn1IlggMr1GDJNF+p05jd93wLQVBTVpuy5wRZH8j5oTG7juaFT0JvgSbjE5NVfbTaX6WN1ir1JMkQOVRzabgIIPID9ACT2h/s0hwnsMWWrKIE+hTLQ0SjQkiG6k68myoajQjRV2o+ychHiWPJJxAxJrNiiEooL4RaAUvYZZomd11mh0ewMR5tFGEeGNo7FbDfUQXjZad0LLTJB9Qw13EfLzoJMhz2k/Y/7btpz3bpfI8Z/Uy4KzimtRK81qKHwNdPpx9DkFQQzNhHSiOIEFvsegsY/9YTvYGG9Fhj7wOC/ RD/1lx8k cqQ89ZxoU8pae3CVHlZF5syQptex9iog5UXenT/neXZnAORZaeJKpq4qOxYWXLrViwiW/U4BJcVHPtQbt7U1TEMgAiLx713Ki6E9SiufCbcSoBYY4N+sjGHfXrZnTUfFXCl7Ysi4F87+YngmusAcWyPBMTXMfIsHcYgZ0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 04, 2023 at 08:32:39PM +0200, Michal Koutný wrote: > On Fri, Sep 29, 2023 at 11:00:50AM -0700, Roman Gushchin wrote: > > This patchset improves the performance of accounted kernel memory allocations > > by ~30% as measured by a micro-benchmark [1]. The benchmark is very > > straightforward: 1M of 64 bytes-large kmalloc() allocations. > > Nice. Thanks! > Have you tried how these +34% compose with -34% reported way back [1] > when file lock accounting was added (because your benchmark and lock1 > sound quite similar)? No, I haven't. I'm kindly waiting for an automatic report here :) But if someone can run these tests manually, I'll appreciate it a lot. > (BTW Is that your motivation (too)?) Not really, it was on my todo list for a long time and I just got some spare cycles to figure out missing parts (mostly around targeted/remote charging). Also plan to try similar approach to speed up generic memcg charging. Thanks!