From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE1EEE92FFA for ; Fri, 6 Oct 2023 08:24:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 77B5D8E000E; Fri, 6 Oct 2023 04:24:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 72A638E000B; Fri, 6 Oct 2023 04:24:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 508DD8E000E; Fri, 6 Oct 2023 04:24:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 32EB08E000E for ; Fri, 6 Oct 2023 04:24:58 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 01C73A04BC for ; Fri, 6 Oct 2023 08:24:57 +0000 (UTC) X-FDA: 81314351076.24.5661E4D Received: from elvis.franken.de (elvis.franken.de [193.175.24.41]) by imf20.hostedemail.com (Postfix) with ESMTP id 24E471C000A for ; Fri, 6 Oct 2023 08:24:55 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=none; spf=pass (imf20.hostedemail.com: domain of tsbogend@alpha.franken.de designates 193.175.24.41 as permitted sender) smtp.mailfrom=tsbogend@alpha.franken.de; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696580696; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nbOSKt1M5wfrOeOjqOQSAHW4z9YBZRDUu4WMECkbO/Q=; b=v+KUtUKd4wHyiumew779P/gQx3QF/rnXTgPBlYxvgG/ENnvjEZQaJmWxW89cBr27X1tCzF feoS2xcBDpiH9UpoArenCdm5+QwGZgUqfiqg4nQCxX3yXe8xtg8LqO6gHPq69tfubHKpkv T5+mO2CZFeRMlcIBtm/wOGz2di47btM= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=none; spf=pass (imf20.hostedemail.com: domain of tsbogend@alpha.franken.de designates 193.175.24.41 as permitted sender) smtp.mailfrom=tsbogend@alpha.franken.de; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696580696; a=rsa-sha256; cv=none; b=WTofTjmndctl9hNXae1Y2g3LxkcfjiiYhKDMj9UMN84x++NTUu+9kWn9gAMMrPmEAH620l pNDNxQhOri1zbBZpj6x6A4iI5hWIeMhb+MLiDTxGifHvLrm1ZyW0y49WhS0dhdf6aF1iBb 9KgIQtzSRV+kJ9Tgjmv6lRtwxhnFxVw= Received: from uucp by elvis.franken.de with local-rmail (Exim 3.36 #1) id 1qog8g-0002lT-00; Fri, 06 Oct 2023 10:24:50 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id C02E3C0198; Fri, 6 Oct 2023 10:05:46 +0200 (CEST) Date: Fri, 6 Oct 2023 10:05:46 +0200 From: Thomas Bogendoerfer To: Baoquan He Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, arnd@arndb.de, jiaxun.yang@flygoat.com, mpe@ellerman.id.au, geert@linux-m68k.org, mcgrof@kernel.org, hch@infradead.org, f.fainelli@gmail.com, deller@gmx.de, linux-alpha@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org Subject: Re: [PATCH v5 3/4] arch/*/io.h: remove ioremap_uc in some architectures Message-ID: References: <20230921110424.215592-1-bhe@redhat.com> <20230921110424.215592-4-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230921110424.215592-4-bhe@redhat.com> X-Rspamd-Queue-Id: 24E471C000A X-Rspam-User: X-Stat-Signature: q9iz9m3c98chb837q5qogtnz8rmp3ofj X-Rspamd-Server: rspam01 X-HE-Tag: 1696580695-2616 X-HE-Meta: U2FsdGVkX1+morRApgSSFGlpCVtmQEGcahmg/QzMecXJX5XneX4YJIzWMFCLfr/z00/Z0y16wXgaL7yghKgFVfmqoOQRP3xhX75T9sSwVdDSQwtqrw8H5cN/xAo2aGYo4VsjvLMEX0rW6D1x4clgZEZB9OLfMSNYZP+nZA5xI3OWlZyyyq2UarLDoX6uY2FOC1K/Z4+VsKfE2uoOXK4FCGi2PQB8F+y8/K9r1xB7iuj9UkyFwDLIpkT5TEmR3iw5dEs1aYtkj9q2mB1dKUCwnRoW5KeubOViLqDVCGp5fVUy8HzPh4t4A0dWemKRN9VcvzPsNR7wIxPXRclPkdX3c0kL8SGtgvpXcih+ae5yV3MN8qYeTnrB8D6xJ6aW3aIh44f/nG6Bk1Xd0hBVBMb7UaImpWj0XFKXNLDTeicVf31gogF8wm5rJYktSNFOejvI0ZBQrC3w+lOFLKCRLac39BSuO92CqM2yyB/OQse/hR9ZTzY+IpraSWQ0nTPYOmKyuw24G2qUgRd7yEehfKzTGWnvceaayQel3aXp7PfsyBmoa3bbBAXPXC7NwNAEsEFct1JD4R47eu2GWQb5y0RMqFapJH2BPtT4xEqL5COandy3T/4U+aIE7mgVsezB8XT35DSHGfBwyvb6+5gXoLBSb/r8ZhQ1W3Ax/xPyGqXg5HZhX0QGahgjJIEh94uL5eS7CoIxp1ly3+rev4rtKZC4g1jkOFWGY74UlIKY4IVp3GMTVCPXBdvdt9IIUyoK4cAS9kTuGD3gsZ8fJZeJjEVCjDPfsDaaa7YhHagkLuEqTHtzljCilaJlf6SQGVryCnWgFczV37ahOwPpCZ7QfUX9t1/HTrws591FwrDhRwrjqpOrLAhYHly7w/Homvdl6J45WESdfdcgk431gfSh6Ts5O8G1I7s5rnPvUxCnexX4YJGIuPFXrcNf4IF5Q/J7/MAbeK8b+nEiwnTlruYgmV6 FC5udWCr upsFSmrPL9jwF+UbAdkS173PhdUrmgpVmUUy6NWogV6D0RFMmEm8GUQyP2aJc5M8nb6RS2lb24pQ6xmsau4GmNa0sGqn4hqqHwC6gSNxbdqak+HobP9muE2nbIh5850cGczqgLm6GTV81pK/F8JzLzyuZ1mXrUwbfsLY91m0pmWSt4Vis99J2U+DJn1+4ZuaZqQU6mRetmXmCNjFakjuFdUnFAjHxC9nUYMqiGSVU305447ZkUTvtC6smwxUZSKaFL36ngYE0M8dJo1Lqn45okBR6Sn6InXLQlszCfJvvRSUEWqkXuFL9f39FpqGw8xqm92PTniW8CmY72OEvzj7aTmKrMyPeLnHFZ7y+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 21, 2023 at 07:04:23PM +0800, Baoquan He wrote: > ioremap_uc() is only meaningful on old x86-32 systems with the PAT > extension, and on ia64 with its slightly unconventional ioremap() > behavior. So remove the ioremap_uc() definition in architecutures > other than x86 and ia64. These architectures all have asm-generic/io.h > included and will have the default ioremap_uc() definition which > returns NULL. > > This changes the existing behaviour, while no need to worry about > any breakage because in the only callsite of ioremap_uc(), code > has been adjusted to eliminate the impact. Please see > atyfb_setup_generic() of drivers/video/fbdev/aty/atyfb_base.c. > > If any new invocation of ioremap_uc() need be added, please consider > using ioremap() intead or adding a ARCH specific version if necessary. > > Signed-off-by: Baoquan He > Acked-by: Geert Uytterhoeven > Acked-by: Michael Ellerman (powerpc) > Acked-by: Helge Deller # parisc > Cc: linux-alpha@vger.kernel.org > Cc: linux-hexagon@vger.kernel.org > Cc: linux-m68k@lists.linux-m68k.org > Cc: linux-mips@vger.kernel.org > Cc: linux-parisc@vger.kernel.org > Cc: linuxppc-dev@lists.ozlabs.org > Cc: linux-sh@vger.kernel.org > Cc: sparclinux@vger.kernel.org > --- > Documentation/driver-api/device-io.rst | 9 +++++---- > arch/alpha/include/asm/io.h | 1 - > arch/hexagon/include/asm/io.h | 3 --- > arch/m68k/include/asm/kmap.h | 1 - > arch/mips/include/asm/io.h | 1 - Acked-by: Thomas Bogendoerfer -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]