From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3AEAE81DE9 for ; Fri, 6 Oct 2023 12:16:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0FBD78E0015; Fri, 6 Oct 2023 08:16:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 084EB8E000B; Fri, 6 Oct 2023 08:16:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E691B8E0015; Fri, 6 Oct 2023 08:16:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D3B828E000B for ; Fri, 6 Oct 2023 08:16:55 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 9F3F880143 for ; Fri, 6 Oct 2023 12:16:55 +0000 (UTC) X-FDA: 81314935590.14.C385120 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf25.hostedemail.com (Postfix) with ESMTP id 4DC41A0007 for ; Fri, 6 Oct 2023 12:16:53 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=d1BCfI5Y; spf=none (imf25.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696594614; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hNVK67EoEfC4ks5hIAmDG5CWFmou5FKHiT7V2Fk4tdM=; b=gA/ZXjDDxIGv76TRAqjTgRaObN08489ht3OP0OG5QfCAwoAuhq0qcCvXfnnL4h7l1LQnDJ wKax2l7FEvQ8957Tin+FM5LduW44+0RR6s3eGJvFMe82cy9iu3dSob/ykt67zh/AldrSrr GWOC+4rGtbX23RKMr3G6n5gkmfKZAvA= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=d1BCfI5Y; spf=none (imf25.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696594614; a=rsa-sha256; cv=none; b=uxmX/QymziCmVPySiVVRgk4yQZo+0nH+9Qvh1A2DRreO0EtcXiYytLt2M8geK+lXVMvN66 d0BBkYx/0qS2RzUn3NzPD2cWOm9ujwONGh6HXZTy0mHj1BCVmvtkIa9pfi9rkUq99xdkkT ayQiMcTqZxd6xvTgAhtJYDZHALC+zeY= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=hNVK67EoEfC4ks5hIAmDG5CWFmou5FKHiT7V2Fk4tdM=; b=d1BCfI5Y1aDqG8YFJIpPF8rqpg iX0dqf3J5uWGdolaIETXawNMHPUMFTjjpVZgO+7Ovginh9ff7pRDkB1myntd9n4LyHrItWhkK55gR yKTKZtf3kF/jPbIFSbRmDQp4dO7ohyBJVa2RocafQf5TrNSXflCbUZ5dKsaBAP+NZ5802HQuEHeHQ WosGZ9/Z+Tu/W63PJijMdnT+S950bB+lFBospOiArsxwj320Fy8z7e3hUMlh7HdwNdObkfyNFJ0fo pTS9oXr7tM/OStaBt1wt++t2skwpbA+ybA2RX7PINzg8gq2OoiyUrLB1IvgqRGXNqdp6S1nh5Wc5T 1pXtrEog==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qojlB-00FEWW-5W; Fri, 06 Oct 2023 12:16:49 +0000 Date: Fri, 6 Oct 2023 13:16:49 +0100 From: Matthew Wilcox To: Muzammil Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: rmap.c: fix kenrel-doc warning Message-ID: References: <20231006113948.51673-1-muzammil@dreambigsemi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231006113948.51673-1-muzammil@dreambigsemi.com> X-Rspamd-Queue-Id: 4DC41A0007 X-Rspam-User: X-Stat-Signature: tkcigmsx7ujufkxgjjgaxje48gx4t6m7 X-Rspamd-Server: rspam01 X-HE-Tag: 1696594613-541930 X-HE-Meta: U2FsdGVkX196LHcoVAX7y90qkVRvXtEVI8UdxR7yqKqsHE+07ILOy1yQ4LgKqOHP4iDAajSJh0V0Y9N2Ep0vSop6rxynu1fU3bB5lY6YTcxMAvSFzmH7ERNpgucLS7oXk1Wh6rtMqIfscuAZhFu4XZPPFze05efWHSP+ImxQdjNsanT7VofvS6revX1oXFG1wjExceW0R8YBI+mUczY7WHND+XjKJdcaeugdueI0RYa7VO6myyhLBLuMWdOxddix+gt21Rh3v5L/PMGKxeNC69MSo5Gjb4zj7K7JjA46Yn2ETXh2dFoplG7ZiJPKyNFsFCRoRdLLMOpLkYJJhl1ld+V4Fvk/CRDUEgNANNbQKT/gJ29qGwwSfZG9Wyk5pOJ7jNNT9/H4FfS3KbfhTt8Sysk5eBCf0RvbShPoRAIdp1FtZv8EeG2aS24nCGknfE2yAR7bQhlJcrrOFDtMi7nq6H6ZTEVXuaBs8VtDjTAwM+QPB2rYo3INOms4FN3ZKqf/QBjQBHsw/vaSYqVO1JgpcKKHAIzTGEtTKD64nGTXlPEwugp/uoJ8tMW3cVgP/Awl8NgcTB86wBkzKzO0zMTlTlixmWRS6xFqFahMvhxhtkLaItirEAw2z3M+x26o6U2S43IRgtJ5qDvhlNOUjWnnnPLYmhCIhEsi3TsqbS8l/JYevw4hTPWhaJCifv6r/i5kKeT5CnVX2ynT2B+lCk7Uncu4Xlzqv4awk01wWN3EM5vf3xHlbgH8GIkKj3R72wHOt5wzpcyeiZKNblQf5ODqDSCny/JVqGqDa7DVxYE8/jVopujbMSpDjjoeH1j+9xnb0jJbLMav7fV7l1uulQZMuYU438Cz+Qe2Sdgd/QVZjfEA20ZsIPVQuKWqQlZ+p0sNeAOGCmZK3WGwELdqhUeWgL3wARJ/F+dnBVxveAWz9BTIiFtFmz2TWfEOVC3n72Vtmm+8btVdmLNacYO86Zp 7mKYp8CZ VAKF1HMeT6EkCNzY9Blr6jW9LPqwjS0jTTnni6GXGrxLcaL6XrQc9eDFvQWGDYp7TTKx+1dzPvdRx9fVBkd0hysUdbhOi0fZidyL46TdYhiopBuCer06TZZv+BEadkh8ZQn18qV/vTnjI98KeMSwp0C0hpcQA8vG3yIqAXJpmPzgKjsCEYXeYZsGVztFX2z6psKNlSUF3bBYGy9Q= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Oct 06, 2023 at 04:39:48PM +0500, Muzammil wrote: > /** > * folio_move_anon_rmap - move a folio to our anon_vma > - * @page: The folio to move to our anon_vma > + * @folio: struct folio - Represents a contiguous set of bytes. > * @vma: The vma the folio belongs to Why did you change more than just 'page' to 'folio'? I think the other changes you have made to this line are not an improvement.