From: Matthew Wilcox <willy@infradead.org>
To: Muzammil <m.muzzammilashraf@gmail.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: rmap.c: fix kenrel-doc warning
Date: Fri, 6 Oct 2023 13:16:49 +0100 [thread overview]
Message-ID: <ZR/6sZmNMpMkfxKf@casper.infradead.org> (raw)
In-Reply-To: <20231006113948.51673-1-muzammil@dreambigsemi.com>
On Fri, Oct 06, 2023 at 04:39:48PM +0500, Muzammil wrote:
> /**
> * folio_move_anon_rmap - move a folio to our anon_vma
> - * @page: The folio to move to our anon_vma
> + * @folio: struct folio - Represents a contiguous set of bytes.
> * @vma: The vma the folio belongs to
Why did you change more than just 'page' to 'folio'? I think the
other changes you have made to this line are not an improvement.
next prev parent reply other threads:[~2023-10-06 12:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-06 11:39 Muzammil
2023-10-06 12:16 ` Matthew Wilcox [this message]
2023-10-06 12:18 ` David Hildenbrand
2023-10-06 12:17 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZR/6sZmNMpMkfxKf@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=m.muzzammilashraf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox