From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9177E7107E for ; Thu, 21 Sep 2023 14:24:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 16F226B0178; Thu, 21 Sep 2023 10:24:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 11FE66B0182; Thu, 21 Sep 2023 10:24:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F294A6B0184; Thu, 21 Sep 2023 10:24:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E48136B0178 for ; Thu, 21 Sep 2023 10:24:34 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 946B7A07B6 for ; Thu, 21 Sep 2023 14:24:34 +0000 (UTC) X-FDA: 81260825268.29.3904526 Received: from mail-pl1-f201.google.com (mail-pl1-f201.google.com [209.85.214.201]) by imf21.hostedemail.com (Postfix) with ESMTP id B924C1C0010 for ; Thu, 21 Sep 2023 14:24:32 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=AlbrDscF; spf=pass (imf21.hostedemail.com: domain of 3H1IMZQYKCCQSEANJCGOOGLE.COMLINUX-MMKVACK.ORG@flex--seanjc.bounces.google.com designates 209.85.214.201 as permitted sender) smtp.mailfrom=3H1IMZQYKCCQSEANJCGOOGLE.COMLINUX-MMKVACK.ORG@flex--seanjc.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695306272; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VFujV55InQpfIcmwhWIdcFo9LOSK6bP3ULKilR3pEPA=; b=YS8D7jJG/Q4MnYkvcXoLD1EH1XouYUCXLElz70MIarb+hpjU+uGyXYEIo9kPClUZgXNDwY 6IbXNROYn3UnzlwfUN3hzNG1NgPxEsa9e9o18CVhP+AAHyJZC2bX7ZoSglY3lt6F0n2m68 LXAsly0leL9BU0PaVEioBI8+4xyVAxw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695306272; a=rsa-sha256; cv=none; b=X62uS5fQBHsnkxE7U9TEvpEN3CUgHo82hXfxsjg+yi7k0dydIyR0tn3Y9QK7qYFRqpY7Pr YTXrsM/b0RrMWoZ4o8vKR9fxqm3/fBseTYI9iQL6j3vRWirEN91eOsEF2NvrVyX5mA84hz uvMjaWUbcHS2SF7+almujQ6m5REv0xA= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=AlbrDscF; spf=pass (imf21.hostedemail.com: domain of 3H1IMZQYKCCQSEANJCGOOGLE.COMLINUX-MMKVACK.ORG@flex--seanjc.bounces.google.com designates 209.85.214.201 as permitted sender) smtp.mailfrom=3H1IMZQYKCCQSEANJCGOOGLE.COMLINUX-MMKVACK.ORG@flex--seanjc.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-pl1-f201.google.com with SMTP id d9443c01a7336-1c448ba292dso8362685ad.3 for ; Thu, 21 Sep 2023 07:24:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1695306271; x=1695911071; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=VFujV55InQpfIcmwhWIdcFo9LOSK6bP3ULKilR3pEPA=; b=AlbrDscFcVIBEhWJ/QjLKJNrnCiZ3O/NNK0EFNG+WXqslV/L5lusTzrtLhn6nAEOAd orC0yPpXekP12gWeuj8KaaYlZCyjp8Lu+9FJ4IJB6Hm7qt1TdQpHFfn4M4nM8EHHVUFz dCmt/wEJH7HH8rBLBbdeE5RlrLRLK3BT162GfuLiVj7p/qUrM5ogyRP9516LjZhnG2OX yGLlSkHpDnISjTdycCspWqb4FtehHiUeB6Zx7j0We3G2X253JC9iNCTOWVFvwenO4QBk mVLcsha+J+YEc92MQ21bG9jG5w/6n3NMfkUu2sGdjn8Dl8gUB0uw1s9LyUVVAYOuga0s P37g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695306271; x=1695911071; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VFujV55InQpfIcmwhWIdcFo9LOSK6bP3ULKilR3pEPA=; b=IDtHV09xduJKKFg9JPuU4oFj4V6QecWyb9Pf6pISmU6oCX/hYl3OTrOcObgcKNM/ZY +gPoWSHF0cqaWaaORCCEBvapnsAcdLxypJQaEsJceY1ntZUTWm1ikcJt/75nXsg0ggd+ Oe6fdgUW3z5Dih95rJLshYykOH6lRYDw0GWQmLsehhhXnFVz4rlEPBiUSwgnDBVvYHEM yN+dKQtt/tYqACdWMobdk/plevNXqbBnUotA3gAUqz8mZaPUwF7JwNvWkVeASqgVm3ZW u/kFqzRYjXEQvzXiVgy0LNr4Tirq7Ha8oE3eCzJ0dIoIRNF5pwX/p66VLXjIS1w7QBdQ 102A== X-Gm-Message-State: AOJu0YzCS/sQYbsDLuPGco6ExkTNYJq2M+IyfApiCfnoqhLlhgUqxqqA o08UY5sxrre6gZlP1uQ4Jr6oIfDD3AU= X-Google-Smtp-Source: AGHT+IGn6bxt0aytyfRrQvdNGXaSXeT8sIcIptWMB2qfEas65NY2TcrLdWuDyigFBOjNZ28AUG3erUeC33s= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a17:902:ce86:b0:1c3:c127:558 with SMTP id f6-20020a170902ce8600b001c3c1270558mr71199plg.0.1695306271120; Thu, 21 Sep 2023 07:24:31 -0700 (PDT) Date: Thu, 21 Sep 2023 07:24:29 -0700 In-Reply-To: Mime-Version: 1.0 References: <20230914015531.1419405-1-seanjc@google.com> <20230914015531.1419405-3-seanjc@google.com> Message-ID: Subject: Re: [RFC PATCH v12 02/33] KVM: Use gfn instead of hva for mmu_notifier_retry From: Sean Christopherson To: Xu Yilun Cc: Paolo Bonzini , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , "Matthew Wilcox (Oracle)" , Andrew Morton , Paul Moore , James Morris , "Serge E. Hallyn" , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Chao Peng , Fuad Tabba , Jarkko Sakkinen , Anish Moorthy , Yu Zhang , Isaku Yamahata , Vlastimil Babka , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" Content-Type: text/plain; charset="us-ascii" X-Rspamd-Queue-Id: B924C1C0010 X-Rspam-User: X-Stat-Signature: w65c9ng454qa1ir88bsaw7wdt9hg1oy1 X-Rspamd-Server: rspam03 X-HE-Tag: 1695306272-568446 X-HE-Meta: U2FsdGVkX1+QgohIRRehW1R+Ng0fyz7aiNmz9NyzoeDahAftVcFm6+QkF+3YI6rDk1dWR6bzXsxdGDPsSmvLVRyYY0K1TREOQoRf9JJqRYlu04zYMQfPZQCaA93lQsTGjAAeeB98EheS+PEgWJhKP/5z8YUwP56FW+5kC+H+41vCb/BY9IJwF8E5ndoj2xq6awCTQ3VT4JCJxgSnBiMYWjJ56mc64Zjj7nxhXBdSupqxZzQzdXNCGuLsc/gM0NWnJLUtMh8/61aiiDcKRDYr4hHafj7zk6P0aXeVC0UXb0d5xUHbj7iUMkskTca0pHAFg3rg7Lslm0uladbh7+hLJsX4B56KDX5GpvgClXD9puA9t63fuFHu++nygIifndf+fYdZmf3OqIhfsqzXT6RC9bv7yGKL25F3tOHglvgcPsb0cHXzG4AyjM+aI7bOqygwIou5UxZOs2yfAEH80tpxiAi9Od2c874Wf6NL90v3rNO+CoxGjHgwvZ5E6ghN5ensFYMWk+FqNhvMq0VNE0JMPKm4+PZVz8mVVhY4qBP09g8G1N+IiZwpp1EqIbPKJLpaB1HJn6lwGvnzu/YiTirDWve4XwqgLMBP3q3xq0AMLC+QjwOGTOQ86hdiJvcTKB3J/cdhFCUV7LkuCt5G0Xc9WpvB+LUmUhJPYIVlwC/yp0Micrmtv9YmlL8vx8VuXy3mEwTEmVKJnEoJvZBaaohoyVb6P70bs8oBabXlQHXqT03pXAjXMyn5oVxw2NgRSiGgFywyefKkNo+hOBh+47m9LTHB0Qo50bh2OM8IVPCdydpeNKIYy5p8Uo7hRzNWE8PY70wE0aG5fi1Rro0xJDjiIBWO6R8AXyU+askK63N4a6/E3VojQ8K8erxjES1UQ98n6ptpfq6SSl1wwH9Xsy925VvYnmqTg7hW34nW61FGscPNa6y1p0sdQsWZ+KQnQydN33gLbSmpoiB/3UES0xP 9t6JmAUp kVqZIF5xBEZFTLzX0INSZJXuTaSCHtI8xLBb1xbM4g4tyBLW4t9hdxr9Nfzg1HnMj/prw5i7R33u6JfTbEgaaR6hA0vXqoBGxuUtHbBSz73bBGZz+JP3LoYwMYZ8GT/J6vlVBEFsxi5SnZr0nyn9WZyRzk/PDfS0nBYvPbkv23UlB5J0oM8K13xvimCPfzOP28PZHNDWuUSX7c2Zt/Z4BCwNl2/ZhnDeQ3d91cyZ23NkSagLq+ePkB60nlgGELzhIVtUYN0+jALl7qRkQLZDYYlFShSuTL/xbbgFK2Pck9v8zSKiaEGxATaosAzz0TUexWPD7YmmWZ1N1yOr7hsynh+5UJuOHX9SvoNCws5lEhS4fTWe/QySmlJxgtM6Q5YV5j4tsq9YoUhkPs1vgZD0e+IWNVxhN8IJmZ7DHQ+MnTm9Bd5imlZe8gyd6SRwavs4rcOWgsAlFeS04PE6/BY5SXEPFDsT363JcoXQtmCHwAnOonaoe4pSIbeb56YfkmnKxKBGJPvQeCU35b0JDJQM/x1wUc6UPCyawGV+xyN3JOrhALtcy/ReXUd7TSl/lvQv+G+l3op9HOGTAQ//d2biuI99MDHNs9wJWzTNch484xDcJoq+r7bb2pHEBgi5bA29cyExkgIH64qwLAvmJC4YpWc16kbnEsl1yASUJF82muGKVH17nG2o/yhUkKDMosb37/GhGsDc5EX5YHws= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 21, 2023, Xu Yilun wrote: > When the invalidation acrosses multiple slots, I'm not sure if the > contiguous HVA range must correspond to contiguous GFN range. If not, > are we producing a larger range than required? Multiple invalidations are all but guaranteed to yield a range that covers addresses that aren't actually being invalidated. This is true today. > And when the invalidation acrosses multiple address space, I'm almost > sure it is wrong to merge GFN ranges from different address spaces. It's not "wrong" in the sense that false positives do not cause functional problems, at worst a false positive can unnecessarily stall a vCPU until the unrelated invalidations complete. Multiple concurrent invalidations are not common, and if they do happen, they are likely related and will have spacial locality in both host virtual address space and guest physical address space. Given that, we chose for the simple (and fast!) approach of maintaining a single all-encompassing range.