From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 159BCE7D0A3 for ; Thu, 21 Sep 2023 17:38:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4F9DB6B01FF; Thu, 21 Sep 2023 13:38:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4A9A16B0206; Thu, 21 Sep 2023 13:38:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 371726B0207; Thu, 21 Sep 2023 13:38:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 278726B01FF for ; Thu, 21 Sep 2023 13:38:22 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id F367AC0E9B for ; Thu, 21 Sep 2023 17:38:21 +0000 (UTC) X-FDA: 81261313602.26.0857687 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf30.hostedemail.com (Postfix) with ESMTP id 2B2D580011 for ; Thu, 21 Sep 2023 17:38:19 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=none; spf=pass (imf30.hostedemail.com: domain of cmarinas@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695317900; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MpAHpRS1/HUrXwwYR14JgiI08PNBsdBAvIOSRgbgJNw=; b=kYjhocr95aaxr9CcvJv1tOQdrxnkMz4FS7V/YSFMzN4K/6GKFqMEzkY5cwZiXf5uYSHe+T xJkmCirmFn1cGpQjqmIu5XbK0AqO5IvJVlie/CHV81x8fMxfJR4olTujxZwDbHlBN3clOz gYawdAz1CybO0gxBj/kLRz/uPOrwAU0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695317900; a=rsa-sha256; cv=none; b=WTG9FNYxPjEhdgd6lHDgx10ghmYji5MaV60k68tBlwekbNTXobqwSabD7U7RHZyYQicCmt dj7CVb7Zo0/ESzDvjtdcxpxHXA0foU6FogVEHbo7R6Xo/wrVJtW3beTwTcPRnCq75jWRU8 Um72vk7wSKo4r1VBN+WudVC56fLKOH4= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none; spf=pass (imf30.hostedemail.com: domain of cmarinas@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 1327AB8218A; Thu, 21 Sep 2023 17:38:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DE57AC433C8; Thu, 21 Sep 2023 17:38:09 +0000 (UTC) Date: Thu, 21 Sep 2023 18:38:07 +0100 From: Catalin Marinas To: Ryan Roberts Cc: Andrew Morton , Will Deacon , "James E.J. Bottomley" , Helge Deller , Nicholas Piggin , Christophe Leroy , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Gerald Schaefer , "David S. Miller" , Arnd Bergmann , Mike Kravetz , Muchun Song , SeongJae Park , Uladzislau Rezki , Christoph Hellwig , Lorenzo Stoakes , Anshuman Khandual , Peter Xu , Axel Rasmussen , Qi Zheng , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-mm@kvack.org, stable@vger.kernel.org, Greg Kroah-Hartman Subject: Re: [PATCH v1 0/8] Fix set_huge_pte_at() panic on arm64 Message-ID: References: <20230921162007.1630149-1-ryan.roberts@arm.com> <20230921093026.230b2991be551093e397f462@linux-foundation.org> <7c5c2c00-d657-44fd-b478-743b43c57e8a@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7c5c2c00-d657-44fd-b478-743b43c57e8a@arm.com> X-Rspamd-Queue-Id: 2B2D580011 X-Rspam-User: X-Stat-Signature: msy4a4ubm5p6djwm4mhn3ye9rxfy7drp X-Rspamd-Server: rspam03 X-HE-Tag: 1695317899-536092 X-HE-Meta: U2FsdGVkX18vIOihz7p/v8L66l6u432eJyqBzcbUyPBmXtU5gfcSVZjNjjWgRrhKle5ZWYG3foFKywELWBgo6GkgCfJPaiV4AysIzyNS0UDrnMZOEKutBOEUXEmHchmymQ6sMh7cdMj0raSbCvk/W64hKot9lNXSiraSWJsBdECgUaepS4pzBit8B1N8/vpMoEmdD6k29N+7IomZ18jju40wrf2CCWr+Si7XS4nCVl5jBI+ARE16YNkC+DoYuE7eCA61tX4p4VLRuGDXqJ1mNpnw8doAdKALiE5JH58jXzlSXFSnw5DjTIa10Ug8Yt6mPLuu1aAxu4QNNJnE29W8onSUVipEB7lzSotItwiEAbnuDWgxJ0Mp/qHztWM60W0hPh35QAbPSzZL91nyXMDmL1IEwAa4SbYRCulistgV2crLE/6d3FESi0rUzSmnR6I7XiQ3hd0IfZRJRRuKilC3StNbqJ+jGh1WM3FbqSRCpiMJk9eApJDPShD11rtsXP1SSwBnazqW6h10Piq9DBeNtNXc0DoZbUqvh79btEOqbNBWioLb6lraPDG3efqnySVv03U1aSY60ihmIUm5WtQGaZ2UzEsgZMF6RgahDBsiQkzOAnTEtEx9JwV5UsO+zyZjs6qxvaFQNb/VitFfTgNouQUwTUMeFeCn1XXukkDzT0LcQpc5Gj5h8QKK+rTDy5TWRlulOmvz3v9y/L2e/45yidvf1U+AtgZEiDdUiG0wyBESZzrKOuV8WCFDNSNqKcJ7430BhwVsZbcpPmqKEzsxzJQb7bGtGJoo98a6xyBMsEFAOYMdEgfGVrXIlWQE82zRhzBZeF6N4Uc7Jd3usw/I/n9ZdiHIDa6+HEbyrG/rUqdAKDMjA5Xco8uDOL/n2f7GHu1LYr6a8VM+rv9C+tTjnTu68LfLa9zQVM6f5QCT01Fm1VGo2MmCZpkItg528QSZDj8jES1WwDtglVkAWFF TooKDZ+C tPqf9KiTSF3NfmhJbss7MECLPdF0nWtkznhyvr/k6ytBiTG1a55xTmGS3XBi5jJZeTAuRKwan98XorofO0UztE+Ty3JgGM3aUMxtRNOYOWppYsL91S/1syRzjP/5p2y08GnaDdHb+sKDuhfRH0XuWqHKQFFd7/bIiEkWOVp0nU9gw1ZyHRdDBjTZ24ibqEv4hEnhG7IGQ8YUmhRCK4xyxqsmv/LhYbYZkaehRjeqznL4etxvg06fZL5TshCmePhgwvdx8dqpOKvgTKCFUIMiY+sdgvFlK4s+gp7LKt5DZNjjIbZBpXHcxP4yw0g16esivH1EcBfXf+zlkhkVcuGJJdGdRvC/Jm44FD2tCFC8dLUfvzUApcM5hzkXq58YJCA/Y4LweT1ZO4khjpZeVv6zvWjnIUWw5YU8QuQG8luXs0jXM6+0wS0z51+002NqNw6PvMIKNcI3KgspzrueVcC8wrG7LcjkrHs2XSghnTwSTlDxZoPjj7Z4id3j+rvYC0doA7OF3txku4iXu2EI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 21, 2023 at 05:35:54PM +0100, Ryan Roberts wrote: > On 21/09/2023 17:30, Andrew Morton wrote: > > On Thu, 21 Sep 2023 17:19:59 +0100 Ryan Roberts wrote: > >> Ryan Roberts (8): > >> parisc: hugetlb: Convert set_huge_pte_at() to take vma > >> powerpc: hugetlb: Convert set_huge_pte_at() to take vma > >> riscv: hugetlb: Convert set_huge_pte_at() to take vma > >> s390: hugetlb: Convert set_huge_pte_at() to take vma > >> sparc: hugetlb: Convert set_huge_pte_at() to take vma > >> mm: hugetlb: Convert set_huge_pte_at() to take vma > >> arm64: hugetlb: Convert set_huge_pte_at() to take vma > >> arm64: hugetlb: Fix set_huge_pte_at() to work with all swap entries > >> > >> arch/arm64/include/asm/hugetlb.h | 2 +- > >> arch/arm64/mm/hugetlbpage.c | 22 ++++---------- > >> arch/parisc/include/asm/hugetlb.h | 2 +- > >> arch/parisc/mm/hugetlbpage.c | 4 +-- > >> .../include/asm/nohash/32/hugetlb-8xx.h | 3 +- > >> arch/powerpc/mm/book3s64/hugetlbpage.c | 2 +- > >> arch/powerpc/mm/book3s64/radix_hugetlbpage.c | 2 +- > >> arch/powerpc/mm/nohash/8xx.c | 2 +- > >> arch/powerpc/mm/pgtable.c | 7 ++++- > >> arch/riscv/include/asm/hugetlb.h | 2 +- > >> arch/riscv/mm/hugetlbpage.c | 3 +- > >> arch/s390/include/asm/hugetlb.h | 8 +++-- > >> arch/s390/mm/hugetlbpage.c | 8 ++++- > >> arch/sparc/include/asm/hugetlb.h | 8 +++-- > >> arch/sparc/mm/hugetlbpage.c | 8 ++++- > >> include/asm-generic/hugetlb.h | 6 ++-- > >> include/linux/hugetlb.h | 6 ++-- > >> mm/damon/vaddr.c | 2 +- > >> mm/hugetlb.c | 30 +++++++++---------- > >> mm/migrate.c | 2 +- > >> mm/rmap.c | 10 +++---- > >> mm/vmalloc.c | 5 +++- > >> 22 files changed, 80 insertions(+), 64 deletions(-) > > > > Looks scary but it's actually a fairly modest patchset. It could > > easily be all rolled into a single patch for ease of backporting. > > Maybe Greg has an opinion? > > Yes, I thought about doing that; or perhaps 2 patches - one for the interface > change across all arches and core code, and one for the actual bug fix? I think this would make more sense, especially if we want to backport it. The first patch would have no functional change, only an interface change, followed by the arm64 fix. -- Catalin