From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7851CE79CC for ; Wed, 20 Sep 2023 11:11:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6FF1F6B0144; Wed, 20 Sep 2023 07:11:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6AF5D6B0146; Wed, 20 Sep 2023 07:11:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 59E906B0149; Wed, 20 Sep 2023 07:11:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 4D9026B0144 for ; Wed, 20 Sep 2023 07:11:09 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 1F43740DE1 for ; Wed, 20 Sep 2023 11:11:09 +0000 (UTC) X-FDA: 81256709058.09.0B8EE4D Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf04.hostedemail.com (Postfix) with ESMTP id 4C8C14000E for ; Wed, 20 Sep 2023 11:11:07 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=YBlMVlsc; spf=pass (imf04.hostedemail.com: domain of pmladek@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=pmladek@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695208267; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=G8Oa3m+ynfPIOA5G/28k7a2pfw1DzdpOi8F9BUM0ysg=; b=eUeJd8SR9m+ptqTRNRLq4Eva9O6KO+giDuaUJbZ2Q1dh45D5rU9CSpuoLce9wowJmv/TEI XeKkkqZE3vzKna5nSRVsBEnB9iODimxgjBwoymosL2chA2vuEYmbcOcS7uCgs1fPJRdhLq 09AleEmLi0zS3A/bwnpANViMFALPjt0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695208267; a=rsa-sha256; cv=none; b=ifphPRiUyR9ChFaluYTXQjIDCCysxt4vS9b7ww5ncK//Eigtap+4xk1GS7rm7dIbCnylk8 pP2fIcz33I7CJFsJ/gt3BkTSh+7raWPYVz/VeATFbfUNnt8m9Okxd1TUG9Zs6hRoxyKzu3 p6vdIhUpOYolYyXNWhjPgGMJ9+6iPx0= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=YBlMVlsc; spf=pass (imf04.hostedemail.com: domain of pmladek@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=pmladek@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 2AE471FF6A; Wed, 20 Sep 2023 11:11:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1695208265; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=G8Oa3m+ynfPIOA5G/28k7a2pfw1DzdpOi8F9BUM0ysg=; b=YBlMVlscaK0o6dNfq8Bqt1KVMsksHco8u6voaxf+8yBA/YaQLi0+3Gr1Yf3Io1ASrRwmd4 z/2ugYatYb1vwMa6hU4YfHPnC3+AJY56yUQeKKmCGYIB+nw1oarRZOGo1S3eZB0q2b5rrK khcCw+BELW0RH9tSp/68ta1T1E4cw7Y= Received: from suse.cz (pmladek.tcp.ovpn2.prg.suse.de [10.100.208.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id C7F482C143; Wed, 20 Sep 2023 11:11:04 +0000 (UTC) Date: Wed, 20 Sep 2023 13:11:04 +0200 From: Petr Mladek To: John Ogness Cc: kernel test robot , Thomas Gleixner , oe-kbuild-all@lists.linux.dev, Linux Memory Management List Subject: Re: [linux-next:master 5670/6619] kernel/printk/printk.c:2871:24: warning: array subscript 0 is outside array bounds of 'char[0]' Message-ID: References: <202309201724.M9BMAQIh-lkp@intel.com> <87a5thtas5.fsf@jogness.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87a5thtas5.fsf@jogness.linutronix.de> X-Stat-Signature: f8r8ydmrwkqmi5e9wg34sts1edjiaf6n X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 4C8C14000E X-Rspam-User: X-HE-Tag: 1695208267-140129 X-HE-Meta: U2FsdGVkX1/UWKistAOVM7zZ6yXEvlG9iDrQC16fyZzoIxZvNa/UwBfbwisfAgUDLBkXwHBDKH74ZgwBe/DY246mhSwDRyzre19UNKT1irasj7zPri/h7+XzO5RZv6IGZgqV6DbXOUYCbysZPdSdyZ4SVNJC1QIuIPHs386T85UXqyGr6UVFkcN48YgGASI7B7RLwegT+9X0rBRpcMjXh2JI5plkMRspq6V6PqTzOnV0erGBc5wgmuc9gcR+eJtP73Y8OiJiivFNWAcryamw2UI0EdqCZJj33oQZkR4PbcuZFgRK+1WOvwnyj14YniGHIcl60OcFahx3ccCsJ7WtdTRkrLHoi9JezDFiB0OaiAKD4q5VLmVf4LYptIASMpLNaWUNKNr+CsvdoeKT3XpTe7K68g/8WWzxlLMIYarT/H1/SG4A4bGHwYLk0M+KXC4JHEJgYSHwHfKG9LR6GAr05A5JzIE+arv/JG352JuMEUWiW368hG7L2uo0+WZWBdCeUsb9DSVO0rvyaOrFDCARzRJVZikAJk+tKSmsKpED15pmUDTVUz7cempX9kHgX6q8ZLXH7aYRFQ41W5j4oOl0NUJU2/Zm8vuYB0Cb9EfbvR+LutZYEsIWuGWXOJiJ1g1C56uokpbNV9+wp5vRM762v2mBEPypIxpxvK3ZJsp92RRl03u5HB+vUh5InBqroRXSL+pzafuEFbrFfOm9r+l4r1uE6IU5GKQTMc+poKMXNp/3EtPv9hm3HKWuqHPAnyTuL8dzmJlQzERG2bAKRneGmg7sK+j7CNujZnKLr/zQkvARs0o7pGOJTRPH7YQDZp5Y++E4tUQt8ngK5s4lPei9i/AYjrb9rGP2nSr7YY/BJN7BpNOo0Oh5g0Ed4bdOZcbwscbcTu7+E0EqCq/FP7el1dGZb6dKi3sq/r3Dhj8w4Uido2pJafujwBwiaIzX7oQw5T2McBtMFxDKYprrhVW ugBcMwMQ EfH2nrx+IPEysAChU1m8pa9Kf7S2cCxTutrZRbHmiJPdLNrRwpsfH0p+tEFyfdEgeM98pOwhrlZ5vrMGpy3y9ngWmwI4LQtlyeU2Lc/ZxlaC3Iw0LKexqFhyO8iO49mc10A/h0zRD57PnvmEUIi+bHBdl742OUsrTofIeC7N4Tk003kQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 2023-09-20 12:16:50, John Ogness wrote: > On 2023-09-20, kernel test robot wrote: > > kernel/printk/printk.c: In function 'console_flush_all': > >>> kernel/printk/printk.c:2871:24: warning: array subscript 0 is outside array bounds of 'char[0]' [-Warray-bounds] > > 2871 | char *outbuf = &printk_shared_pbufs.outbuf[0]; > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > It is crazy all the things that get compiled in !CONFIG_PRINTK. We > definitely need to fix that after this rework. > > As for this warning, anyone have anything against something like: > > #ifdef CONFIG_PRINTK > static bool console_emit_next_record(struct console *con, bool *handover, int cookie) > { > ... implementation ... > } > #else > static bool console_emit_next_record(struct console *con, bool *handover, int cookie) > { > *handover = false; > return false; > } > #endif Looks good to me. Best Regards, Petr