Re: [linux-next:master 5670/6619] kernel/printk/printk.c:2871:24: warning: array subscript 0 is outside array bounds of 'char[0]'

[Petr Mladek <pmladek@suse.com>]

On Wed 2023-09-20 12:16:50, John Ogness wrote:
> On 2023-09-20, kernel test robot <lkp@intel.com> wrote:
> >    kernel/printk/printk.c: In function 'console_flush_all':
> >>> kernel/printk/printk.c:2871:24: warning: array subscript 0 is outside array bounds of 'char[0]' [-Warray-bounds]
> >     2871 |         char *outbuf = &printk_shared_pbufs.outbuf[0];
> >          |                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> It is crazy all the things that get compiled in !CONFIG_PRINTK. We
> definitely need to fix that after this rework.
> 
> As for this warning, anyone have anything against something like:
> 
> #ifdef CONFIG_PRINTK
> static bool console_emit_next_record(struct console *con, bool *handover, int cookie)
> {
>    ... implementation ...
> }
> #else
> static bool console_emit_next_record(struct console *con, bool *handover, int cookie)
> {
>         *handover = false;
>         return false;
> }
> #endif

Looks good to me.

Best Regards,
Petr