From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EA1ACE79A9 for ; Wed, 20 Sep 2023 01:47:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 96EC26B00F7; Tue, 19 Sep 2023 21:47:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 91F326B00F8; Tue, 19 Sep 2023 21:47:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 80E0F6B00F9; Tue, 19 Sep 2023 21:47:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 70ABD6B00F7 for ; Tue, 19 Sep 2023 21:47:33 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 49404141150 for ; Wed, 20 Sep 2023 01:47:33 +0000 (UTC) X-FDA: 81255288786.28.24C7181 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf10.hostedemail.com (Postfix) with ESMTP id 0D6BEC0002 for ; Wed, 20 Sep 2023 01:47:29 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=kMnSvMEj; dmarc=none; spf=none (imf10.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695174450; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=B6fVdNZavzGdJHgGmbvTSHR7vKQueME4Vv6cC0tZ1qI=; b=52bCscwPha9E3TCvE9k5mNqA66cW0hNEPOzH99SYtc938osOlMWHl9w4p54BanWu7FpxEN /R77E4w+3OhNMTEu/ZxOeGH8SOEfBp8cTtjBxUz9DvU7ANe5g3pqdlyuiMkwJd2sN2TAi5 CVUVcMr4Bl1m6T+80/G23r9NR4m69+Q= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=kMnSvMEj; dmarc=none; spf=none (imf10.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695174450; a=rsa-sha256; cv=none; b=VOSQDkBcKLD2P4QMIR0O3JN2TXcrU1reqDtLtToIdgFgyxSIh6x5qPrxoZ5zbM+B4EPOZV yzT4A0LJSCMylZx/iftcuHln//vETqRAw88xgCvWouOeGYXawjDn/kOsZao/Q1a19apfSA RbH2UX9HvjvXgaI69CD9QwAW1v2Qdus= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=B6fVdNZavzGdJHgGmbvTSHR7vKQueME4Vv6cC0tZ1qI=; b=kMnSvMEjsSMH6Z7QfusCGBOms+ Gdbdv6aeEs/qiWyqoDDHobGO6H5wZsHycQ3ZMUTfiq5KPl4odKm7tUi0l/ozj3GSocfzV7GtJ8aGa HkoxCz6Q+EWm0uNzvo2yZXpO9W95DVyl8sg0USmq8Urzkj/d/33z9JmFVp2enSaOCUaB/XoGpQh6z bbY4SSE8HxsFjVuDXbDagT9knRYvqlrkK9AJnlHUaSBIn1ULhJxPilluhbIssbeA/Lu7egeE22MGW z/Z+rS05DVbsY+cZxWiDf+SyX8xL7d7SxOfnHvYSN1HG41r7PYlN5e3/pFOsLDmCjf6fOlFueZU7y FCu5Tx9A==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qimJC-0030pn-Sb; Wed, 20 Sep 2023 01:47:18 +0000 Date: Wed, 20 Sep 2023 02:47:18 +0100 From: Matthew Wilcox To: Yin Fengwei Cc: Dave Hansen , syzbot , akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] [mm?] BUG: Bad page map (7) Message-ID: References: <092a9bb2-727e-5849-fa4f-18535b998efc@intel.com> <97e59c09-30c8-038a-a6f9-3d862a0d3ede@intel.com> <381e4ccd-47ee-955b-f7af-fe192bea0cd4@intel.com> <2897a87d-ce56-fa40-8195-6e9c1a9de6a4@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2897a87d-ce56-fa40-8195-6e9c1a9de6a4@intel.com> X-Rspamd-Queue-Id: 0D6BEC0002 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: wjhanic6hwioenst9ybm6ckbwwfdqxpt X-HE-Tag: 1695174449-157876 X-HE-Meta: U2FsdGVkX1+4cqF1siyLMnROqhZNFr0tX+VI/Wjb/0eF0CuW6wKDwlInrNqobl7B5W/CrHQdWLKzYtoL0wvKbk1zEPY6eMP2JAU5pYswExiJgvtEiFGjPMF9IDRsObw00HzvTPkQ0QZOdF4Um7lAQSa+TM9nTDwyxsBaeJtTwltd6OiQ+GAc75NgAU4fwccGG8Y500u/oGhrFMdVLdZPHJn5IyTMXcjNeH8QDjLQEDsF+vtuPx8KSPQrX6+VtwtFPb8lu3UKRA4LN6hTsrQLnOBLc0cq9kyBGCeaBx4sP68kh1Wuqry2POr8jJ+wx3JFvG8sdnkSn6Ly2VL7FOQdW5RjIgJtJMgED5iM1gpMFbVDcmWqqVlVbon0cpVu/FXOOD2zjMQjS96lPpvs0l5A/YunHl4iHOT4PPP2KtPrS2uETkNQqxCm17yvQr4uRtEC7MbJprK2C/Zg52zn8gbSvLwm4dKv33BF1zp9SxGHAknDOxMB0UNzoCm33zO1IZZD80DZx2bTEQC7UcO9Jz13/a1dhu6vNq5SYPY7K60WG8cSAmMzSeJiBGMCAtlg9O2fhXjPOpBd9+uGAd4Gby48j4Alue8bNDSE2VL7HbnJvPAX+zVX9E6T5QwE0xLO5X8DIlqQCP7PuacgM6+M+uiELqaFdCfW9MlWFgoaa1NGJY7IwbwOl4lGGA3wsmiw/m7ow8e9DzBAivVSZuOVF2/TwIveVFCUz1r00SnUtXnw/tMwuOz+XUhEgoRhoGrXybNF6f9S/54ftrPS8Lld4hTsdpW6TsHQGJWpoATsF6ucRiYL0ZbNXIDLGJUb/+IvnAYXV8MjA7ewdSQkub7N5TkmLp9+bSHfQwe3Z7aq5XRPNgozKZz0vzQzF4jE0bl4RKC5NgNtTOggnFGt4I4XePsutlOY+ELUdsuFQS1Ktupy3XVKnXwV01rfPp0hmrYCoGiNW/Z6oBlAg+SUFFO339l Qu4wrz2j d4PR63mXVgufycABesEwrPHZGg1HpGIE4ue7iFs7YHmtRb77jmJR2dRwKPI6FdduTk6xUV3O9O4THlwxLThTSm8Bng7YeP550QZAUH9cXDiHrIEVWV2tZmSot6jvVZsnkZyK+L1w/Zt4ASSgBUZuhnO7AWWl0EewAYlgkfY5Q9vC7mCR7lxBu2M3Owymoy15OkT3/Qj5XgOntz8cNsAjAp0vSIRH4Q6HITQrQDrWWrZdpHtIPaq/9hMaA5BUEvlaRC30CZucq6IoYAD15kW+3aLACCWB1rGdvCKtY2gckuMQO/1OAKs5nrN5Pn61eWEkkcr1eeGUdL9k1VEpbWswkU2suNP9Bi+mVOR9/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 20, 2023 at 09:29:18AM +0800, Yin Fengwei wrote: > > > On 9/20/23 00:11, Dave Hansen wrote: > > On 9/18/23 18:11, Yin Fengwei wrote: > >>> I will find a test machine to measure the performance difference of these two > >>> versions by using xfs + will-it-scale. Will keep you guys updated. > >> I'd like to move this bug fixing forward. Based on the test result here: > >> https://lore.kernel.org/linux-mm/124631ab-eb4c-6584-12d4-f3c91e69c873@intel.com/ > >> There is very small performance delta between your version and Dave's. > >> > >> What do you think if we propose to merge Dave's version? Or do I need collect > >> more data? Thanks. > > > > I honestly don't feel that strongly about my version versus Matthew's. > > I like mine, but I'll happily ack either approach. > > > > The thing I care about the most is getting the bug fixed ... quickly. :) > Same in my side. I'm just redoing the commit message now.