From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37123CE79A8 for ; Tue, 19 Sep 2023 17:23:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AB93B6B008C; Tue, 19 Sep 2023 13:23:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A41FA6B00A0; Tue, 19 Sep 2023 13:23:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8E2916B00A1; Tue, 19 Sep 2023 13:23:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 7A6216B008C for ; Tue, 19 Sep 2023 13:23:53 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 482D7A0362 for ; Tue, 19 Sep 2023 17:23:53 +0000 (UTC) X-FDA: 81254019546.28.43573A2 Received: from mail-yw1-f174.google.com (mail-yw1-f174.google.com [209.85.128.174]) by imf04.hostedemail.com (Postfix) with ESMTP id 6D8F24001A for ; Tue, 19 Sep 2023 17:23:51 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=OywhIw0Q; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf04.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.128.174 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695144231; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ke+rhIpc8Yj4RHSOIcCUf04IBals1/6zBz6t3mWbRfs=; b=XAyISJ5ulXJzDTg3MU9+LJZvBK6BK4LuVwbkxeulqjdmZwqAChw89wslvRDOIRBl5qTdxp 6Gn3Nz+TBERIyz4paHfAKS6mMqAPJNbATr8zXYfgSqDOeCgxF8xLPd+y0kUDXzK3huhxg7 +ByZK7G2wpU1HYeb46y6XnS+6SNA9as= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=OywhIw0Q; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf04.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.128.174 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695144231; a=rsa-sha256; cv=none; b=p4S6g2CMS1Ihmtrsx9x2M3ohkPdyN9ASVlmnmxKgbGR1gI48Ehr/qzyqhm7zC3kXy5RtK7 Jf5W1bxVzsYdD+zp4p/etajdNOKDE1MNclEKiv5FIXv/j2AuN9PJnYQhD2cuY+J43W8klD BAUet9Q4bKQ7Oor3RAZ9a5bcqFV0mYw= Received: by mail-yw1-f174.google.com with SMTP id 00721157ae682-59bebd5bdadso61362597b3.0 for ; Tue, 19 Sep 2023 10:23:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695144230; x=1695749030; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ke+rhIpc8Yj4RHSOIcCUf04IBals1/6zBz6t3mWbRfs=; b=OywhIw0Q9TzsCQ6w+4wa0YdSG/Tgte9+q2ClPTf6aNfthTF2Ss63LSJsj6tPLGlLC+ fWYejOMHKrhznOzPGToJ6VDrE6u8jetIOquYs9BSxCrytmOVeJdar+MuABkhTWH9mz8x IWFbX3Z2l6EKUKh4wVqsVURnZSlDycGJJRx/w+Yh8Dvyyvjgys4wVEJAq4ZF5Mdf0RFL JXCiSXtCXdNOUhiqLJPwJvRq4NuY6Hu0e6aQgS0u8t0Ls/3jnX3b3gIfvkY9upi/G4PH whE17502tBmvS8tufsZP0nFHjxLHzB3cUWRs2LRrCycI8Iaj9mRFHPC/599eEtNw1a9c FPZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695144230; x=1695749030; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ke+rhIpc8Yj4RHSOIcCUf04IBals1/6zBz6t3mWbRfs=; b=ixGixMIcTu3+dREtAJcH95K72FrJAWOikrkk+v1wQtDMuvtLtay7/oY3JufR0lj4+e VegBMm5+tcYP+jEw/mki2AmIXzAZIkYf9/UetBwZ6j6ekhN4q4Evvw3vQPPbOGCzC7Na D5qSrp2zgAzWybF6MYwVDLZA0xFT23yWSNa36ZZy9NitmafM5oVth+ljTSjr6aGWaqRC i1Xt6mZiQa8Mb9wnfpY+gNSYACiyoc1aAARUHkxH0IpZuoCBQuWmeGLXzqJERuUBhEnp jp7a6zc6ipDSMFV/qfqhV6ZpwrOiEuFzpHg4XQKADqCWvBR6/Bgill3N9FpEBveKUwQ5 WqmA== X-Gm-Message-State: AOJu0Yz1B5Uc8MTJi+S9HWRTOzmmS1db+9JdkFAqmjrZy7dwB2NkUw0H 3GLOvKI5XUCFewi39KxXneU= X-Google-Smtp-Source: AGHT+IFYba94/tWKEV5d0wk1Ylg0gSJJMGYXAHDrHy5oPNZruwSqpKZ/9cU/3wLGaHbcTR7JOuKvlQ== X-Received: by 2002:a81:4810:0:b0:586:9c4e:a9a4 with SMTP id v16-20020a814810000000b005869c4ea9a4mr145786ywa.5.1695144230386; Tue, 19 Sep 2023 10:23:50 -0700 (PDT) Received: from unknowna0e70b2ca394.attlocal.net ([2600:1700:2f7d:1800::16]) by smtp.gmail.com with ESMTPSA id u127-20020a0dd285000000b0059bce30a498sm3316842ywd.139.2023.09.19.10.23.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Sep 2023 10:23:49 -0700 (PDT) Date: Tue, 19 Sep 2023 10:23:46 -0700 From: Vishal Moola To: Baolin Wang Cc: akpm@linux-foundation.org, will@kernel.org, aneesh.kumar@linux.ibm.com, npiggin@gmail.com, peterz@infradead.org, catalin.marinas@arm.com, chenhuacai@kernel.org, tsbogend@alpha.franken.de, dave.hansen@linux.intel.com, luto@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, arnd@arndb.de, willy@infradead.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org Subject: Re: [PATCH] mm: add statistics for PUD level pagetable Message-ID: References: <876c71c03a7e69c17722a690e3225a4f7b172fb2.1695017383.git.baolin.wang@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <876c71c03a7e69c17722a690e3225a4f7b172fb2.1695017383.git.baolin.wang@linux.alibaba.com> X-Rspam-User: X-Stat-Signature: 3bepks4q1shizpcff1sfkwge9q5981hp X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 6D8F24001A X-HE-Tag: 1695144231-355186 X-HE-Meta: U2FsdGVkX1+i9hupjedu2jPbZKOOuzq8TZUXuiydtq+Pp3BogrR63vNobmk2oCdnv3JbFYwdLH8RGXWeAxD5sYvLwFS7xS2zwzgPSx8CMtGkRZ4eo7FyMygRy+XtbpjurkdKIsu3tdfpHdFzg6NIaysfK5zcU9UJrcSmI8ozV5eeleNHa11Izb9/b5KxDmorx6TT7ktsY6spGk5hGctILsVxL0GIDfF5WSxGuCMJBaxZjGR2O2Ehwfm7dvxzxJ/OtESxQgZLxEEF3dF6R2ovzSwy40yyVRttH2W4axykPVZz1xqw7lq7tnIA1jFxwYxcu/w1IgvZ4B3q029btl3wTReveg/CX1gJlaG0S1/UZNBX2Au003++oI6fxrzqHKs9efywSxZIklzrKs6CcIu/WnhD5zOdn9F7zhqHQcn54HhTdL6k+RaSpko0QRnTbgWFrrS4CqzL0M/5K6sQ7cUGOM3DiS7znDGzkEp/YLS+fo8zXwmFDdsW8VpxgiiED8JvAiZrHe1jmpteRXrRbs1ee7SN971MZCUAP7MLBMCf4Osv69cQdh4HogBYPNWsWWGWakjLgKsc+CwRb8kztTxf5lOoVydIj3zIvkeTme8eUKVif2KJVQ7bQrrwv4yxw5k9l0OFmo2l8W+7hCby5DgPxXQNtwKkG5ZrkH03ARcCRrJWz232NhTRlEsUOGt58mg7MWZKlufLSJZWEhveuMxChFiDBHtEbBBUlE+qp8PzvrrTvk3EQbKfQWTLNJ/L6xUtw6jS1sKjYnwCoBBifa7wxR2mvnzuX+o3Af6InUyQoy65hUy61B4iNU1hONnnvT/bebf5YG22HLJPvhoc/GQbxh8gKOazfX+eYKiGj3aKaP2Luhvpuzo6Ul4TCV5k7CoO30c7XSAwLmhTW5qEe5LbDlqbilw9DScDaSlK78E4OfpBQHXcjB62GY/fGrCPMOtv9U2XyhauGcxSFKeDpzl sNgEF/la fT3RxXChw2B5aewnIXBmI04fzJkT7/jfn875zRe4mgieH6JXnKmnrU4tSZ88zjDhFKwOJkwmRKajmHLOUMOYc/bzxneZ9E6XSgdHm7bu27oiA/fIvd10c6ZHkO07lRj6fyRQPsua8xCgrgY/+EVgSrQj2e7/jvR4OzlI/CCQI/Ty2v4l4+M2lEuOqAkAu/F7FlF+wsIukzHpWkRw5ZGgGWptTkiRMbKsc5cVlbJcoaRAT2TAn5hzuWMW3kgMysHo8oByYLxBV9El7ucdbEfYTqI1XEPK9CsDh4ln8HKKlqdGF98p7xDL0HOOO/3D7nbRukwzMjSZKxvtV0Llss1WNhFJpq/mHUMa7nuLHvzUyEnMB197qMlyrvSUq36eWgGuupcoXbBsNg2S19MCfxwU5jk0R4b9qVo9ILiWIJJkun7e/lxQDLKUN26AeVxzy3J1E5Edl27alb3KVgrAihrtxUP6T8XtvEvDyc/y5 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Sep 18, 2023 at 02:31:42PM +0800, Baolin Wang wrote: > Recently, we found that cross-die access to pagetable pages on ARM64 > machines can cause performance fluctuations in our business. Currently, > there are no PMU events available to track this situation on our ARM64 > machines, so an accurate pagetable accounting can help to analyze this > issue, but now the PUD level pagetable accounting is missed. > > So introducing pagetable_pud_ctor/dtor() to help to get an accurate > PUD pagetable accounting, as well as converting the architectures with > using generic PUD pagatable allocation to add corresponding PUD pagetable > accounting. Moreover this patch will also mark the PUD level pagetable > with PG_table flag, which will help to do sanity validation in unpoison_memory(). > > On my testing machine, I can see more pagetables statistics after the patch > with page-types tool: > > Before patch: > flags page-count MB symbolic-flags long-symbolic-flags > 0x0000000004000000 27326 106 __________________________g_________________ pgtable > After patch: > 0x0000000004000000 27541 107 __________________________g_________________ pgtable > > Signed-off-by: Baolin Wang Acked-by: Vishal Moola (Oracle)