From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4902ACD5BC4 for ; Tue, 19 Sep 2023 14:03:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D0AD86B0539; Tue, 19 Sep 2023 10:03:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CBADB6B053A; Tue, 19 Sep 2023 10:03:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B833D6B053B; Tue, 19 Sep 2023 10:03:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id AA11C6B0539 for ; Tue, 19 Sep 2023 10:03:40 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 63287C0DB3 for ; Tue, 19 Sep 2023 14:03:39 +0000 (UTC) X-FDA: 81253514958.08.303A6DF Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by imf25.hostedemail.com (Postfix) with ESMTP id E4B5EA015F for ; Tue, 19 Sep 2023 14:03:09 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=BYrMxK71; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf25.hostedemail.com: domain of bagasdotme@gmail.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=bagasdotme@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695132190; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PYn4vYjqybxZ2CzfvZ1C7yMXEKjRphlK8G76dbCmVAc=; b=KSKcyZ76Os4FQAi0vA7T9k5CNbirAf7hZNE7EuDxZEs7aonzm3K2JMm+BoPkgVW4YGZvC3 P2GO57/9wgm/kEUlxVlGYoM5n8zMITCnc/9X2UZjfcaUUJVPipKvhn/wQJo5PjbP2JL4jm KtbOn27FV97zPBoN35w7vBn+bD6qsAI= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=BYrMxK71; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf25.hostedemail.com: domain of bagasdotme@gmail.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=bagasdotme@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695132190; a=rsa-sha256; cv=none; b=S7vxjucMcXeU1LZ4prEgOlYAsaTjlXEEX+AAI57hyoHnkNVgbcFfzSQmYtxMChTy+pIKF4 OaADTJOktfSUIKCqMJEfRKMEJAgdxYlqZi8dbS3dBcnyYXa5cO5AFOahHd3uyDkg+SW1r0 zdalMbtIzc94E1XkGXLatNUWtNRSN9U= Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-1bf55a81eeaso42335125ad.0 for ; Tue, 19 Sep 2023 07:03:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695132188; x=1695736988; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=PYn4vYjqybxZ2CzfvZ1C7yMXEKjRphlK8G76dbCmVAc=; b=BYrMxK71ylH9o/zQhwhrsuIl84QoM2+xmKs0m+Gsmav1hHHbalGbng/ueYcpGAfULp Sz4BIT0LibGkZDw00SNBqJ9HeccPzh6suWmPc0ntIwYwU7g+CEBP2IHNWnK86pj8GYVh CRb0zAR0HqZmMszMpTpreDGqI52Z0hJH8gjeY47eytYCCNr3nl8icNVD5ZfEslXe4jHJ 1jKJzGTRUAIQ8KPxdnbTPU8DW4ve6SMF40EvcFJ5FCy50bGzXcQg9Sd7o7PzGkTW4bRY SZHqe60RXF2JyCBvMq0uhOzXUnVdEgRt4CfBEn2y5wxiLP+iNKoKy/HY0tREGLFiK7Fy JSZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695132188; x=1695736988; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PYn4vYjqybxZ2CzfvZ1C7yMXEKjRphlK8G76dbCmVAc=; b=pPwWEfGVEoFyqe1VvWTMM7FGNZ5Q6Tmb9G8DfBwmp3aIV0i7972kT30MeOb1FZqRSG rs9SKG00fXBFXFwHjQtwvjZJ8MzI7H26NiOXx4ecBtMr0uPEmC8x47ZqLnuhz8pg3rNg D2+bA7KXPNucZrtl024J+HLhrMdLz0ahT9DB7RnHt1oNeGDEah+hi5DXw+dyBNuNixKB zTjjO2CsdvrWyFDBW3BtAaKMUWagZ6D1byFUCyy2Y+zsKrJ6Vxw6zowgOmVfgBMWiYuG yXoVNFnqJXUSWTw+5rRN6WR4QhlkuyVztiy71Fxqz3JtqdyPVUhI6gF+c/ELzN7sdIYT reQQ== X-Gm-Message-State: AOJu0YzRQiVAnjxqLgA/MtGeO/s34Eep1/a4x9mzlx9usQdfXIbOUgSP y9BBzTZFy1rdpx/pZkMZSC4= X-Google-Smtp-Source: AGHT+IGwwKUALeHqOp8CRjZ7BjDjcFcSYhkLiMtNnowNteilCqrInFdFlEZiMXIIUrM2Bcc35bHHPg== X-Received: by 2002:a17:902:e5c4:b0:1c5:82bb:223e with SMTP id u4-20020a170902e5c400b001c582bb223emr3883918plf.67.1695132188320; Tue, 19 Sep 2023 07:03:08 -0700 (PDT) Received: from debian.me ([103.124.138.83]) by smtp.gmail.com with ESMTPSA id z12-20020a170903018c00b001beef2c9bffsm10062609plg.85.2023.09.19.07.03.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Sep 2023 07:03:07 -0700 (PDT) Received: by debian.me (Postfix, from userid 1000) id CCEAD81A82C8; Tue, 19 Sep 2023 21:03:03 +0700 (WIB) Date: Tue, 19 Sep 2023 21:03:03 +0700 From: Bagas Sanjaya To: Oleksandr Natalenko , Linux Kernel Mailing List Cc: Andrzej Hajda , Linux DRI Development , Chris Wilson , linux-mm@kvack.org, David Airlie , Linux Regressions , Matthew Wilcox , Matthew Auld , Thomas =?utf-8?Q?Hellstr=C3=B6m?= , Linux Intel Graphics , Nathan Chancellor , Rodrigo Vivi , Matt Roper , Daniel Vetter , Andrew Morton Subject: Re: [Intel-gfx] [REGRESSION] [BISECTED] Panic in gen8_ggtt_insert_entries() with v6.5 Message-ID: References: <4857570.31r3eYUQgx@natalenko.name> <6287208.lOV4Wx5bFT@natalenko.name> <2612319.ElGaqSPkdT@natalenko.name> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="qr0otETeDhzUuptw" Content-Disposition: inline In-Reply-To: <2612319.ElGaqSPkdT@natalenko.name> X-Rspamd-Queue-Id: E4B5EA015F X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: jcnzr4t5yj7qaj6ecidimhcpp8aj54qd X-HE-Tag: 1695132189-574654 X-HE-Meta: U2FsdGVkX18ld036nQS41wnRYGKufKxlQXAU/1GpLiHtv+YjHFhmaApOAeTX4nBaCISBmAnNbZLq+9t9ghTsR30JO5qpyB4XAGkLWi76H7u92ElJjJASunvB7jh2jwaF3r0NMsI+BNRsadnMBD/Ddol5CyvgfY4Zjcg5VZgEuEAh8cm+MfHJSMlm/bji8eLLlHvv8Wb95D8YY35L/8T08JNJVVPWrjZ8YTZ/+LT3ZtyDKg2h36y4oJdqNeshwJ7lKAE/a5QQXRs7eaE5teirWhDzJcEg8NRwGIo+iVmwI7TcYzjBFVKw3InjGyksC4kk+3rXNOHINPgSPhyOjvFZ5j/e7X1ziZv4lirYLuc7yGOUFimYXXYmta6gr7gNZJbQ0cHDkYi3Q7bGQCpUxpRxYCbTiFOjc/j2A/Rk53/ILqNPx3zr6XwaBfE7QZEeNflXwnpKmfdm2jf4MTNzx/Ac0LuQ+b/ZMsv/8b0dhpMBflm8cuCDJZ177bjIRJ+YId4k6e5nE3t04gabFkrKMgDudRoI1TVEDTXFFVKeNEVeuYk//ztrkL0hn2lTChj8C58T9ZZrdQsbp6hP/nCqh3xB4/X39+ChWKKrVZQyb6ZcCIfXQN9wkus9MnvzpPSqSu0iXDk8Q1ZykV9Wzlac4AU9eMRZMKVMOYqheZEXut/UrCRdhMv4xLCrs0bjQw0Ij19IFHaitN8gVKtStsI0iF/+tQ/bjXEeAAEUDxKnJ5oOLVWUH27LET74J4QnzoDW0ACaJRv0zUFJYfrWmwD4clU34/qzL7njH22m95ZVAzjj6T8om4pSFcp/hyjY+YpfbsSemQVy02VGdZJwmX8fDEtFqW6nW+TXGgWVi2k4KTgPodxFZsvzrvg0qRTNQpLpTm5dk2IvNMgPYRt3+8wJTSj7C4SZMopZrVE0WxQgeY0Rl5uG45AQ/r92T5PZic/pdBaIGB90mTGCV86JBss9ssh dbCHiBQA VD4DrYzC9F7sN6606mAI/3Yb+SiWg2M2X8O+tPB/3IL3ERp/YL+FA7ttKNWoT6/xAbXzWdD/Oq514M6Uj0gIxAqPNeWwCtDv+8qoAZ5Kowd2BBABFOwm5r9aHUFHHwOTMRWAvOB9BmQMi8AwhEPNW50RJSJBTW/aqUm/cwB6MvrLxPf4GuoDccDaqoq8GcHa44Q0UC9eyB9bAZqL72Y8MT1GWZoJ/nBpgmR+y3KtzJzSKQEY0KF6Sfd2CxmkIJ98nVw/dWn/dqSCoby8YmpQZ6E/T2mPizoXNdwTup+ge21tsKf5eQ4CnUvoxUvnqbnGJ+O/768E4LJBAlqt2Moo8WENkOZL2D/6vSMAlAn2/m68lDngvsRWdnVQDlnOPPS6Q/+uz6Aqa02Way5LQivKaI/wdPL7/EJVzwAO7neoshabzNJsoB2bpz9b3y2luf4WsI3cwushKmQTIdmqHCr9Ut34CQXDWgAWnOYWA/lQ455Nd/aNTnmogH9U9zhg+ddGSuBQqjdCSJU9oW/u3yjjlC6SEjvAswZW2vnPQPKk00PxWnD+9wLXFxaXDUodsTwuFkv6hSVJgJamegYGO4yTNi6aBjg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --qr0otETeDhzUuptw Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Sep 19, 2023 at 03:23:28PM +0200, Oleksandr Natalenko wrote: > /cc Bagas as well (see below). >=20 > On =C3=BAter=C3=BD 19. z=C3=A1=C5=99=C3=AD 2023 10:26:42 CEST Oleksandr N= atalenko wrote: > > /cc Matthew Wilcox and Andrew Morton because of folios (please see belo= w). > >=20 > > On sobota 2. z=C3=A1=C5=99=C3=AD 2023 18:14:12 CEST Oleksandr Natalenko= wrote: > > > Hello. > > >=20 > > > Since v6.5 kernel the following HW: > > >=20 > > > * Lenovo T460s laptop with Skylake GT2 [HD Graphics 520] (rev 07) > > > * Lenovo T490s laptop with WhiskeyLake-U GT2 [UHD Graphics 620] (rev = 02) > > >=20 > > > is affected by the following crash once KDE on either X11 or Wayland = is started: > > >=20 > > > i915 0000:00:02.0: enabling device (0006 -> 0007) > > > i915 0000:00:02.0: vgaarb: deactivate vga console > > > i915 0000:00:02.0: vgaarb: changed VGA decodes: olddecodes=3Dio+mem,d= ecodes=3Dio+mem:owns=3Dmem > > > i915 0000:00:02.0: [drm] Finished loading DMC firmware i915/skl_dmc_v= er1_27.bin (v1.27) > > > [drm] Initialized i915 1.6.0 20201103 for 0000:00:02.0 on minor 1 > > > fbcon: i915drmfb (fb0) is primary device > > > i915 0000:00:02.0: [drm] fb0: i915drmfb frame buffer device > > > =E2=80=A6 > > > memfd_create() without MFD_EXEC nor MFD_NOEXEC_SEAL, pid=3D674 'kwin_= wayland' > > > BUG: unable to handle page fault for address: ffffb422c2800000 > > > #PF: supervisor write access in kernel mode > > > #PF: error_code(0x0002) - not-present page > > > PGD 100000067 P4D 100000067 PUD 1001df067 PMD 10d1cf067 PTE 0 > > > Oops: 0002 [#1] PREEMPT SMP PTI > > > CPU: 1 PID: 674 Comm: kwin_wayland Not tainted 6.5.0-pf1 #1 a6c58ff41= a7b8bb16a19f5af9e0e9bce20f9f38d > > > Hardware name: LENOVO 20FAS2BM0F/20FAS2BM0F, BIOS N1CET90W (1.58 ) 11= /15/2022 > > > RIP: 0010:gen8_ggtt_insert_entries+0xc2/0x140 [i915] > > > =E2=80=A6 > > > Call Trace: > > > > > > intel_ggtt_bind_vma+0x3e/0x60 [i915 a83fdc6539431252dba13053979a8b68= 0af86836] > > > i915_vma_bind+0x216/0x4b0 [i915 a83fdc6539431252dba13053979a8b680af8= 6836] > > > i915_vma_pin_ww+0x405/0xa80 [i915 a83fdc6539431252dba13053979a8b680a= f86836] > > > __i915_ggtt_pin+0x5a/0x130 [i915 a83fdc6539431252dba13053979a8b680af= 86836] > > > i915_ggtt_pin+0x78/0x1f0 [i915 a83fdc6539431252dba13053979a8b680af86= 836] > > > __intel_context_do_pin_ww+0x312/0x700 [i915 a83fdc6539431252dba13053= 979a8b680af86836] > > > i915_gem_do_execbuffer+0xfc6/0x2720 [i915 a83fdc6539431252dba1305397= 9a8b680af86836] > > > i915_gem_execbuffer2_ioctl+0x111/0x260 [i915 a83fdc6539431252dba1305= 3979a8b680af86836] > > > drm_ioctl_kernel+0xca/0x170 > > > drm_ioctl+0x30f/0x580 > > > __x64_sys_ioctl+0x94/0xd0 > > > do_syscall_64+0x5d/0x90 > > > entry_SYSCALL_64_after_hwframe+0x6e/0xd8 > > > =E2=80=A6 > > > note: kwin_wayland[674] exited with irqs disabled > > >=20 > > > RIP seems to translate into this: > > >=20 > > > $ scripts/faddr2line drivers/gpu/drm/i915/gt/intel_ggtt.o gen8_ggtt_i= nsert_entries+0xc2 > > > gen8_ggtt_insert_entries+0xc2/0x150: > > > writeq at /home/pf/work/devel/own/pf-kernel/linux/./arch/x86/include/= asm/io.h:99 > > > (inlined by) gen8_set_pte at /home/pf/work/devel/own/pf-kernel/linux/= drivers/gpu/drm/i915/gt/intel_ggtt.c:257 > > > (inlined by) gen8_ggtt_insert_entries at /home/pf/work/devel/own/pf-k= ernel/linux/drivers/gpu/drm/i915/gt/intel_ggtt.c:300 > > >=20 > > > Probably, recent PTE-related changes are relevant: > > >=20 > > > $ git log --oneline --no-merges v6.4..v6.5 -- drivers/gpu/drm/i915/gt= /intel_ggtt.c > > > 3532e75dfadcf drm/i915/uc: perma-pin firmwares > > > 4722e2ebe6f21 drm/i915/gt: Fix second parameter type of pre-gen8 pte_= encode callbacks > > > 9275277d53248 drm/i915: use pat_index instead of cache_level > > > 5e352e32aec23 drm/i915: preparation for using PAT index > > > 341ad0e8e2542 drm/i915/mtl: Add PTE encode function > > >=20 > > > Also note Lenovo T14s laptop with TigerLake-LP GT2 [Iris Xe Graphics]= (rev 01) is not affected by this issue. > > >=20 > > > Full dmesg with DRM debug enabled is available in the bugreport I've = reported earlier [1]. I'm sending this email to make the issue more visible. > > >=20 > > > Please help. > > >=20 > > > Thanks. > > >=20 > > > [1] https://gitlab.freedesktop.org/drm/intel/-/issues/9256 > >=20 > > Matthew, > >=20 > > Andrzej asked me to try to revert commits 0b62af28f249, e0b72c14d8dc an= d 1e0877d58b1e, and reverting those fixed the i915 crash for me. The e0b72c= 14d8dc and 1e0877d58b1e commits look like just prerequisites, so I assume 0= b62af28f249 ("i915: convert shmem_sg_free_table() to use a folio_batch") is= the culprit here. > >=20 > > Could you please check this? > >=20 > > Our conversation with Andrzej is available at drm-intel GitLab [1]. > >=20 > > Thanks. > >=20 > > [1] https://gitlab.freedesktop.org/drm/intel/-/issues/9256 >=20 > Bagas, >=20 > would you mind adding this to the regression tracker please? >=20 Will add shortly, thanks! --=20 An old man doll... just what I always wanted! - Clara --qr0otETeDhzUuptw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCZQmqAgAKCRD2uYlJVVFO ow2JAP0edcVoa2ibxwmEKL50V95Q+tuCyFU5b9EKHD4pXbLNgQD+PIaHonsixovR szsV8iCL4IaV/XCjda0iGXeUtnR3XgM= =rxM3 -----END PGP SIGNATURE----- --qr0otETeDhzUuptw--