From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DFC6CD13D8 for ; Mon, 18 Sep 2023 18:36:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3A9BE6B0426; Mon, 18 Sep 2023 14:36:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 359606B0428; Mon, 18 Sep 2023 14:36:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 26EE46B0429; Mon, 18 Sep 2023 14:36:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 1BD7F6B0426 for ; Mon, 18 Sep 2023 14:36:13 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id DB8CF403C0 for ; Mon, 18 Sep 2023 18:36:12 +0000 (UTC) X-FDA: 81250572984.16.7792594 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf27.hostedemail.com (Postfix) with ESMTP id 3268D4002C for ; Mon, 18 Sep 2023 18:36:10 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=n4a5FdcO; spf=none (imf27.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695062171; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=83UBXje6sUk9WQn75kJ8b+5PbDOix+4jIDRAqbsZBZI=; b=7XKMZg563HRoRChDl6hcCGI7cxc5EzG+Tw58zRc5OZ21r6t80yCQaBBThnBrRnQ0YjEqHj 083PTEm9M893A3Ta3lbrJUHmwPZBnxsGBgKHgArNzq97AD2URYi5DnwYugOn7CiJrlbAkT Q/BkAuZWVa/20S8JDHjnReD65jstL6M= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695062171; a=rsa-sha256; cv=none; b=utDRsfGR4aenfzG3sHloMthrAkigElFva3gX+nBDsQJkuHDA3ygUsAz0z7KCsroQTz4p0H eHffKbrEEPRVkLLSKVPnoHyFXUn9K0vxXIzmVFXpHuusiE2eDBsn8rhOk9WfVC83F7NgGJ OjHEWle6U36Gea6sZa+El4LCxBG3VWE= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=n4a5FdcO; spf=none (imf27.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=83UBXje6sUk9WQn75kJ8b+5PbDOix+4jIDRAqbsZBZI=; b=n4a5FdcOoqT1RgfzLlj/F0VmUC HE5gfUbRZWc7yXpix1tK3ST/7dYyaFvG/1iudJ23+afNDyitWgbo077hJWs39miKja/uUlLW4GbGp TWYGjFv/i86FkNkPXRxpioTGcwWM79JYt19QeXMOUPXvaeNZx4H8YoC8hy2gYsAId5g0slLNiqRD2 V0FiOFIaxS04XCiPKKpDWVnaS1kyUT8OTwyJ/swXA7T9wPxKIbowwrfJ0VS9CgErlMhh3ec6nAkCx +Wm2dnsBeHUAcCqSk+2Of1reWaWQvbFnUrHdbn9C7/1emkK7pk2wuOawPk38lPPW48EQEZ3HnfxIM wjDj/1gw==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qiJ6I-00G5ix-39; Mon, 18 Sep 2023 18:36:03 +0000 Date: Mon, 18 Sep 2023 11:36:02 -0700 From: Luis Chamberlain To: Matthew Wilcox Cc: Pankaj Raghav , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, p.raghav@samsung.com, david@fromorbit.com, da.gomez@samsung.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, djwong@kernel.org, linux-mm@kvack.org, chandan.babu@oracle.com, gost.dev@samsung.com Subject: Re: [RFC 08/23] filemap: align the index to mapping_min_order in filemap_get_folios_tag() Message-ID: References: <20230915183848.1018717-1-kernel@pankajraghav.com> <20230915183848.1018717-9-kernel@pankajraghav.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 3268D4002C X-Rspam-User: X-Stat-Signature: kxiuwb3m47d9qdedhg9ac8i3t1u1d8wd X-Rspamd-Server: rspam03 X-HE-Tag: 1695062170-332753 X-HE-Meta: U2FsdGVkX1+Z06TSrpSrh+rcwoW9CgUdAllrYrpyH11ZWD7JeX+/Wuyg5OHJ6winsmW9UfsDhmoEtueQzS6/z65ajhKxvoxKhKBPSj8zxR5IXjECR/wafOFworY0RfkDMR5MyWRMTd9hG3RArOvAX+UDqVjuz2MYs6CJY5tSRAGLo2uVxK5uUIR6/Vql9juRPZR+fDEHpbToe4walbvwe/0Q5F7z0wUwbNH4tprYCrHtKrJPd+KyLFUltwhMoWeB1aBZHPfMXYbN88m7VebXUUEB+2QAqqh8loizUj5icEVy6a6kGGy+Dl4PB1JFTNBt6bmVwq0FEakQv62SyVcWet9KD5E2S2gSS3IWOoqVCyn/09QJUh+C84SWBQ04pO9X8nOBdbSRY6WVfpabxPby0QNOtIq1gLAVyH9Mt5ZVC5oGaT9Ikr/X0JeXH9pisNe2jz66gIokru2ep2Dkdn/kk0cOwrXBd1g/6rw/OkQqIYD7o7z+ScxXb3DgjW1x3F457W0+7/0+n5qoqSSqGR+j1LpavekaZ/YKFDzms2Ew9UZinROVlf9d3rzCIbSfODfFWpOmQ6poMAVan/8QXMfE+Xmp4Br889vIo+papU2kJw5T4RWqt2FqXghlT5M/4PeP7eOybNVowE3AWcyW+Dq0DkqXzDzn/LY594jyxOlZcQ3dpTLuezTG7snvjLdKct/tv08cnef5xH0EtAkqp51MjLCso7rT/jgaSoVQi1JoknUNhMDXmXZLxKZYu0glTGkkoRPQ4O3aITgHvvQZ1NSiG/mwP6UWswqPV8uWcQRy2uNdDuH34D92eBPNiWnNjNpHo+fKpOzPI3HISGRX1Lm3vnu9AOHPokhUpjknnnfHaz2Zk0t8OFuBn/CMt8qO4FoGZEt54loLUrfnRMLf+v+GGGRgjpRGNzdaseQkeCZ2sTNxBVwtKgPd+fMYV2WZSP7DBiC/8eDn+TdB1jjSfvq vVRbT83z GM4tfjlzpq4yMxT4yZ5EwPcxw7tMZRyPs3+QwCjCSU/1aTRPe4OLdUxRx0Jm/ivtbUaFa7WtM9pV3IkIpvz53xkRzPzYjai30K29xbXo/87yEpkfD9tzzKT54wuz5YxM3TDRwfAbIQTdqG75uUTjUENVkcov3cNHD1mRZhI9VLtJVvbEoN38m5Ie4DHXblc6yCW5ignzcPImPrBeoDMOS7fzcUGouoAzNJEKtbJRLAj8Pz+SbdR1cEdf2AFejIo6f3cdzeEUU00jmcOUtqUB2+5Z5hLIiTzxtahkjEbnwBPEk3cfP89xIoB1coYHt1Bz9vRIUPfn67129X+Ks6HMmFDoNUibdw3UYsjN6dXds2q2LUJnTeQ05ZZI07oeC4TeO65zDtD5pY0oTloTmMFUfKNbWGze89Kcx9+2+6sTJOFZm/n/kUgtge5rmnSEFhQvHx28Q X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 15, 2023 at 08:50:59PM +0100, Matthew Wilcox wrote: > On Fri, Sep 15, 2023 at 08:38:33PM +0200, Pankaj Raghav wrote: > > From: Luis Chamberlain > > > > Align the index to the mapping_min_order number of pages while setting > > the XA_STATE in filemap_get_folios_tag(). > > ... because? It should already search backwards in the page cache, > otherwise calling sync_file_range() would skip the start if it landed > in a tail page of a folio. Thanks! Will drop and verify! Luis