From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E173EC46CA1 for ; Mon, 18 Sep 2023 18:32:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6DBFC6B0424; Mon, 18 Sep 2023 14:32:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 68ABD6B0426; Mon, 18 Sep 2023 14:32:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 552FA6B0427; Mon, 18 Sep 2023 14:32:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 4569A6B0424 for ; Mon, 18 Sep 2023 14:32:13 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E0BC1C0B52 for ; Mon, 18 Sep 2023 18:32:11 +0000 (UTC) X-FDA: 81250562862.21.E1AB049 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf24.hostedemail.com (Postfix) with ESMTP id 23B59180015 for ; Mon, 18 Sep 2023 18:32:09 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=RDkff3uh; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=none (imf24.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695061930; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WkxIxcrv5KR63l2iFq63ZYJDZ9UFo77/A7z8e401fPg=; b=rXpYSjaVgvekR9E0cNputjkrqcGGb1w1RUq4sQ4y9Mp72AlD3hH+1HGim/aNMOmXtmeN58 Tv7sE3TqBUqP/bLK0mv+8fnHfZ7FMyHWX+gL4ThhSTj2Fd2ys9QXfK1nAKmPjgh6bAK/xx +ZtEPXsQBm4cEZVdw9AwzoS6YwzRvFg= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=RDkff3uh; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=none (imf24.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695061930; a=rsa-sha256; cv=none; b=BlLo11zPDlJlRe1zz9hkk8ne8nmBoUWVncpL1rTpdXGF54s5HVG2Khn3Lif8qHxtDgfiut Wz2G7psYjaaFOqk4Tj+iESKRz3s/Fdil+szrmzmwpCN8rw8T90ycGGjqo3FLvPb4lQr46g tRtCCzTZXFYr0ehC1IQXUeJ6i6XSdV4= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=WkxIxcrv5KR63l2iFq63ZYJDZ9UFo77/A7z8e401fPg=; b=RDkff3uhKkYNHYOWdvjzK4sARi /3V34pnCl1JdyIgQ7ddhD+CJhlxQ1K/9gCOsGmU9ziFE35fstfG38xFMRSJEeNOSPdWC4QRnKPMvT 9lVnRsz0KxvBOfAkX+hEoOR22D+1OSeDVeQEQyGTrKaZv7dLcSDR6PJOl+EX6Z2ZpMW5KD3k3WfC3 yS15ppfiu96aSzbhWBpx+XDjIsgudZmVEEUAxvnjrjf+AkY8srNx0LX/8hO+s10sKs8XI3FvPVU/D qbFN0uQcBZnjbkdGWSpaR4TCnVX6OgsFb6lx7bP2dZ6vqaKqHarqhJrfzPyWLdKvCiFRS6zFyrzz4 m71zt2wQ==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qiJ2R-00G5VN-2g; Mon, 18 Sep 2023 18:32:03 +0000 Date: Mon, 18 Sep 2023 11:32:03 -0700 From: Luis Chamberlain To: Matthew Wilcox Cc: Pankaj Raghav , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, p.raghav@samsung.com, david@fromorbit.com, da.gomez@samsung.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, djwong@kernel.org, linux-mm@kvack.org, chandan.babu@oracle.com, gost.dev@samsung.com Subject: Re: [RFC 07/23] filemap: align the index to mapping_min_order in __filemap_add_folio() Message-ID: References: <20230915183848.1018717-1-kernel@pankajraghav.com> <20230915183848.1018717-8-kernel@pankajraghav.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 23B59180015 X-Stat-Signature: 14sjnf1znaapd7rfnqjz98s793a1pr6s X-Rspam-User: X-HE-Tag: 1695061929-528650 X-HE-Meta: U2FsdGVkX19+ZFQ+XeGeLwhIrjmOTzDfswN36PDVq1I90PKTmAozc+cJH4Xr7l8lHsckCvuU324/yyjo1/gHcQePwdJPm0T65WzhUX7KFpal/K3L9DePyd3Fvkf8YqK+MEoYlzBQc8rvR1y2KmuLElEFVIVMaBMXOJiJ2t0k2vYUL4NbwNFeohp1EiqhQ8M+3MWaPHHWSGLOQWxMTK4zu7d8V8Q/MVuUMHfMg+gqTaosOUYOWCbcf8YLnvMKCslvW1kpPF+gTPhNF/CCNpIrqeFgC3m3IXx8T39yUnGfYaIQybMYaF7ecV6Kp2b0Mym09qVr1Dw92z1zR+3kwZ0KJNeIYAYCX5Bh9qePRy9PU+FGFeC01yEunBWJcWENdP4w3vMQmdTKXoitf0ldlx+sI3nW9ZCYgQHW24pMi3S8LQKu1kjGTIldZBmJLPaTxCrhgw+SNBJp8ZdseMztYUOfQL8oNF9MKtqAy2gxS67sm3QB4qz34dMeuLhtq+974ViHMnXfcXn9aCo68YF3SkgvYMSK3q7Jf+eMdq03K38AhhOaZJjqsTvfexS6N4D8mkn6T0x6O3ywHdDvK3SPiXcFkovaWlitub7tB8DqsNVvZTWWXYYEokdTJKrb4cdSQNSnmsu1+LHoMtTaOZMaLmjtvIeOwacDQydP8ujj/Gxn4AvKEcgocUCpdQq7/mChGTn2NLGIt4Yf+NuZ8/2M3f4zv7t6s0yjRG+MbADBHIUcEmWyrERpQ7zdrxxAb+Gm33kDS2Si/TbxXD/uqCyb++KaF4O6kf1Idj+7+i45kM1Y0l3KaBdfbz7LmMP+a0BfMlcf7KuV+kwEShyGgpEvxayfFgjFBcqUD2xa6B/AyJ4nZ5yzLsrJcUnTJejrhK84N2/pM0/F7/LfsIxB8Ia2gCmNJcahcITKDmJ4gjW3gQNBHW6PfE+SSiwAKdb7w0WhKotn7AiJbM6RGIld+i7fOJX ZNwXwy+Y n9Y3D/STAIMABN+PprOmu8XRgsAADlb1hpb01a8OmSZbDoy/elsC/o2ToWaMjxMzDLfvEbfn8bmtsN9WlLL0PL4seEBYAxIvv2BqoVmpSQs/fUiYLhArJ95Q9ak/z51E+8Q5zGqDpC6EMc6xQm1LWpcW38PBxLLzUvjSZjbm0cgjSQKgKr3UmWblYurby75guYTS+tsMwBb2g47iMwOY1xHq2MJjMHXoZ31r2zyq993G66fFaebKL0C2qt05iDF43PwkBpv1AgmxKsFjY8/E/hscuj19J1CZjqSfUaCLUg/2cFYxd7rzCQ+tb6QovU6ia110QA8P3yXZb90pY8NIjd9vnYJOovfNg9OL897RTN4WVZ2itm8l0vkNwF/TuBxmDFaZJ936RNB3k96F/kh6cqpDhY+B+dTjqnvPFR7QfQQ7nIsp9seTtBFfCuVyF+CmqC/YG X-Bogosity: Ham, tests=bogofilter, spamicity=0.000067, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 15, 2023 at 08:48:43PM +0100, Matthew Wilcox wrote: > On Fri, Sep 15, 2023 at 08:38:32PM +0200, Pankaj Raghav wrote: > > From: Luis Chamberlain > > > > Align the index to the mapping_min_order number of pages while setting > > the XA_STATE and xas_set_order(). > > Not sure why this one's necessary either. The index should already be > aligned to folio_order. Oh, it was not obvious, would a VM_BUG_ON_FOLIO() be OK then? > Some bits of it are clearly needed, like checking that folio_order() >= > min_order. Thanks, Luis