From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6C2FC46CA1 for ; Mon, 18 Sep 2023 18:25:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6FFBF6B041E; Mon, 18 Sep 2023 14:25:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6878A6B0421; Mon, 18 Sep 2023 14:25:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 526C66B0422; Mon, 18 Sep 2023 14:25:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 402DC6B041E for ; Mon, 18 Sep 2023 14:25:51 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 14C4D1A0956 for ; Mon, 18 Sep 2023 18:25:51 +0000 (UTC) X-FDA: 81250546902.15.53DB175 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf30.hostedemail.com (Postfix) with ESMTP id 5B1A280027 for ; Mon, 18 Sep 2023 18:25:49 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=BRoxodG+; spf=none (imf30.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695061549; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sVG7Tz4mbiL7zFD9pXkZDz/RHS04WKOIQw8iJglOgVs=; b=1prNl6iCpp++UWChSU63n2YG+KYqlhy8Vo5hROPqS662LklQdi7TClCG2PVyVkFL+dfJNI jX7X/+xc1e4gG8micNMKWAhicNzx2ocz/YtgBb8dt1wvbPLLtychBigE0Nrj9BpWTL7zkI Pr7EXVWqj8zLMd2Ps2412XmvrM0fglU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695061549; a=rsa-sha256; cv=none; b=YZFH3XUafmuwnF3IggQpusgGLvKoUBKLSlT5/avzG8rP+bqmnvsbF2YEieiHb72ciknN2k vOyZaUfPMR++F6RQ/OY03MtwA3N+UeytU8elTXz+25ulBiYYbTdBZLXsxYx5fwyMhAIev/ 3BaQaLC+ep89D45sGQwvloScZaDU/ZA= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=BRoxodG+; spf=none (imf30.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=sVG7Tz4mbiL7zFD9pXkZDz/RHS04WKOIQw8iJglOgVs=; b=BRoxodG+HQtU46yX99ln++ZjUI jDo2UFL72u1TGVgslvDMwhexkR9M4DBavYb8bCC3D8/fVCvGz/BdbTdj7miPIWikmQTRRBAag3r9H 36LJxM8kvf9dk4YJ1q4vUlaQuz9OUn5BMa5gBVvXxMdt4Dg2dztGqSW8oBwRapHs5ES20kWpghRzK +U9LwiBlR8qYH36T3tQlmYQyThvUwdWs7LPjKVyou0rivoVU4dhe2lgTxGbUlKzzcCRV0+GiSNXvW vj7aG/B5Ti41ZqjIHbQlFJfW+HKQVLKEHT57VPok+JZhZAwdcHHA9+4Y3JLWLd8eX5Vwo4HDW9E6r iYU4wkHg==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qiIwH-00G4zG-2i; Mon, 18 Sep 2023 18:25:41 +0000 Date: Mon, 18 Sep 2023 11:25:41 -0700 From: Luis Chamberlain To: Matthew Wilcox Cc: Pankaj Raghav , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, p.raghav@samsung.com, david@fromorbit.com, da.gomez@samsung.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, djwong@kernel.org, linux-mm@kvack.org, chandan.babu@oracle.com, gost.dev@samsung.com Subject: Re: [RFC 05/23] filemap: align index to mapping_min_order in filemap_range_has_page() Message-ID: References: <20230915183848.1018717-1-kernel@pankajraghav.com> <20230915183848.1018717-6-kernel@pankajraghav.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: j7oadjuxksy6eecoh4xsx8hgeg5znjk8 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 5B1A280027 X-Rspam-User: X-HE-Tag: 1695061549-52265 X-HE-Meta: U2FsdGVkX1+SnvjtxOFvU3g2WbyQXiJfJNv0j0+CgMtV+sqhIqqhQ+kUE9GQaraEtrIQILex4hd8IC3eq9K2/DvQ0yS6GgjMztm0YLuhIRzKFRN1phd4SGnsTomYCl2I2qCaxfqVJfM8dAmGfU3gJPiNJjhMhlwdM0JWtRpW6TcR49Xj3ZxM5A2ZV2BgrBXuZTyJG0q0qCtY8fO+2b/wRVJS4XE1I8ju+SE5fsnEuB5mR3FY826L/xwFCOHDzCcZHNhnIeHFdDXk3MH3QWaEF6ZLrjgGB0/v0hTApX5do+Ibl9++la0ptx+qjNZ+cPlDf3UMKgPYa2k1R4C9kqUYqrgQt9RI701V5tMpJUC1bGZsoM5YlGJTLdPa5TnqGWWTzIdfKW63ITT0RdkBOSZTQBCGFiq0Yscg1C+23ihT+uZvoEy0DruRzmtchKbBjVNbNdWrbqJ/Bp7ouHkeNSMR2n7a4lOuSq9cPRTqdRCx2uZ9Le595vU1rz742HCM5KCNpOg078ESx89FGMBqNMpKEsLDwFjWx2ENxjadRDpAZ5rzVp2mX5eiJ4tZ9mjnJrmfqw5pEJQIm1qWOlTurVlcL56TR+Jo6imgNGnJLSUH+1VBNeHb7pSBB8CDJe0kXuojzfd3J5SkWlsWFTcU/ALVDWckeACl/p4GT/1/AjBZdu+PFGxmKebwKXd0T5DQw950xaxM1Dyzh6CwUjpnV8IIiRiepKedvZEdmVqO9xirFM5MdvceiKo7qJYopqBGhMxwOY8y3Y79Y9dQgboXVWu/gFBZGs/9PePJMMYPDlrfzW+sOMRdv8jzEqklX/fRqNK1GTIVvqb99I+VU7m+FRw33JDQlP1alI+Ckt0JzClkTfnhs986+sadMyOLyzCvHDdutsYiQA8oUnmEsKcW8RVBJEZgDBgHF1fMIiNFmtpzTEtXHQBvJ3vXC1/Rfn6wlP2T6eKQVHDEwnFIUDpKi7g mkdJUl1Y zZLGPNu5ai/aNGQHIxaJnV2bceHOaIfcAc7nKXqxnpbKNGSoUP79A0q1wnLLH/ZV6m21K4WlxwWlYrDLiFcPfsEMeZkDKaI6lTtrrUeCndnpcwhEJuwgjJNjWqQnKmsXCSGSOJtxX8Roog9nWe8KVJ8zzHcTdQLNdoZ3fJ9k1ZtCkzxseR/SkRgzWBJSoA1vx7Ao2OrWAexHw33QIYO7q0SD6aCC59LUmA+YpXqpKg3BMLeg0YnQJ3/D8IqeAppl2FAnob36cvweSat2WzhFB6sS0QsnnuXT5y7kiLKLOZxn2FY0A12zqo4NtkHbr4U+v5LLyFqlvoaRwvfz8zb5IoWqeMalgZC1Yh03y5HHkn1o91y9uWkx0z3+gCaPydY9sNQEQsYzD/XU3ZpI/cV5hkCiPC9yk4U3VIDgFArP2aFqzOtgui/d619OXGyhuYyyBoIMh X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 15, 2023 at 08:45:20PM +0100, Matthew Wilcox wrote: > On Fri, Sep 15, 2023 at 08:38:30PM +0200, Pankaj Raghav wrote: > > From: Luis Chamberlain > > > > page cache is mapping min_folio_order aligned. Use mapping min_folio_order > > to align the start_byte and end_byte in filemap_range_has_page(). > > What goes wrong if you don't? Seems to me like it should work. Will drop from the series after confirming, thanks. Luis