From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4644CD37B0 for ; Mon, 18 Sep 2023 18:18:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7E2D56B0418; Mon, 18 Sep 2023 14:18:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7929B6B0419; Mon, 18 Sep 2023 14:18:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 681F26B041B; Mon, 18 Sep 2023 14:18:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 5841D6B0418 for ; Mon, 18 Sep 2023 14:18:41 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E8260C0B79 for ; Mon, 18 Sep 2023 18:18:40 +0000 (UTC) X-FDA: 81250528800.11.D7EDE39 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf14.hostedemail.com (Postfix) with ESMTP id 9313D100011 for ; Mon, 18 Sep 2023 18:18:38 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=KzAz5wBn; spf=none (imf14.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695061119; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GZ84gVRI2PX7ahj9yRYTfsVG+X1DsmYAjFhvQECzP0A=; b=BgxG2rDWpww8ocVsfk1JKd2NsUxkwO5Lhv0Km9Z6WX3C9hX1lurzrIC12nvgL+kj5K6zgp +oy1mKyM3leUnWPSx4oD8p8TjBU/zsn7pMKrUvcFkw6+lc3oQ2+9T2BuFKyFjJfY2JPelR FjP2qh+ReRn8/TY3Qznf7s3I2uaQNwA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695061119; a=rsa-sha256; cv=none; b=lp78rVVxldxwqT2xwmJN1KJs93OgeddTJHAn7z9lZYPjFvkHxi2ZtBj9M+krPkDQIOTKC0 PN/lIMdhAhnNwqe6Yod0NY65ipBZUiFgSO63gSk4Enkib4zjX65ACx0eT2cgAmdxZQSJde cZ9JGe2NZs6s2F6QmGLeondhWXdarfA= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=KzAz5wBn; spf=none (imf14.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=GZ84gVRI2PX7ahj9yRYTfsVG+X1DsmYAjFhvQECzP0A=; b=KzAz5wBnPEz1nehYFezXzF/d1+ +P0ffc/qIqaeWx2fcXjR+cpFD4Bb1JITYhUyextiLiqXelX1Hh4loVLZEHp4Kg9D9YKKnKylB0qV2 flgNGh28V0hsH5A+UrRB82A14tLQo9JNMsu0MJG4OvdP8Z28VdGx3rtDgJrVSRNhe/8S1NuAaFhIU q4cWVMhgBFJ0/1wQ9GMRJ/x3RY1DJgkcCm5VZXeHArk8nb3an/6ifgN0uASUf4YTF3iuPSpS38sDh zMAp4oNMD3t0PNGUi4fKv4y4mL7bDxlMIxRp2gfloQpmGR7CZ1Ccsk8sZUbr56O8WZqcXQ95Yu/bH vh7pjFOA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qiIpL-00CUQS-7X; Mon, 18 Sep 2023 18:18:31 +0000 Date: Mon, 18 Sep 2023 19:18:31 +0100 From: Matthew Wilcox To: Sidhartha Kumar Cc: syzbot , akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, llvm@lists.linux.dev, mike.kravetz@oracle.com, muchun.song@linux.dev, nathan@kernel.org, ndesaulniers@google.com, syzkaller-bugs@googlegroups.com, trix@redhat.com Subject: Re: [syzbot] [fs?] [mm?] WARNING in page_copy_sane Message-ID: References: <0000000000003a7ffb06059ac0dd@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 9313D100011 X-Rspam-User: X-Stat-Signature: 89na8jp3cib1uggs3o4ps1hjk13f78wd X-Rspamd-Server: rspam03 X-HE-Tag: 1695061118-383183 X-HE-Meta: U2FsdGVkX1+jKSJ6DNZyV2SX3iTEv0P+RvUTobxRI/hrFMhoHXQg49e9cN/8tH3qSi3nFUz4YBRTx4fNqlV/4/fzPS+MMoUF8T5wZigXKeH34Cr0Lqs8Ghej5Za7ZqtKMInMGgU/4HTqvociQxDSdhi0oSyG+GdSYg4mfl46ArMBli7i9QOhLx1371vFsSmyrC2lAlUwjvPb6HdbGqxUT9UYZAg6fmt2Iozcv3pidsWP+rRMT3L514C//xmip69QWBQy2CESGub98k96Pig9yooP+PF3ClPC5lx/WgI71sMDynHb2RCdbA0Hvjt/nasyyip/oz6xvIwB9y8JtgyBILsbmHNsm+zTzwjq4wJMQyUjKS0yOCHJjcsdVNmkjQucdAEiXe4ODZ+H/gFM9301HqQpIotAZX6/oYHmWQ7yWS4b/8nC/+rpvG1L08NJQU0DiDXaOD5sQcoqN8ZQYma1xyz26s7CqUGXpC1pTgqmJdNC4KN9c9F/XS6ahuM76NKoilLgDxoBj9meC8SiVRXJuvtwmyMUeGTUDv7xb+AoMxPYvakjBbh0AaBsHxp5/EBpqHd2xTLZDpd4TESHV4Oec04S+YPzR8hJZ633CDzqapR0Y7vPwBVwoEWcbY4yawkYZGO3lzP3uh19Tq7GKY1urgxp1wDO3u5s3yxKwdnOHl9Y52JTcDT0grbyGxQGEP9HLf6Zxi5hvugZwIht2a3ZhKGkmMrMmtiBZ5U5XS1jrmu4icxwRVF3oOdjwJSPcKRLzP0lj9Liibfj90U8x6Q+4MQHGkzFNr6JDPH4ETIaANpaXV+XU/y5bJ5bLaIn9Un9ZzJMao8feQpYV8kMvhcCJd1Ql5EJlEVqJGkr9s4qlgUOeYBykWpV8K79JEFhTDLy0R0VJFH/ywxy2VZ+x2N8oS2Rw4CEiXhgmoMAWlFNO3BAkZbMUl5UCfKtfj05rtEdtxGwOxEEO/ws7ucWmAy Zy4gWf7w oWWpBLAAm3utXRyS936dCxng/HcNB7Z1/XJAr0eJWWsv5G21GtSuZVmjPR9EqjWKAG/9nK/wfOOarfM0uyc4+Xn2j5yzScqnC+SQShUFc4i2SpPolMJoB31XNCu0/I9Cucf1AqKSWl4rUM0j63sS3DMJwqV1L1FrRSMxPmr0XSEmETILE6D960fU1YiP+Z/IZspkG9yws7L6sFigqppOEhwWIUKizgDq1IRv9jpFQopJkFzvj8H4imjSDAxeZdI0h3Br+P7JQGS+WW0IvvT0EVCvyM0RzOc8vOLbiqI+qSZlNzyoo331nbrKb7agIe8eMih4EPWWrv1Urh6Q= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Sep 18, 2023 at 01:10:21PM -0500, Sidhartha Kumar wrote: > @@ -382,8 +382,8 @@ static ssize_t hugetlbfs_read_iter(struct kiocb *iocb, struct iov_iter *to) > /* > * We have the page, copy it to user space buffer. > */ > - copied = copy_page_to_iter(page, offset, want, to); > - put_page(page); > + copied = copy_page_to_iter(&folio->page, offset, want, to); copy_folio_to_iter() please. Yes, I know it's just a wrapper today. > + folio_put(folio); > } > offset += copied; > retval += copied; > -- > 2.41.0 >