From: Sean Christopherson <seanjc@google.com>
To: Jann Horn <jannh@google.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
David Woodhouse <dwmw@amazon.co.uk>,
kernel list <linux-kernel@vger.kernel.org>,
KVM list <kvm@vger.kernel.org>, Linux-MM <linux-mm@kvack.org>,
Michal Hocko <mhocko@suse.com>
Subject: Re: KVM nonblocking MMU notifier with KVM_GUEST_USES_PFN looks racy [but is currently unused]
Date: Mon, 18 Sep 2023 11:07:44 -0700 [thread overview]
Message-ID: <ZQiR8IpqOZrOpzHC@google.com> (raw)
In-Reply-To: <CAG48ez0YBOUGnj+N_MBp2WCvp0BLk1o7n6uSH2nrj1z-qgf+0A@mail.gmail.com>
On Mon, Sep 18, 2023, Jann Horn wrote:
> Hi!
>
> I haven't tested this and might be missing something, but I think that
> the MMU notifier for KVM_GUEST_USES_PFN pfncache is currently a bit
> broken. Except that nothing seems to actually use KVM_GUEST_USES_PFN,
> so currently it's not actually a problem?
Yeah, the implementation is busted, and IMO the entire concept is a dead-end[1].
David Steven's series[2] doesn't actually rip out KVM_GUEST_USES_PFN, I'll add
that to the todo list. There are no users, and I don't expect any to come along,
precisely because it's busted :-)
[1] https://lore.kernel.org/all/ZBEEQtmtNPaEqU1i@google.com
[2] https://lkml.kernel.org/r/20230911021637.1941096-1-stevensd%40google.com
prev parent reply other threads:[~2023-09-18 18:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-18 17:12 Jann Horn
2023-09-18 18:07 ` Sean Christopherson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQiR8IpqOZrOpzHC@google.com \
--to=seanjc@google.com \
--cc=dwmw@amazon.co.uk \
--cc=jannh@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox