From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93845CD13D8 for ; Mon, 18 Sep 2023 17:39:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CCA8B6B03F5; Mon, 18 Sep 2023 13:39:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C7A656B03F7; Mon, 18 Sep 2023 13:39:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B42266B03F8; Mon, 18 Sep 2023 13:39:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A4E9D6B03F5 for ; Mon, 18 Sep 2023 13:39:52 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id E198980B5A for ; Mon, 18 Sep 2023 17:39:50 +0000 (UTC) X-FDA: 81250430940.14.CAD287C Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) by imf18.hostedemail.com (Postfix) with ESMTP id 114881C001A for ; Mon, 18 Sep 2023 17:39:48 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=QyaKQiC+; spf=pass (imf18.hostedemail.com: domain of mingo.kernel.org@gmail.com designates 209.85.128.44 as permitted sender) smtp.mailfrom=mingo.kernel.org@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695058789; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Y1/lgZVflqyyt3jw5+T2bDLyWXYZmvdRzCSXLWVSuYA=; b=1jC9TPjjI6bKsNOzKj8RHxTiS2SJ0UipXPv48j+Sa6Vi04jYeCoIcJWkeSCljT12h7ieoo 2Cqf6LpTqUaqYY4hrEtWpd+OGQVr5PdLQggqcVOwSKNrxK9rYtnHG2V0GSLUuOHSAScUTQ fTg5U+1Tmbt7dRHHOSy2LDgLLB9Uy2I= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=QyaKQiC+; spf=pass (imf18.hostedemail.com: domain of mingo.kernel.org@gmail.com designates 209.85.128.44 as permitted sender) smtp.mailfrom=mingo.kernel.org@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695058789; a=rsa-sha256; cv=none; b=6Xp8wuzEt+hxtZbnq16uAWsbvG9EzPaowWWQwsAf3qC02XDgmk6qJuP+y9KCkTsKpbZIxL dpQRyJK7exh8PboT0nec0chQXcf9i7dkzcZYkwrWRVEZchKsK1oZi1TVWIwg65FxKpws7g nvB/Nkmj7BuYxJzF7m+HHZ+VvWAZ++w= Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-403012f276dso51794985e9.0 for ; Mon, 18 Sep 2023 10:39:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695058787; x=1695663587; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=Y1/lgZVflqyyt3jw5+T2bDLyWXYZmvdRzCSXLWVSuYA=; b=QyaKQiC+zFNgQul+UQo9QvwOyAFEkG+Ic2sMNukEdFj0q0bUjAvuH8WaRIK/cwpTD4 H2jv0orMsiDdTTuRo6+KIokW7E9gS/z5eywWu7s8AZOBuGNlUysnQDb6DTpE+tOooNXD IdZsL8+UrVu0zNr93ErL/g7qM3c5mfc+xwAasP2eYj9vBUAO9thSjEK68jIXzyPFRVU2 YNYcSNBWCX+oTY1lyQyvYNEVJkCVKFz2I5AbTHlqoIR+GmBwbeAG7Tamx4LGFGHDOZrC wyRmCQcgeRCS7OrCqXNM9iAfnK2fEHMyqYBLGovoKkjJ2eM6RcWVSSWANIdBoxPpO6L3 EEeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695058787; x=1695663587; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Y1/lgZVflqyyt3jw5+T2bDLyWXYZmvdRzCSXLWVSuYA=; b=fDE4airaYlBmlIvcZyU8MuuC6SJE4QdEk+Jy1NXdzpSui+tOlAhca0gploODSjFRzS HSVzfuhjHALdnkyYyhaJRDarZTG8nCVn3jDh6znM9Bu8g9bzSOAWh4qkD+FB/TLgSKkR sxos2l1ChKbrgfukyXuw10TGo8+SEIMoQeTnB3eYHHmwff6cfNfn5F42P3wzz8E3hOLm +7DDli1Yvo6WXkgWADd9Se5QmvntSjl4GEd2/6QitXQneFCuaRnJabmsjneiYcs0h0uM ZMHauWYiVkAWTthY/2rsE3XS23Xc+CiRFsTevcufAXIjQs0Ati7Y9srMfvet/GLI/Tjf r3kQ== X-Gm-Message-State: AOJu0YycYluMTpTkf4QB89JCyeopZ0C4b3xrHcgTy0Jkp7S6Mtc3eEJu U4Eai6mvCIE+26RpDiOhW8s= X-Google-Smtp-Source: AGHT+IFrFTFR1xyoFqyL58si/yxpKchP5xcdqD8vMS6vIA5LBpyvQftnW10N0ehIERFDMNXGwC/i3w== X-Received: by 2002:a05:600c:2209:b0:404:746e:c601 with SMTP id z9-20020a05600c220900b00404746ec601mr8928944wml.9.1695058787287; Mon, 18 Sep 2023 10:39:47 -0700 (PDT) Received: from gmail.com (1F2EF265.nat.pool.telekom.hu. [31.46.242.101]) by smtp.gmail.com with ESMTPSA id m6-20020a7bca46000000b003fefb94ccc9sm12968401wml.11.2023.09.18.10.39.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Sep 2023 10:39:46 -0700 (PDT) Date: Mon, 18 Sep 2023 19:39:43 +0200 From: Ingo Molnar To: Matteo Rizzo Cc: "Lameter, Christopher" , Dave Hansen , penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, vbabka@suse.cz, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, keescook@chromium.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-hardening@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, corbet@lwn.net, luto@kernel.org, peterz@infradead.org, jannh@google.com, evn@google.com, poprdi@google.com, jordyzomer@google.com, Linus Torvalds Subject: Re: [RFC PATCH 00/14] Prevent cross-cache attacks in the SLUB allocator Message-ID: References: <20230915105933.495735-1-matteorizzo@google.com> <7a4f5128-28fd-3c5f-34c2-1c34f4448174@intel.com> <1d7573c0-ebbc-6ed2-f152-1045eb0542f9@os.amperecomputing.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 114881C001A X-Rspam-User: X-Stat-Signature: e473t78r16ep46rd7p8dzgdtq3gzjem1 X-Rspamd-Server: rspam01 X-HE-Tag: 1695058788-743812 X-HE-Meta: U2FsdGVkX1+9LSL9+LKQZWDvyGx+9fMNdGz7vUg31KtZ241/Uj6fPrcA2yWCOpjc3uo/iPIo62DvOwDSzjrBV7/XtKMhWxPQcIvFLuhdHagUADmjvVHCrMYV11NlqSw0Eb/jbdmvzulEZHMrX1pF+pdwcbozzxh48Dd3lb27qtB2duW67In3dQi2g9+EdQsllxbj1LWFgvrG66Cegn9mYEc6PtgIqJACH2Kbhb1BvI/17p7ekgusBeWtCTCKvNXU8JpsZ34cBab52qOg+jp+oTCD/BiRfiH80hAUTtKyJjHFEQzukShhPO4arHlgw+hQgJoqb4PVf7Hs4fBcUQ5bHB2hfym+dN0BzavfSlEZVABHVXHk8GEtYIo6zRz94HKYLGqIoWA/9ywLXgskmLJ8u/eCQYSmK/NRcJVFQWrxdd8ImZ9UmNgWcHY7jrTfAgDVfSlI+vvDVA5N8Y3PHJqmDXG52bzXdDzO79isuUnssMOA/ZZqLUk29B8DjZ0b8pMvtWGEgrm2wCLiNF5kg9swyB2kN8PmKpI02nusrrpMh/+VVUS20DIpWX8V9qo1z439marVLiDN0G0bmiGpogqysOpIzVIoOwQsZrVqsx2ykn86RpiXRZozu6OhwMR1jcQMmkLPfB5uuIRQOetIuCzVPF0F3jnRz1zGTL1GlCrkvJXRZTNO+aaDdtPKGNJV/E+1lzhJr93Zag6CJLOUIGOQZJHvSudzjbz/6IZDSJFJBCfvfNLhMT8YTAQKmtTu29hFSUyNiK94NkRjMFdD3pIFHmfTomQQp5zKkOAgTuIP0Np/G8WPV9gVLTY13rRSleVvveiGcdtMpnmxkk2t7apU1aH/iulIKEKbN0H3GVWJ4B4VxRC0emSLfueobIzLtcU52lUhJ9GArD2jaQ4r75VTJHs9kd5d3q+PLGxiQlPnPJth7VElnbvojNBXXOulb1yKC680UOIOuc97aae/qBB aF/EY0mV icyOo9t9thqWyjcvrw69JssHSEQZgQxF2QpUbUoPGNvXs8disffAOtRITtV9u/259XIMcaynBez3bz1M1f2wCP61+SsR4mHsPT4pZtVYK8mQuFYYZDDRMbx0km03aGSNoJoOAlqxMi0e048NRAkeQGljN1FkTvldFigd7ylyA5CtNk6AazFritxNk/Q38V/oIUWkeUu0/nAeB0ZSbIT2P2RvWYBG2oNu6uo15tN2kVW2DsZW3xk3rdc9ydwuU/X91bH276YZoPM7kmjZrdpLvz15eI5nfbk2WjdTGgUfKPD7R1nxw/IfkbonT5jZdiXAy3+pOTOzyp0SLDgtY+pB0jkLelX5gtUF+AIe0JvVKCagFW/CicYLtKlZ/SPPj+F0vhLFk3wAJujjpZ5onzfJ4VvWqmrG9GhCKC/e+euiaNwb3CHXbNRaMS/ZTq2iSbsyO7YQgqufSBMAeoZDXMI6Qij4yz0rU+tiy984vhElz8IIecCP2wRuta+P7P15BtPYF4IYteeFUFuC4HOxqk2rEnDtLWEJGkDuEtILmxr7XdOAB2JVPf/3EA0tHrMrrMtENo4qSAsZjY3mHMVHzLr2kF/lRkc3/TWlX8SiQwPnevaBaD9WaW1awOw1iuN+0UG7oXjLUnnSA3jTzLmONUvpnFTImbcUI49KEOjH65I9Qw54O5rw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: * Matteo Rizzo wrote: > On Fri, 15 Sept 2023 at 18:30, Lameter, Christopher > wrote: > > > > On Fri, 15 Sep 2023, Dave Hansen wrote: > > > > > What's the cost? > > > > The only thing that I see is 1-2% on kernel compilations (and "more on > > machines with lots of cores")? > > I used kernel compilation time (wall clock time) as a benchmark while > preparing the series. Lower is better. > > Intel Skylake, 112 cores: > > LABEL | COUNT | MIN | MAX | MEAN | MEDIAN | STDDEV > ---------------+-------+---------+---------+---------+---------+-------- > SLAB_VIRTUAL=n | 150 | 49.700s | 51.320s | 50.449s | 50.430s | 0.29959 > SLAB_VIRTUAL=y | 150 | 50.020s | 51.660s | 50.880s | 50.880s | 0.30495 > | | +0.64% | +0.66% | +0.85% | +0.89% | +1.79% > > AMD Milan, 256 cores: > > LABEL | COUNT | MIN | MAX | MEAN | MEDIAN | STDDEV > ---------------+-------+---------+---------+---------+---------+-------- > SLAB_VIRTUAL=n | 150 | 25.480s | 26.550s | 26.065s | 26.055s | 0.23495 > SLAB_VIRTUAL=y | 150 | 25.820s | 27.080s | 26.531s | 26.540s | 0.25974 > | | +1.33% | +2.00% | +1.79% | +1.86% | +10.55% That's sadly a rather substantial overhead for a compiler/linker workload that is dominantly user-space: a kernel build is about 90% user-time and 10% system-time: $ perf stat --null make -j64 vmlinux ... Performance counter stats for 'make -j64 vmlinux': 59.840704481 seconds time elapsed 2000.774537000 seconds user 219.138280000 seconds sys What's the split of the increase in overhead due to SLAB_VIRTUAL=y, between user-space execution and kernel-space execution? Thanks, Ingo