From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25ABBCD37AC for ; Fri, 15 Sep 2023 21:05:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A96898D002E; Fri, 15 Sep 2023 17:05:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A1F0D8D0005; Fri, 15 Sep 2023 17:05:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8C0B58D002E; Fri, 15 Sep 2023 17:05:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7BEC08D0005 for ; Fri, 15 Sep 2023 17:05:32 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 476A91CA95F for ; Fri, 15 Sep 2023 21:05:32 +0000 (UTC) X-FDA: 81240062904.11.67C14E6 Received: from mail-oo1-f74.google.com (mail-oo1-f74.google.com [209.85.161.74]) by imf10.hostedemail.com (Postfix) with ESMTP id 8CF7CC000A for ; Fri, 15 Sep 2023 21:05:30 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=EU9qlK25; spf=pass (imf10.hostedemail.com: domain of 3GccEZQYKCOgcOKXTMQYYQVO.MYWVSXeh-WWUfKMU.YbQ@flex--seanjc.bounces.google.com designates 209.85.161.74 as permitted sender) smtp.mailfrom=3GccEZQYKCOgcOKXTMQYYQVO.MYWVSXeh-WWUfKMU.YbQ@flex--seanjc.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694811930; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yleJC+7YBNlUjlYVNZzM9vt9cQFuPW3G+hVjyHJnwaw=; b=cUkj/a5ZyquqZK7aSWoALG0NTG2CrPYSo6m6aSZo2MQt+oXPLOEqtpU3aFrcpafzGCpMQ/ yLsQBDv0MfXXua7m2fc6Ma/iS++lBIs7EbtkuwXXV6TTtzLDSX1a+v9Wf+aD9EkrgIp22g shvMPjS/FaQ7NAuUrXKFJN4TW/2D8dY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694811930; a=rsa-sha256; cv=none; b=MW4fmSA/4nWHv+9zdjtC77BhE6AT6/rk+DJQehmbG/f+G2kFckAU57YWaQ51I9hUK1ZOok nT7uYkJXc3zWjhEK3HnzHL+KOK3QMz3lUvWzx3XX5c3800viB7qjdiToUbJFXZ+RIKJKEH YBbIKlquMvu3i0I1VbX6P8UcnFGafeY= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=EU9qlK25; spf=pass (imf10.hostedemail.com: domain of 3GccEZQYKCOgcOKXTMQYYQVO.MYWVSXeh-WWUfKMU.YbQ@flex--seanjc.bounces.google.com designates 209.85.161.74 as permitted sender) smtp.mailfrom=3GccEZQYKCOgcOKXTMQYYQVO.MYWVSXeh-WWUfKMU.YbQ@flex--seanjc.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-oo1-f74.google.com with SMTP id 006d021491bc7-5712ca11ee6so3680444eaf.2 for ; Fri, 15 Sep 2023 14:05:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1694811929; x=1695416729; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=yleJC+7YBNlUjlYVNZzM9vt9cQFuPW3G+hVjyHJnwaw=; b=EU9qlK25au/x0bqlHTonYB94tr8PNmDlGdBv93qcCOBfBrSdNlDT55PXlRcQxAUcfp i8/Zj+ZCg3+86Azb2CLc5oJmf9M3OaFFhEEsLC5731+kQ7p0ImZ3Wnx6Tbjy/ntR+qWI JcgrHhN4GP+vzS4SmtADu+GB+x2WQHHRZw2Y1z00dxahy7itXt3kO6gLLYaCowflurBP Bd0J3BCrN46ylPXiJ0xW32koNfJ6cfUFyh67T05hWMw3kVKJDcDrL3WH3XveT9ipba4f gzoN4BOGsPRbrDBDFaWnMp1V1YRnUHExv7wIRj0LX0X/8p/N8lCr28bqDBn87ELgdFXW iTSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694811929; x=1695416729; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yleJC+7YBNlUjlYVNZzM9vt9cQFuPW3G+hVjyHJnwaw=; b=rnsakaAFymM60GrotcRPVY0HeTAn+puD33ucJo9SgbqSKOE179tP8C8W/1L1mHK1YT d3pPD7NrzDlh6SgLlGLp6piBqIsY0kVzFekayZ+dA1sFXTfJBmAThqvf6mtm8Nq84TVu JZLllfIB1llw0+7ZohUPe2YTUSOCGuKNv43E6si/Vmj/3hvl3gZeLXobKDlnYEJEz18c IzUvImuXbtaJrmqKTCpFJmUe4JJWPWhskty5Ud3HPNFsFRqHjZNigR1t0MmN2Ov4ROhV BFBY4f/BcKdC4/FRV1lEKXCMP8IoHy4bsvdBZhlNSWfcjn6NOn9+Vcgm1CRjPurjDc6F LqHw== X-Gm-Message-State: AOJu0YzkP801pnydUnviBzkCS341CH/HL9f4wH4ooaYdPJ432YeonfxC c46gfoei0RgSn+Njm1gF3DXi2FoMHGg= X-Google-Smtp-Source: AGHT+IF9PpTOkzcgimAJrduyF4qwfWt2KP5EbzIhLTMy/s4gm21Ep/5FIgTjRytGlNZlubXZjpDBAQBvLB0= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a4a:2c02:0:b0:571:1762:7718 with SMTP id o2-20020a4a2c02000000b0057117627718mr908496ooo.1.1694811929595; Fri, 15 Sep 2023 14:05:29 -0700 (PDT) Date: Fri, 15 Sep 2023 14:05:27 -0700 In-Reply-To: Mime-Version: 1.0 References: <20230914015531.1419405-1-seanjc@google.com> <20230914015531.1419405-2-seanjc@google.com> Message-ID: Subject: Re: [RFC PATCH v12 01/33] KVM: Tweak kvm_hva_range and hva_handler_t to allow reusing for gfn ranges From: Sean Christopherson To: Xiaoyao Li Cc: Paolo Bonzini , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , "Matthew Wilcox (Oracle)" , Andrew Morton , Paul Moore , James Morris , "Serge E. Hallyn" , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Chao Peng , Fuad Tabba , Jarkko Sakkinen , Anish Moorthy , Yu Zhang , Isaku Yamahata , Xu Yilun , Vlastimil Babka , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" Content-Type: text/plain; charset="us-ascii" X-Rspamd-Queue-Id: 8CF7CC000A X-Rspam-User: X-Stat-Signature: qaqaump11rdu9ddfkm9hq4pjw6jirudc X-Rspamd-Server: rspam03 X-HE-Tag: 1694811930-13595 X-HE-Meta: U2FsdGVkX18hwQBaHFJXfgXMN5LyMshKO07q0d1APTKO/1YOtzqCayNG8EQ/EIydWDzyn3z9O7AYYMZuW1uPwaoVPSHEtd58Ln5QQ3pCXz/TwEK7cqcIjSQ5wxmq2ft97FKupPfyNZlQ6AOW24FtajyP1NcxNbKUrEcnzyejU/juhuRZqa1jy6IasyqX6317udGynMeNdsB3ulbLYPobO5wBgcfgM1rnafGg69Ls/LAF6FT2FytmIam5aWMisLGSUFQiJBsRy7oZN0OKn5SjPQv68U/tyYi8SRn7izOKCohLXGAM8n8VYSRyZdzEbEI2KB7mOc9ZsCBwkKtOS0kn9v/psW7XzoDRVYHo3unPa/3ZcPm0mxLi6RyPR7NIp5KMviKa3/tRtvihx4zJCebSnPmjYx8+reD+eUyTxzmsmKgi6gGbmYmJIBSs1G3LhZJ5wAZOZnHMX2YnZ5bvBiZ/3Y0r5CBwwoZhj/4sD2iXLqK2CkEMiDca0bgbgksdW3yKdGX22IhNeLJHknFx7pr8zKeRPCqX0iByRfqxuqVHriz5id466ieWTpbck34cBmfMROhF81GY9KpDSjbLi0HCnCquoLfexArwvG/veOmqDbmALhNROVSvFxItsmZBy4koqTetWmkaiQbzYv49ljd+kkovv9xapexoHICIlimbIgwDFkxb7aBLjIfFx42zZ8Xcjfdn6V67OWh/zdBqzhMBLRAXtc+Wl6F8e8SX7WNEKrzlG+LP5BNkhca15TjIq+moKPdrutKj6PshgqTn7JrwyocduzXPkIFPjUC7TxzD4rjyxi6XyEpbldjw1CkSqieizNbCZSVBFE44P9z612jR026weVR7gbofycmFjoHoXL4gEvc5K+gqzv/QSN3qRhSLcm7j8H5hDH4V+aC2m6uLsdMFguPerq+sVte21ybEGvmk7BdBG7ATTZZnG7nP316Z40cRg1kjJY9KuRDPDCT SGXrYpzR tt/3+gZLhBILITeaHHYZqj5vd31hr6u1QyYMvljhDBnkb7t5eLtwlIoF3txqtJbBHs1YiqHiP+BgwJAjtei9AVTgV/rqv0mVxYj2wc/e7aOWslMIOWB/+SqRAW4eec581F8WhUBBaA3GwEWuJmSyVcbDKT+mlBNlFjsgBqLYMkYktKrBWk2Jwa6NDALVoBaevlNoiMlEzMR6AKwkA7spn6TvB2SYbx7IYa5Eh9IuA+Q9exui7oJSIm3XMVZHOlQvK6QmeokAaZMw+NnivZhERsdzl3SUYz5OAwlcjndLQM5cVmsyDUI3x/VJU9cGRdq7IAoagW1M5xTKpzmNVwQ1RpHoI7jwNGhYzrvLU31qhrG7Gzv8VQlc5AzWgJbGPsi/LNddvQHuZ6IBDO0mUex2uDk03prQR/oWkpYIvOwc4hpDX9OYvcLJ2lov8VMo+gPmuyOA+1pRPWAHlnJ5BOrtECzJGdytkaEqbRCBvH9THilEYyJVDyu3OIlH/GbPgoAJpLWKEnn61/XybYD1beieBQnACVD9/40nAqIt7vDwZoYvemgiYagInaMswjDOuf7UhZpbHzRodaAzACgWN903GZzfTJ7rX5tsu7w+wD73fukwYy3rgdB/zR9ri4EZn849YpIG3YpHstaDlLS6tioDunHXdUjboJ4Ic7j9WEfKpMG47+WrSpbV2S5LRPqUFMJgqHimMpPRsgqrxfh/+cCSNxMdYlgcH5usV5ud/uLxPnrZg1M0E1UUdryhUaw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 15, 2023, Xiaoyao Li wrote: > On 9/14/2023 9:54 AM, Sean Christopherson wrote: > > Rework and rename "struct kvm_hva_range" into "kvm_mmu_notifier_range" so > > that the structure can be used to handle notifications that operate on gfn > > context, i.e. that aren't tied to a host virtual address. > > > > Practically speaking, this is a nop for 64-bit kernels as the only > > meaningful change is to store start+end as u64s instead of unsigned longs. > > > > Reviewed-by: Paolo Bonzini > > Signed-off-by: Sean Christopherson > > --- > > virt/kvm/kvm_main.c | 34 +++++++++++++++++++--------------- > > 1 file changed, 19 insertions(+), 15 deletions(-) > > > > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > > index 486800a7024b..0524933856d4 100644 > > --- a/virt/kvm/kvm_main.c > > +++ b/virt/kvm/kvm_main.c > > @@ -541,18 +541,22 @@ static inline struct kvm *mmu_notifier_to_kvm(struct mmu_notifier *mn) > > return container_of(mn, struct kvm, mmu_notifier); > > } > > -typedef bool (*hva_handler_t)(struct kvm *kvm, struct kvm_gfn_range *range); > > +typedef bool (*gfn_handler_t)(struct kvm *kvm, struct kvm_gfn_range *range); > > Is it worth mentioning the rename of it as well in changelog? Meh, I suppose. At some point, we do have to assume a certain level of code literacy though :-)