From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38C70EEEC01 for ; Fri, 15 Sep 2023 19:03:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C698B6B03E4; Fri, 15 Sep 2023 15:03:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C19DA6B03E5; Fri, 15 Sep 2023 15:03:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B09C66B03E6; Fri, 15 Sep 2023 15:03:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A298A6B03E4 for ; Fri, 15 Sep 2023 15:03:32 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 7502EA078E for ; Fri, 15 Sep 2023 19:03:32 +0000 (UTC) X-FDA: 81239755464.22.EDB06D2 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf29.hostedemail.com (Postfix) with ESMTP id AF8B512001B for ; Fri, 15 Sep 2023 19:03:30 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=qis9C4C4; spf=none (imf29.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694804610; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DFFZh6035wvtRcIoOVwiEivYJp4WLElf/LkEGCccAuY=; b=hJotH2gTOsywf0+A8Ui4Fb7NPOusjemNwHIZOz9l5gDsyhOUOwUG4AwxMrTVRL5vTMli7o hJwIT9AqS4sW+h0yI0ZysKsSJH3v+Nv7HpjC2bVnRRtOsP9mAuKsEUWJAbFxeSRkPddfVo IdWavrAQzv4Z/V+A6k0WrQMn1YfX5Fg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694804610; a=rsa-sha256; cv=none; b=Wbi4R4XCMCZ4sU79V2tSAD25SI0mOa0x1itkA94MVu4TaBiONHnDhl1zkN2gj12idPiMPf aYZVfQ5FDG4tgkdePLiH5QNWiQ3dOwXXX81ZQic3EQ2yi8L54bsUBGKrVQkAtVRHVeXvTc EF4IkxNzX9ZGepYpo+R2U1RXvaXWwxs= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=qis9C4C4; spf=none (imf29.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=DFFZh6035wvtRcIoOVwiEivYJp4WLElf/LkEGCccAuY=; b=qis9C4C42q4PXv0Y8mijuIrGJ8 eL/+ltxOleMFDTZMsHDEkMTfMcmjwlVfRCljoxKsiGDbU44p35poIZc9NCMFng5gLawCnYZk5wvBS M3pSisA0y7eiQ/d7P31tXJHfk87IayXbpxQkHI+y3wpSw60dxRVqQatMUcvlkMgqkyuTdbxwJLKJF aCsFmhb0R8gIavgA5Xqln2EQibbmmtpOQGnx8Thbib2xYjMxaCOSNXVcDNwKPJLYH1RmR3G2O1D1G ZjR0akbrdkJMCX9dfh9GaV5qjFNIRA5OcEbxAYtEY4t7UArbD8wRpLaFu0PMbyVtQWU6mSdCUKK3o hcojstjA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qhE5y-00BUiD-2B; Fri, 15 Sep 2023 19:03:14 +0000 Date: Fri, 15 Sep 2023 20:03:14 +0100 From: Matthew Wilcox To: Pankaj Raghav Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, p.raghav@samsung.com, david@fromorbit.com, da.gomez@samsung.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, djwong@kernel.org, linux-mm@kvack.org, chandan.babu@oracle.com, mcgrof@kernel.org, gost.dev@samsung.com Subject: Re: [RFC 01/23] fs: Allow fine-grained control of folio sizes Message-ID: References: <20230915183848.1018717-1-kernel@pankajraghav.com> <20230915183848.1018717-2-kernel@pankajraghav.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230915183848.1018717-2-kernel@pankajraghav.com> X-Rspamd-Queue-Id: AF8B512001B X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 84uwqedatxzj8mceaqsh9cho4tfg7k1d X-HE-Tag: 1694804610-163218 X-HE-Meta: U2FsdGVkX18uSRV7Jng4nloeeb6crW3s9cQargR+tDqgIEK1ekgYavD9wIgWCjH+a+SKMbEdi1S5fhLo/CIRPFWp9itqHf72hkS+EbfcLdLOpZlDdKFK7okLQVIKyhFXQzkyEZcp2ynLiABVaxtDWC47A3Oz4JoBsKXyG9yGkY3wXp3+Rk6NC/KWq/CUr8uzDthuBI4wxiDuPZUZKHdDymVG3P3Hn40UXgAcZJn+J4wIynaTAImkEOO4e4WBUbD7DrhWSItMRglTJuhPgJpOYFtwpafAJsfOBk9PCOMEgmfDXvTsM4zmFLXO73IuCzTLz+/K3i8KkQmAtq1l6o5NeH+YrisH+Z5VRMeO+kJDB8kazaS2LLxOqZLcbFACh+Sy2aI6xZdY8+X8jxnmeHyHm7Gwy5QM77+vgJ65hxehqK3gdlPa5WNbnJKzgFEGo+z2PYEpBnMpPC02dvdMZ+34s78ZvIlv8r5O8lMVJjytHe9OF7jpnnUaOjgJe8GslTByy9ukCLiLp2Nm2S+dlbXacDYe94rRHId/wTaoEblP14nXFp2C3QE69EUlS6ao+/OCgZhZ067lXlqhX4l5/Tj1zPaq8fnvoEC7zW/l0iiYAqrvxh8nLWpyPd+vW0SFKvzGdhzwK2v898VI33FOhgMYHJq8qWrhza7dgKowRYrB7mwyI8K532K2KUanZD6D7CQV6NejluyTVuNbMBOetZI+C5PKh5PvCPyLyoIdEYdJcfIV+UZDIOhHdUUslMLHcKrgAaZQX66mz9RxX3BgFkcUw4PzDjViPidokElNYZt2zU9b3EBTmbQG23SAMQunX1c/lkEC2NQ3nnVwcMhUQPC3yQO3QeIcQQ5pYzZ0yfWN3k1P3kYojr3QdCklP5RPpNHDrE012ecACLR9BdTdE2+0Pwjpr9aeiG97rpX0gAgjWUlsBXl1mvff5TdMK3Qp26SAX8xA3U+MWb2ojwthzYe Lheky3U8 0JlP2PpjzSTdhETYiLB8QWu2IG+DpXjc39DujRUryvxvIEbSsJITZkFvWFKIWS6AdccTw620lAtwCifEY05gKKAYS4UDfUY6UmuULyRjRRPRS766BpbFnTvtlVbzqNfGM39Pi9dBNS+38LiM6Ht+l/6xjgM1Lo/8Pef+l X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 15, 2023 at 08:38:26PM +0200, Pankaj Raghav wrote: > +static inline void mapping_set_folio_orders(struct address_space *mapping, > + unsigned int min, unsigned int max) > +{ > + /* > + * XXX: max is ignored as only minimum folio order is supported > + * currently. > + */ I think we need some sanity checking ... if (min == 1) min = 2; if (max < min) max = min; if (max > MAX_PAGECACHE_ORDER) max = MAX_PAGECACHE_ORDER; > + mapping->flags = (mapping->flags & ~AS_FOLIO_ORDER_MASK) | > + (min << AS_FOLIO_ORDER_MIN) | > + (MAX_PAGECACHE_ORDER << AS_FOLIO_ORDER_MAX); > +}