From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1949AEED61A for ; Fri, 15 Sep 2023 18:55:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 90A0A6B03DF; Fri, 15 Sep 2023 14:55:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8B9E46B03E1; Fri, 15 Sep 2023 14:55:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 781EE6B03E2; Fri, 15 Sep 2023 14:55:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 65A976B03DF for ; Fri, 15 Sep 2023 14:55:34 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 36FD8B3774 for ; Fri, 15 Sep 2023 18:55:34 +0000 (UTC) X-FDA: 81239735388.02.C0719D5 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf18.hostedemail.com (Postfix) with ESMTP id 937991C000B for ; Fri, 15 Sep 2023 18:55:32 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ZG7FxJoM; dmarc=none; spf=none (imf18.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694804132; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ydxv0H4AQODCBA++n6E0d1nAOuRuwCzEkOyn7750pKU=; b=V9eOJsM5Xw5rpS90y6qsXsn0Dw68Q5LPU+hmYVTdNofiAlLBY1raRQG74XdE3bCcbCZRH/ 3bfYnXSfqUX0gfq5tns//ULuwE89gkmtt0fbfT1b5CDWyOwFHd3ndK1LAPkx5e0EurmzNO dp6eXoPkl5BMFYgPYHLbVYorsvaoDq0= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ZG7FxJoM; dmarc=none; spf=none (imf18.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694804132; a=rsa-sha256; cv=none; b=BpiP4bZakvkH2Gqf/qWb2roBuUrMwT5EBPeAY7GBYBGPTqhYpIeo0nDyD14ZNjaiLRIRx+ dyi/zN7h/TFoOUZ4/IAaavrmNse/cch6Gqu5/Hcu2Ncs+SdICScyMSsOeIWUmEpnYZmZOR fTprGR27kMktcLOBCVD2svR6sU2mll4= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ydxv0H4AQODCBA++n6E0d1nAOuRuwCzEkOyn7750pKU=; b=ZG7FxJoMGXk/kL4merXOhxNQ0b bZbpggT0P5T5ujSXAcV9rNN5WWQ2IR9g3DWHHZCeuwOcuBBvHwdwzLlNMpjORpzBK6SrPZe82KPap BcLeLVwpAA3F4v92pDFEWyi1E/510y2Yurro3rYT93uSUg77CFDWQ/HkAD49f999R8LBxbqSCQhbD mEsj/bHc3uyr/44dwj8SgDuJOTXtGx+we8gBzz+QTugqU286xR/k5pEGzcwS/NqI/S5SDhqk9vpdt yhumb613YKarn62iyq+ojZfIJR33DGB+loVFcmj0wMDX8QCkQVM0QSgPpMqxy2evP8RoK1feqCfZf 2gxNfFmw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qhDyC-00BRx6-TY; Fri, 15 Sep 2023 18:55:12 +0000 Date: Fri, 15 Sep 2023 19:55:12 +0100 From: Matthew Wilcox To: Pankaj Raghav Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, p.raghav@samsung.com, david@fromorbit.com, da.gomez@samsung.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, djwong@kernel.org, linux-mm@kvack.org, chandan.babu@oracle.com, mcgrof@kernel.org, gost.dev@samsung.com Subject: Re: [RFC 02/23] pagemap: use mapping_min_order in fgf_set_order() Message-ID: References: <20230915183848.1018717-1-kernel@pankajraghav.com> <20230915183848.1018717-3-kernel@pankajraghav.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230915183848.1018717-3-kernel@pankajraghav.com> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 937991C000B X-Stat-Signature: xsryb4f3q8iiub3h5bbph71rbe4zfso9 X-Rspam-User: X-HE-Tag: 1694804132-430273 X-HE-Meta: U2FsdGVkX1+kYbEKd/y+/khR8DSAsIqN5tiJX3Y+VaHL4r8jjSxJdFYNdDV550OS3x2Hjym9YUisko0OF5jsPOO2gFNPqV2L16VUqOdD+haxtHhgZdc8JPhUrq2x+nJ+d6CJr5Ip4kBqBzAV4LpLhWqrpemqnzgB3j8dYN7OAgai/kv/JsUialduvmxp7MkNbWcnZQSDkVu709rtl8qOt+hgBkIGy3kToBTgeMJUlyY5SlMoahtLSJdTFO1E8PIMEeAOFN8GmPpqdV9IrOmx1z0NzkQtMA6Fhoj6eoR65MhkqcP2tACEUlbzNVqEiEMNiIfhLcGO9PHZ6JCUm8BWtKh7O7vDrpSrl9K6V6QX1vOBd8UMuMSFUGS3vzel3oqZjGfFL9bcBU2av7O5PCpSiyTPl8XJ0lan9bTnppk2Me/oiHpehzRivSVHBs3gzGXs1/thxRdyMh+3vDeTPODkopD1Y8RmFVsy60/JqNDK12ovYoVH0IxLK098z3apiQ6bKjw6WZWKMk2z994Z1gHy6G84X+qxey9Ma69kIBcsWJ2taw61ssbW1OHPLMt5pK+pSyjSuiHufaAFalC88TycIwghZQnzdjDduBItK6Ob2/J367qLkoAVjZCc/xxW2ddohsWC0ygCiTXJEnjl0sLGux4chnaLNyY16pY1UUqjTKLtDV9fUMS85N4zzTvJ90c+T7aFLMlW55BTeeedXAizAfVTOfDE7IyUvdv2P/FwppDd1DVAgblQNK3XJbJjJUuIDtyLXS+FMxVF7Idgup2nIyrmDqrZL3aDKGdFnd57Wd9QcD7NFP8HuwvniyGSpgv3jhMA7AelMfUUl8sJ4s7zGziNCEs7xNQikDhGojRH1P7yprXd9phjlCEOJvmJWKFzI+LNZPgm9hSJggsqz1gx3Ut8hXeRLAsEDjhI0g3aqQgRzLWasq6pUWNVe+Fa503e/uXBUj+nJyKh4c7mBvp Fzj3T2G/ RMlUaSJA+e42yUcM2wY0fZ0ckH5XtgAN07koIh7Je9msK0fVMcaKO7IQ9/zUv+2ylhmItHXHq7L8jihv8mixOiKcYYlbkRJvh42LNfLjLiLaRv45NIp/SxQt6rjFPAEUS5yEfxJW8w4a5mBkV1ZwiP49+gyhaqIM7B1PTN4Bmlnj3KLAIinZXQPliR7q7yogp/uFe3Gz7Xq9hQeFriLTEizj8xA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000065, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 15, 2023 at 08:38:27PM +0200, Pankaj Raghav wrote: > From: Pankaj Raghav > > fgf_set_order() encodes optimal order in fgp flags. Set it to at least > mapping_min_order from the page cache. Default to the old behaviour if > min_order is not set. Why not simply: +++ b/mm/filemap.c @@ -1906,9 +1906,12 @@ struct folio *__filemap_get_folio(struct address_space *mapping, pgoff_t index, folio_wait_stable(folio); no_page: if (!folio && (fgp_flags & FGP_CREAT)) { - unsigned order = FGF_GET_ORDER(fgp_flags); + unsigned order; int err; + order = min(mapping_min_folio_order(mapping), + FGF_GET_ORDER(fgp_flags));