From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0931CEED61A for ; Fri, 15 Sep 2023 18:50:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 907186B03DD; Fri, 15 Sep 2023 14:50:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8B6736B03DF; Fri, 15 Sep 2023 14:50:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 77E086B03E0; Fri, 15 Sep 2023 14:50:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 69E7B6B03DD for ; Fri, 15 Sep 2023 14:50:25 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 36F87B3C33 for ; Fri, 15 Sep 2023 18:50:25 +0000 (UTC) X-FDA: 81239722410.18.BEC850D Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf17.hostedemail.com (Postfix) with ESMTP id 423C640007 for ; Fri, 15 Sep 2023 18:50:23 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=HC2OPQqF; dmarc=none; spf=none (imf17.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694803823; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LO1yu7NDurGz5o2rdddgqdJM3Q13LpqRTHQ7QT9TTOo=; b=7546WH/dzLi3/j8NgzaHd9pTISAuI5IHsHNhh3BAI5N7vSc2uLBN45QuwzwPg7UgL7lp9C NqiVbLKVUAh/IPNx4pW36jjcsBR8xtwSEKqbB3LPKCsldXD9X95rKEhkxg1RL+5hy7bw3k m0rF9D0W32+eL9CS/MPVveF6x8uIwQk= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=HC2OPQqF; dmarc=none; spf=none (imf17.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694803823; a=rsa-sha256; cv=none; b=QH9P3Lvqodz2GR4l0+EMztCuPVMk5L/0nka6nNk7J11epKWgeoER0YiBwsECs6CSTpCEK6 hsSXC5MIoe6ipCZQXpsG+S1sjmeaD8PdlTXACg37ygR/3Oxy4XFECVvTjD/RBEzsx1NH5p YQ1EkoXDHhEKL6PQKLtj1AJ0PXucD9M= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=LO1yu7NDurGz5o2rdddgqdJM3Q13LpqRTHQ7QT9TTOo=; b=HC2OPQqFxalw4dkSw+zCUvDi2m CySSkIZYKgpzi/LAc5N11o7WrBB/5FE6qHQOeedzceli1IkuyglEbMmyOkF0kR7qaHuZTui26guLx i8m56aRO6jFnb8AgdkHySPgjuP2zdjMt9daRxVPXvNN2ogy4I5yktIu4oD19CEom1Iz9bhwIQPro3 TQAgxXmkowCZUSxIEmDGxBveDUNejR/hhRiC7vxY57WzssKbFQ4NbVCGiMPA2IWlDCfdGqaKuQx7I vrVxbi3B3dBMMycQVMptqrnEbNWy0SL8Q6/R0GiPPWafnvEJdx76F06W3OVITw886NCLdjabT+UpU 7Q/ufstQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qhDtB-00BPM9-Ii; Fri, 15 Sep 2023 18:50:01 +0000 Date: Fri, 15 Sep 2023 19:50:01 +0100 From: Matthew Wilcox To: Pankaj Raghav Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, p.raghav@samsung.com, david@fromorbit.com, da.gomez@samsung.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, djwong@kernel.org, linux-mm@kvack.org, chandan.babu@oracle.com, mcgrof@kernel.org, gost.dev@samsung.com Subject: Re: [RFC 00/23] Enable block size > page size in XFS Message-ID: References: <20230915183848.1018717-1-kernel@pankajraghav.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230915183848.1018717-1-kernel@pankajraghav.com> X-Rspamd-Queue-Id: 423C640007 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: hht8bt8h5gx3c87knubhj3gpmbja6teb X-HE-Tag: 1694803823-397121 X-HE-Meta: U2FsdGVkX1/wY/tM5KqDXrv9pxx8MQXxy8TwVjwIzEyte+xLCBQnkixhb58Wag6ZHGN78KWz4xNX6d+WBANvRnhsVc4xDQ1R58RannvIK5VC2Onb39HrP8BJczNnUUfbcNUngKVuub5enrbtXVr4RS2kOCdoB8XPSg0h+4ZD+cG8mIyMW31SksPA0c3ZT4luHgwaD5shjeQQLdmlf+4CxUmYFsUNrZLt+885NpYdHFKVvFC9G2aJYBFUtt/veRmDl99Y4Jq+K6LOxffkWyXuuc7UAFk0K8YHKxv5becFhzOCyRY2HaefoO09J7jyGaQl2mta1CJ/pv+LYrB8l4m754uAXBxNQSRkIVdNJT88BVcTuDbIH3MNZXyKPu264xywkFNx1cMeya9eYG6U29+sXSIJow5InUNYKX4E8CInNkM+puX8eQZDXWMLJmEmNfvKsFGgQYm0MOJDY4D+JXY/Nq7EVhtKhPrSHqUet0eAP/iSFCoAWtEcWoTpVXi9ZQ57QXQJ8vpdE5ThJMRH+YlvexBEZoivrmClZM6HKm5eZWY4xlYDXCojiZoOKjpQzLHBg46AGEWJZFNlZn3tTPpO+mXaYHR82J1yc10SExIUOXS/ALZqRPRxJIgDBmRPdOXrKUxgYonNKCgPAkz8KuI7c9z9WMDhwB8KqovyaZ5aeMohJFJCrs86StWQ//5q9RdsVINJDElYV85sDofL7JMDfFWz8W8nwX3brMn0A8p3YZyYZIQ7ErwbjgJpePh5RSt/VR7mcq08+WGqAT4TxjVTnj7YJo2MGMNhAHu7/T8eiV+W8k8IBjaM4sG9+hLekWkZHQ81C8es3owuegiBCSNZ1UuGixTr99irveOj8caYWZI2VVsidF4fMUEeW7w2rmpP4OBcQI21FZnCXkg/eT8qeTUuFgOmZwcqBhRpVCQl9CH5g6ji7cRRWONW9SCfC69s7EtHrzLTP6c7cnBc86v Vctdio2m DbcNgp+/uGDNzHSaHcMf4CiFXvnzW3geoccoTe/IsYpLcjAUfupEbPtIFEIGtO1Z/tkD2HsafVvnOlRuX1OCupAJsu36gmIJhJAPzd7Vw/0V8twJfftSkOGpxP0HkLQwqiQ5rdzlKl+qVKlY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 15, 2023 at 08:38:25PM +0200, Pankaj Raghav wrote: > Only XFS was enabled and tested as a part of this series as it has > supported block sizes up to 64k and sector sizes up to 32k for years. > The only thing missing was the page cache magic to enable bs > ps. However any filesystem > that doesn't depend on buffer-heads and support larger block sizes > already should be able to leverage this effort to also support LBS, > bs > ps. I think you should choose whether you're going to use 'bs > ps' or LBS and stick to it. They're both pretty inscrutable and using both interchanagbly is worse. But I think filesystems which use buffer_heads should be fine to support bs > ps. The problems with the buffer cache are really when you try to support small block sizes and large folio sizes (eg arrays of bhs on the stack). Supporting bs == folio_size shouldn't be a problem.