From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E869CD379F for ; Fri, 15 Sep 2023 19:51:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1B3AD6B03E3; Fri, 15 Sep 2023 15:51:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 162406B03E6; Fri, 15 Sep 2023 15:51:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 051036B03E7; Fri, 15 Sep 2023 15:51:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id EA6366B03E3 for ; Fri, 15 Sep 2023 15:51:09 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B1AD7404ED for ; Fri, 15 Sep 2023 19:51:09 +0000 (UTC) X-FDA: 81239875458.22.F1D0319 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf02.hostedemail.com (Postfix) with ESMTP id 0050580005 for ; Fri, 15 Sep 2023 19:51:07 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Ja3fQlpP; spf=none (imf02.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694807468; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=14vBvaf+q0K2fr0TOz07mbChpshy7ApizxiUPLAC/WI=; b=XVhjiTWmxkschf5HV0/oulS7ZR67VOK2NV/RN3z882EGyqjhXcxKxs+DxAneFRmlaC7bhd S9Fm8J/U6cx2OFL1m4s/Eb51UxUUD8iCSLQRgOahWlDBxvc+EH8FRymUGy0UgN5IObKoDv bwty8D10loe3CHDqcBvlHiogi5xNNPc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694807468; a=rsa-sha256; cv=none; b=LT85TZLO3lxpgbF9DD6pioBS+1bYcKvK1319cGYx+7bPqF8ydPlBoFJp1MYYb3u2mJsvKf OpOZKXxU9Jqda1N7/DnRSMcV3C+bfntbPPuwVwWziXbsUmd+Q++1ya2jf6axUBmI/PLOLE 1QImniRvs2My3N9BPEIst43IO6fpMIQ= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Ja3fQlpP; spf=none (imf02.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=14vBvaf+q0K2fr0TOz07mbChpshy7ApizxiUPLAC/WI=; b=Ja3fQlpPoWGk+zq+9o1/WB9r5B /7dMsOKS1yrOjRb8Npu5GcxdpAMGp0GzSdiTzniP4vkGLdM3IO2rvVEhyIa/gbKtpyNG3Buydxgl9 EvUC5wZyoC5bkop2xQzC7KdgwPN0+YGcy6VQ7VxfMsvH756Wd1s59ay9eYQCyDHfC9wKDgxcBIrnP Fzoso8qb1KMfqTtprpebj7oi1UR9jn9u2U0crWJpbFWODC4aaduG4hG8Cijy6q784u9m/SU9gNl2H 9T5uioF8X++lPczVI0O/z3eW6vp1doWkFRhhHmrOUXFbqH/k/NC+4qNxQz+2M0cZXTwLS3bQMVLLq +g3eyoHw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qhEqB-00BiaK-AI; Fri, 15 Sep 2023 19:50:59 +0000 Date: Fri, 15 Sep 2023 20:50:59 +0100 From: Matthew Wilcox To: Pankaj Raghav Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, p.raghav@samsung.com, david@fromorbit.com, da.gomez@samsung.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, djwong@kernel.org, linux-mm@kvack.org, chandan.babu@oracle.com, mcgrof@kernel.org, gost.dev@samsung.com Subject: Re: [RFC 08/23] filemap: align the index to mapping_min_order in filemap_get_folios_tag() Message-ID: References: <20230915183848.1018717-1-kernel@pankajraghav.com> <20230915183848.1018717-9-kernel@pankajraghav.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230915183848.1018717-9-kernel@pankajraghav.com> X-Rspamd-Queue-Id: 0050580005 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 85eiyp5i4nftrqxk8w5aoaa1enqqtpoq X-HE-Tag: 1694807467-203271 X-HE-Meta: U2FsdGVkX1+hrFgsaUaiKHMeqIC80HxMgSy/jqX3m3pbf2tQdfDzt36zytqOygrht00uOWXMN4cbv7ahs7M5swH4KC0wdBUyweHQetH+DHdTPIfp3K9J2sMcLdnA2MSZE8jCKs7eBsq4lwwOOBzMsiDmvFLs6QilNCNpk5h5PYTU98/y3L1LPk+fhR93mvMyh6jFUTSeeY4T4ODXcFp9QbAd9XY8cM4iGW2OGmn2Qu+rg3C05zZOjJ5p8IAqqwLIySIYcvhKbR8WuK7eA1FN96JkKauGMEIKaXBaFMUgKWpbpfr4j3awK6hJqkIDRCEJ7WkiVUtqAiA4A1VRMybS6F0cG5YARx8Gr7v3NWAi8akmD/zXOba8Ba1oQIkwpQsC5jzGxIkpw8vjj+oW8dYMJ6ZSgaQJ2i+qANzX5hLhQdc5e71NkbX+lIjfg1HgIlhcEicbwWjIqnn6Pfz9z+Jxqb/nTyyVjnL+8ITp5zmCkEGlonwtn950HzdBSw6dHGfXII0Xmjkif3BFmMuEL6RZuZH2TKyl+RAR6clHbrxft8ixd7sdUMRtDQKPzUpaD0dxVgUOta+m1ohZtpChmzh7EabOUJHdfgq4IO+nNOEz5V778sD4m+LMf+0sLDC+RRkaAOBsWY9exS8ti1Cd+weeV8lYTH65PHRhGOP4+CYmMO0Y1koABCovVLeqwnZwh6yQ01bSszhm68IymWPLNYM1NxbJj6hrKMN6gf3MCrRzTOp/I3YUNBOxTBX9SeGji3IS9SSnqIk5HEc3bGpaFlek9MTDtTwHrFyUvB2Y8bkOqOCeYWWarJcg+hGsxQQ5S9c1HPQUmZXugpxpfiwyWpEwjiEumS6nSSl0gd9k49HbXHO2KlqUNUMCFZ7E4504E4gdOILV91lHeqhreeGO+F3To6o4fsmfpsLTKecs/qIjTZKzDblQVhx8AIeT2WUM8B6QCapCyCUKJt+5/sZhZwx bwfDDGO4 K6aQWT5/T2Wp6u4t7/YUShTE8LT3TqtywymXWGrKpOgw8hTgvvROD+loQypjcBSud4T5o2VsGMxjLUTLw+/9u9/ajCAkEuMncpKWeyOhWYfLyk/SlpTbFmX7m316wLVog3tgwdQhraRxBvRwUelDd5q70Cym36EpcoHRpyE5v72ElHE2kt+6aIeTVxE+E5R2iiuo3XUwjO/mxQniRpcZucnYDPvf/c6T6z0xz+4UNFklDNH8J9G2NZYP2Iw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 15, 2023 at 08:38:33PM +0200, Pankaj Raghav wrote: > From: Luis Chamberlain > > Align the index to the mapping_min_order number of pages while setting > the XA_STATE in filemap_get_folios_tag(). ... because? It should already search backwards in the page cache, otherwise calling sync_file_range() would skip the start if it landed in a tail page of a folio.