From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 787CEEE645C for ; Fri, 15 Sep 2023 13:49:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0BE5F6B0370; Fri, 15 Sep 2023 09:49:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 06EF36B0372; Fri, 15 Sep 2023 09:49:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EA0A36B0373; Fri, 15 Sep 2023 09:49:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id DD56E6B0370 for ; Fri, 15 Sep 2023 09:49:44 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id AF246120686 for ; Fri, 15 Sep 2023 13:49:44 +0000 (UTC) X-FDA: 81238964688.12.713B811 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf28.hostedemail.com (Postfix) with ESMTP id 1984AC0021 for ; Fri, 15 Sep 2023 13:49:42 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=cul73f0l; dmarc=none; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694785783; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UIIhXNicKHnnfcqIBqQZ6OYm4L0/hzD6ZeRNbDy+XHc=; b=fI/5Gx2VcsVv9rFQ9OqjH/6buhLbm1iJ5Z0CqHYH/G/12zxMoWACm2p9mkpxviS1cYS+bQ +ypXPNOI90n7P6GPX5mgHgKZUQrpusNEGIs+lE6zlJhTgnL3FYa1dDiv6GERZJDSk4HSk7 BfKeFjlPdNwIYwNEtY73QgRZk6h/sPg= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=cul73f0l; dmarc=none; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694785783; a=rsa-sha256; cv=none; b=QUVyzTqkxNIbyvCHsQAle2puKJQtTDYNJrPmdhNdb2LgE4n+7H111nKh6hHZgWiRfd5dAj oohJu0r2+zzRTN2I3CUQ7Ke0gDS+swPexSicQb5tec4BreFUl7Z/+NlpyW8vXNw+4JNPn/ vyiLdVp17TLAZ5GZ4tKfg6zW5/6EgUc= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=UIIhXNicKHnnfcqIBqQZ6OYm4L0/hzD6ZeRNbDy+XHc=; b=cul73f0l14bcuYtUcvN9r7dVKs DcurGPe+nrC5goDeEd1PUy62+J/VZP2dW6a0uPG+1Aa4aKTNkmJhILPvN758RreVgCSZDhDBKaD18 s9+JwvAJPyijhJ7oKOdna1B1JZvMY6SQ9Wi8RjGpMOkK1vL7aP25/eRG9WCKIirOWbK6wItUxv6BI 0utrrklNHiI4Ioepl+L5YmGWka1WGlrEED+nDJJapteTCXDb1w9F46OJ1AhGCh9L/cUt0+IKde0ct 7LNqA4V36vXtu3p8qxqavZcaejnyfLNd7W39dzAGQ3ZDyIFYSlabAPCyHgZ2WxHPDkn6ahaThLBN/ H158gsSA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qh9CV-00A1sQ-QO; Fri, 15 Sep 2023 13:49:39 +0000 Date: Fri, 15 Sep 2023 14:49:39 +0100 From: Matthew Wilcox To: Yajun Deng Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/rmap: convert __page_check_anon_rmap() to folio Message-ID: References: <20230915101731.1725986-1-yajun.deng@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230915101731.1725986-1-yajun.deng@linux.dev> X-Rspamd-Queue-Id: 1984AC0021 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: oaxxytf4uus5fjca79guu5n98tw3pcyo X-HE-Tag: 1694785782-828566 X-HE-Meta: U2FsdGVkX1+XEKqs3nHeLdCZ6ZwcM1blJ8lBpz6lyjUc6EaofW3OH08dyY6O67YXQ69njgmxlnrKU66+iSYlj1amcyz4bGj8qdmp6g3QznMqA2zlImAclAitklGUh5COkBJRYLy6EzTFDy5uL1l9XziudKfOvVJxeVnzmoz91uYlZ5Za5FCTN2UTuUEeg0VsiUSo1cbG63MflhLcWLssoe7BqBfpllqiUUrdrB/L38mh8fyGaO+CnA/wOZZbwstJeXPZUQzxUxO8OPB1n9x3opx/D1uadXG+SPvIzhqA1gJqgB7zgbTx3/BPccd1HQmvaeY6cN9t+JVMotkSRRAJxa9m/MHwqlkRl6NaOlJpRkJAv/2iqq5FLgh7Ze9i/A8fPELAUMyz2S2YrTbhE8hyc/gwpCoVgg9iJFTFwpGTWsB0RAFkyCORG7wKHO4nLaAyeLJ2o78ZL0lnVGCFPRi2SR2DxTVeakzhVju5l9MnfG5TDlgFWrGzjQIbMdJxTE4B3rsx25IkS8CDqUJhRZr0pzwgwcnjK3VYnalwr3xtx+RylM74fjRkuvB4G7utLYGKUsLRvlXj64s9KbxEx1J/ErSv7p0vQq4mhYorkK0nZpMaWAwORHj0nsIVxdStkBtGUolJa0Q7Vazh+xBC8N/W7bK4cmSVBhcgvoc7W6Vd0ilAhjzvL4G1PiJLvpMX54Lixcv++gLVOVVZTcywkHicftYWjNh1DSm9+tF9NCbssGRT4V7ngnGgAU0I1D/taJ879iESMpR9Ts5Ut8hNXy1twk/3/RX3slm9r85PEJH9/Lynf0sxWX1X/iopLnV+MoFVuJKftbcyAPO/td67ZLGcpajktAJDNGotLoNyiPPQRG7f8XhA0bbHWAgeg1HNbfcshuLxp4h2qZwP7KW/Pf7Wv6JkXU47n30IVAcm4ZxadLomXCdgyBFlozKFAV6AQsW2QXm8i/Fni5yteR1pkGg nT9+XmU5 to0Emadaqurbv6J3WbGEZBSg/4497ZBxL238FP20cKdoY4v64BWRakJkVxjR10LzFosW15iJo4rK1sxJtd59njNsxFAL02+3fxwpZfVTV0Kwm0iIWaUbcUyTHleQbMIOWDRFFXoN2uaA3oXmCNrAiNWHwuVhWe81v5Fl6jEO9t5xeqBMp0wRwD8lrtg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000005, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 15, 2023 at 06:17:31PM +0800, Yajun Deng wrote: > @@ -1176,8 +1175,8 @@ static void __page_check_anon_rmap(struct folio *folio, struct page *page, > */ > VM_BUG_ON_FOLIO(folio_anon_vma(folio)->root != vma->anon_vma->root, > folio); > - VM_BUG_ON_PAGE(page_to_pgoff(page) != linear_page_index(vma, address), > - page); > + VM_BUG_ON_FOLIO(folio_pgoff(folio) != linear_page_index(vma, address), > + folio); No, this is not equivalent. You haven't hit any problems testing it because you don't have large anonymous folios.