From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59299EE645B for ; Fri, 15 Sep 2023 13:03:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D83596B0367; Fri, 15 Sep 2023 09:03:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D34A76B0368; Fri, 15 Sep 2023 09:03:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BFC1C6B0369; Fri, 15 Sep 2023 09:03:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id AE80E6B0367 for ; Fri, 15 Sep 2023 09:03:39 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 7B20D14023D for ; Fri, 15 Sep 2023 13:03:39 +0000 (UTC) X-FDA: 81238848558.11.51B7F7D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf02.hostedemail.com (Postfix) with ESMTP id A24E580023 for ; Fri, 15 Sep 2023 13:03:37 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=flB8bG4g; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694783017; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZpfbgJ5FdmMlvqcljfZeMWdf6Pp3ie+fbXvpKVgnxSk=; b=dEfGxrDodq76OppzPJwG6qXeTgEvl6omXsfQuFnbnOlY63XqNaCo1ICTAJMDb7SGiFYO9G YZr9Y+35MK3z461YZ9896a2uoaQa5y8JgyMOYePDG0a52EIIM6mS7CW5EAcaVFAXY292xr sCJ4q6pE9bvHRSB2sUz8Bx5j7MOadr4= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=flB8bG4g; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694783017; a=rsa-sha256; cv=none; b=BjHQIyMkX7GDSQwRed+dXDryfJjadvjENtbNa0wJlde0b2M/Z18P1JzNBCAxPJalfExli+ y5512SsR903xbhZ1DiDbrjY2yssJ0bMmfAPf6l8/VBi2ehiL+sxCA5FM6b9bfqC6q4iViD cwvpo8pG+g1otB5eyXSPJHcvcIkAZuQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694783016; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZpfbgJ5FdmMlvqcljfZeMWdf6Pp3ie+fbXvpKVgnxSk=; b=flB8bG4gOD2sd4TA36L+Qt5hrLC/aeK73Y/RjiNbtniRFjCDqANAWeC8djYLEGsnAomqNT Ee501qlWolFJcn3RCzlw8FZFS37DL4yLfw9zahBTxMY3NY0Klc8rpgAJeCh6S4G6B1EsC7 W28BIjXvCF03kYDFj8d++hg8EDcsnM4= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-467-CFYeF0T8NXStZbVp2ZErcg-1; Fri, 15 Sep 2023 09:03:33 -0400 X-MC-Unique: CFYeF0T8NXStZbVp2ZErcg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BB87780A154; Fri, 15 Sep 2023 13:03:32 +0000 (UTC) Received: from localhost (unknown [10.72.113.71]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 16DDF1006B70; Fri, 15 Sep 2023 13:03:31 +0000 (UTC) Date: Fri, 15 Sep 2023 21:03:29 +0800 From: Baoquan He To: "Uladzislau Rezki (Sony)" Cc: linux-mm@kvack.org, Andrew Morton , LKML , Lorenzo Stoakes , Christoph Hellwig , Matthew Wilcox , "Liam R . Howlett" , Dave Chinner , "Paul E . McKenney" , Joel Fernandes , Oleksiy Avramchenko Subject: Re: [PATCH v2 9/9] mm: vmalloc: Set nr_nodes/node_size based on CPU-cores Message-ID: References: <20230829081142.3619-1-urezki@gmail.com> <20230829081142.3619-10-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230829081142.3619-10-urezki@gmail.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: A24E580023 X-Stat-Signature: 8ixsoodszownca3uohk5khwhr6mcqrux X-Rspam-User: X-HE-Tag: 1694783017-534378 X-HE-Meta: U2FsdGVkX18Uo2t5XkgOJlpB3M3cRRQeNZCgxIXOrI3oMZDZlOKbQ8phaY9ymwT0qFCrVwIPENLVuI5dUMiRGldmhMPrGFiCPjgLWhHN3xpYO3kzHhmk+JND/FFvVY/RTgt0iLDNx5FOSDd+cMUHsrGJbF0Gs7ikxOhVmCyTGECNmAZoFk2zZOykQe1BK0cB9ALqFATwrqsZSYWcnIZ5aUxaCW68A9uaJJsFacHJwDJQx4+ofHIJQK2XkDO6hidaNysKvWb7zIyeHXGBDRcArE/eckvBHEORmAGydTE5QamviBkbWmkQpU6EwqXrzcStnkzLz5rVSHIRyHILLkgZKIGcV6Ga7HE4yfWY4kJsbYscFHSykhlo8N8FOdT1goLheZcIx82Y43zV3AP+ickcJfgspLjBCZ8eXseGFDvXNEjwdM6hk9/wcZq9eLUPjVjxY6GyJwEars+LvTxYitisfSlfXIlOvzQ8ccxVVcKCR5oOv2sEGOF0nTQE3F0N+55fGJoi1jlG5JSIoSCkdmTmtO4qIcU2A+eQm+1LOYwUUDkqCz35UEv1cZ9fz+ls9TA0dv/WeHdgI/ltP1HEqQMh4VhHoUN0x/nJyctXSV3X1y4seGKuKRBHt1HEWCRu+bOnQ0QrSaMxaQ3FFo46aLgn3m6yyYYTmlA92NcpKigCHSZFNY1MP3GanZ47KXlkeU9wgebe7uH8KXBg7X9Xidwsv4rlNQtyUd0ALHdz7xVQaUnukvYkGZWML59y1p4f8Ko2AK9xG/FGR7dv1V1yuHWZGy3gkLBLiKKQtQIYNBATo6vRBt0o0Zi4eK4yCR0oysTug/+7HXSNZaZSb1Qrmt9AbopSzJBFrXKWUgu1X59xxBA/H4mW/8BuaK5isciQfQ//78tWb4/0J73cKY+0VaEL/yEa5D6Bw6u+Vt8HT40OzMrVddeeydYjpm/llm/GmM3T6nLp9kcbvbLkQlqNZbl 4qysnqum C8SzZ5kVEvyynwkZcirm5Z9W+ZMOp2ls5xhmVHexO/T0mmy5QwTmUmyGHGRChQ8CYDRiN6sXnldMDEgq1o+mLtGdd0+c6rU78pM3GHXgjmGN/GPA8cC+2pwh2fYnp2p4hG86uaFW6jfY3evGa/rpQfbFfY/K8SgIKT04Bd9H5jup+jMbZNVX9dTLpSIkY84UKpZwgLO0p1xYnQCRQOX5yPvhVy4Co9An828quSIDgXaWET4zDt6BJcJiYypHUtE6r8QAhqzF2hQLuMSsoQtVNifON38DntFGA54ReULVIgNFVej8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 08/29/23 at 10:11am, Uladzislau Rezki (Sony) wrote: ...... > real 1m28.382s > user 0m0.014s > sys 0m0.026s > urezki@pc638:~$ > > Signed-off-by: Uladzislau Rezki (Sony) > --- > mm/vmalloc.c | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) LGTM, Reviewed-by: Baoquan He > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 9cce012aecdb..08990f630c21 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -796,6 +796,9 @@ struct vmap_node { > atomic_t fill_in_progress; > }; > > +#define MAX_NODES U8_MAX > +#define MAX_NODE_SIZE SZ_4M > + > static struct vmap_node *nodes, snode; > static __read_mostly unsigned int nr_nodes = 1; > static __read_mostly unsigned int node_size = 1; > @@ -4803,11 +4806,24 @@ static void vmap_init_free_space(void) > } > } > > +static unsigned int calculate_nr_nodes(void) > +{ > + unsigned int nr_cpus; > + > + nr_cpus = num_present_cpus(); > + if (nr_cpus <= 1) > + nr_cpus = num_possible_cpus(); > + > + /* Density factor. Two users per a node. */ > + return clamp_t(unsigned int, nr_cpus >> 1, 1, MAX_NODES); > +} > + > static void vmap_init_nodes(void) > { > struct vmap_node *vn; > int i; > > + nr_nodes = calculate_nr_nodes(); > nodes = &snode; > > if (nr_nodes > 1) { > @@ -4830,6 +4846,16 @@ static void vmap_init_nodes(void) > INIT_LIST_HEAD(&vn->free.head); > spin_lock_init(&vn->free.lock); > } > + > + /* > + * Scale a node size to number of CPUs. Each power of two > + * value doubles a node size. A high-threshold limit is set > + * to 4M. > + */ > +#if BITS_PER_LONG == 64 > + if (nr_nodes > 1) > + node_size = min(SZ_64K << fls(num_possible_cpus()), SZ_4M); > +#endif > } > > void __init vmalloc_init(void) > -- > 2.30.2 >