From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCC8BCA0EF6 for ; Thu, 14 Sep 2023 12:48:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E9CE46B02B1; Thu, 14 Sep 2023 08:48:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E4BBE6B02B3; Thu, 14 Sep 2023 08:48:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D3A766B02B6; Thu, 14 Sep 2023 08:48:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C3E156B02B1 for ; Thu, 14 Sep 2023 08:48:45 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 9BA4480438 for ; Thu, 14 Sep 2023 12:48:45 +0000 (UTC) X-FDA: 81235182210.22.075D5AB Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf01.hostedemail.com (Postfix) with ESMTP id E3AF540005 for ; Thu, 14 Sep 2023 12:48:43 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=B0sCLfaz; spf=none (imf01.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694695724; a=rsa-sha256; cv=none; b=XcJ9tnfURFhjBCpK9eJQkjP/g19qNT/6jrFwMJ7i/E0OeEyFUm4rzi9WOol7fe8L4wD76p RsMGKac77IE7jrWotAFKKdWcrqKbqFYEQzgXLCa9AQRanI1TPhcMgouwiOqadhUgq1GMUQ I7/JE+W2MPMA4nnNfo9spvBCsKhi+yo= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=B0sCLfaz; spf=none (imf01.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694695724; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vjEMrjw2C/jTAB+E0NqGEn/Bqv/9rRmcZIO86x/4wRQ=; b=68i15LTZ5+MiaAMwXamJuW7Y6tempFgqKy6sfN++dh8+rZwBViZYeCpXSH5HYc8ZBVmQie ju9qsrGwA2qVRjU4rlTQnmTshjDbmMcybhtRA1wqbVoyw43XCzZtJ8zOm9ilAXxRqptsIA /7sqNVs78UX4qK66UNNhXke0y/u40+U= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=vjEMrjw2C/jTAB+E0NqGEn/Bqv/9rRmcZIO86x/4wRQ=; b=B0sCLfazPBAGsbEZeWcayfQbh5 uT0mKgzbqGikyzNOd3EyNLVgaNP6VulcWnXiG0IpVV8KYAauTyMc1A1MbG2depWPYn9cka8FXGrI7 T+ZyjN1s0WHkKas/U48Gzlm2+qBVklO5o3Kl6TUDiHfi1YVCDLHs4WzUOmxecQc2+d56onboyan1J eGCUD0ziAW3lpO2vEHS8BZ2lkwOVwN2YLWT5hVhohCdsloTDVFsDAQlA5mZ3GEJcqJIq2xPg8sepN tPbZX0eKcfLx3DElFYlUWqUNTb6YNkEf0e2XBHvKKoTMG1h8wo29JhMGsWwjOghsu/CR0+QCi4KXB XLUXP8+w==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qgllH-002y7n-2c; Thu, 14 Sep 2023 12:47:59 +0000 Date: Thu, 14 Sep 2023 13:47:59 +0100 From: Matthew Wilcox To: Mike Rapoport Cc: Sourav Panda , corbet@lwn.net, gregkh@linuxfoundation.org, rafael@kernel.org, akpm@linux-foundation.org, mike.kravetz@oracle.com, muchun.song@linux.dev, david@redhat.com, rdunlap@infradead.org, chenlinxuan@uniontech.com, yang.yang29@zte.com.cn, tomas.mudrunka@gmail.com, bhelgaas@google.com, ivan@cloudflare.com, pasha.tatashin@soleen.com, yosryahmed@google.com, hannes@cmpxchg.org, shakeelb@google.com, kirill.shutemov@linux.intel.com, wangkefeng.wang@huawei.com, adobriyan@gmail.com, vbabka@suse.cz, Liam.Howlett@oracle.com, surenb@google.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v1 1/1] mm: report per-page metadata information Message-ID: References: <20230913173000.4016218-1-souravpanda@google.com> <20230913173000.4016218-2-souravpanda@google.com> <20230913205125.GA3303@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230913205125.GA3303@kernel.org> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: E3AF540005 X-Stat-Signature: s5z77j7mzgafoenhsdns1upquydxfpjk X-Rspam-User: X-HE-Tag: 1694695723-158094 X-HE-Meta: U2FsdGVkX1/q61UOGxEc03rAXOmA+M1cescXPrO12NxyeJiXWqb8HnD80xJLcqpr9VS5vCm9nOGEK0Kuza+M4LCNCwJL8MzMnKsuHqaVamBHhkcjkISYmNaBUXv/Hfn51uNYsbN3oMiMWJGU/cV68WqcnaNpg92VQPIhVPYHNfuiJ3voYY8lH+1gqPFuPQrE7J+R7pjmN8+Wt1xeQ4Jb4PNoihyeHSrFvqjHdbCettoTymSqCfBnZowQErysBFKoQRlr///SmgB2TjvMWXmdcsHMQrsTkPiAA4nzLw3YpW2r3eLnmliIFfomH1gkyUAieB30STXTTeRb8cWG/lSn2V/OoOScVmoBs96AWgDimUPwuZzEtlibq3nB8+ToP8P0y63v9lFh/9c9jArMQZxBcESEpVtneTkX4aftV1PJMVqONtzHCzCnsj4Gm3PCLI/OBti/IXnt+4oR+hI29SFIqE0qfdnKY8rp180NNsPmhZx4R23eiJ0N9JBcbGPgrj0Y3HAYYIgkZqOtyFVKmeqtSyXW+IzgZBAbJPXdv/Rzs98Ll52UYZlQCCMdAuB+vu3J8cFaZxKlTksd8f+hRBIHJBgapOKaL/oitPgziXrmxbzs6hb5w5se8ycCFapFbr6GyxsRiI/JjB1ijJ7f9i80zptnbSpC4jJHmn4AX4646nizbmmZn57COhAjIxTK2Jnj2kWXSbbPUfFo8kBxo7N5FHTpmcGjd+ReGC24xrHNb4pkHqdY8lXx9ihihaLern5lWrz1KZBePNmdrHxDOrN1bU3oETJZGfESd9svC0QEYQpED5PLO8wMuHT9jizTY11YkyhYkwMFwedoTbLTPg0QtX04fsNdGjUhymTs0AbvJSxBmnk30RHgy0b2QpT30uKULCl8399DCq3dHq9TcwalzoZMLWAJthMIsG22sh/pw2MLCQqkuqjVZsDAMc4XhChOye/lmJQSXRt9giJ9y8p nTJA+Oc5 FbQa61rIsvEithWvbRpuQ1eatZxQw4BirSS8TkL9NQhSQs7MUycJC9O47moaVAfztTLpGBZp3HSEaeBcgAHp9k2lvEdq2AO/n8rJv/wkVjT0CcocHXZSgr/g3DBWH5NVJXewMC+ZkRdfUxiL9zubZs95Zq2p1FN7mRn3ou+G5+WNfRueFOvMOPgKd0Fdd75p52SFX/NU/U2f9iygHjs92/UZmLg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 13, 2023 at 11:51:25PM +0300, Mike Rapoport wrote: > > @@ -387,8 +390,12 @@ static int alloc_vmemmap_page_list(unsigned long start, unsigned long end, > > > > while (nr_pages--) { > > page = alloc_pages_node(nid, gfp_mask, 0); > > - if (!page) > > + if (!page) { > > goto out; > > + } else { > > + __mod_node_page_state(NODE_DATA(page_to_nid(page)), > > + NR_PAGE_METADATA, 1); > > We can update this once for nr_pages outside the loop, cannot we? Except that nr_pages is being used as the loop counter. Probably best to turn this into a normal (i = 0; i < nr_pages; i++) loop, and then we can do as you say. But this isn't a particularly interesting high-performance loop.