From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DCC8EDEC66 for ; Wed, 13 Sep 2023 14:32:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1D3C36B019A; Wed, 13 Sep 2023 10:32:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1838E6B019C; Wed, 13 Sep 2023 10:32:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 073296B019D; Wed, 13 Sep 2023 10:32:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E98246B019A for ; Wed, 13 Sep 2023 10:32:17 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id AC591C0E61 for ; Wed, 13 Sep 2023 14:32:17 +0000 (UTC) X-FDA: 81231814314.08.6FF2B3E Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf09.hostedemail.com (Postfix) with ESMTP id 93EAE14003D for ; Wed, 13 Sep 2023 14:32:15 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="H/IxsfNr"; dmarc=none; spf=none (imf09.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694615535; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pmWwPYKXVDejW5jO+e3W8gOpJicEZfd10euL8JNWonk=; b=bEgR3/1JXPgei/Azmk+2zZUFwF62gfeoqQUTa9mEKNffDEJh700MpaPfj2kun4ZBpYgzCX eC7ukih4ZHlLq75J312d+r3UsvW+fuh2SyKxPD2Saf8NgGZm0+adHxn/paTfVGOheQW+pX Vz5MY0BZC/s92S3kjvxpkjNQh4o5Xxw= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="H/IxsfNr"; dmarc=none; spf=none (imf09.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694615535; a=rsa-sha256; cv=none; b=ZNv4ltwVvEdkHf07kvcJh2gSfkR2Wm/fr2oAdeTwB8iBtqFJaWQ1dE7324zhcDYBTcUrvs dIP8EAI5QQSWnCzyEyDtBUqEGrgKzYlu3w4ci9MKb89M2V3xc1ptj9AwPvfHMD7alyEFL1 KkdZkLseVyYN8k0SucFB8l8x02zFOF4= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=pmWwPYKXVDejW5jO+e3W8gOpJicEZfd10euL8JNWonk=; b=H/IxsfNrNlGdxjmFpV8gc+rhaw MDCkmQWyYUqWMLF6RnsP7bK67giWpZYTgMo3MevG417JHBSZRrjyCBziiz5+bCcVfHCbrr0uR9nJg Ng0TOKZBDCa43h5oykjySIzAJfujqqN7UqBU5uiJWdwQ0Hw7F/OwBHhRawbo9FsGm9jMC0YBFyNw2 8XxAkvWJqrsn8UAZ7/50efL85e6wTmVvgIj25JGqq8VlN4q+88g1BcHICF8o+3DK1bVFNoxcv1ZGs nkj7Dm4OLwhQ6WuihbESO8rRW4CyKSmenXIj0SaJpYO6qpSTv2eKLubTt/31IkLU1HYMoNA8uMzeP iUqxfb2A==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qgQuX-00EMjK-C1; Wed, 13 Sep 2023 14:32:09 +0000 Date: Wed, 13 Sep 2023 15:32:09 +0100 From: Matthew Wilcox To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Mike Kravetz , Muchun Song Subject: Re: [PATCH v1 2/6] mm/rmap: move SetPageAnonExclusive out of __page_set_anon_rmap() Message-ID: References: <20230913125113.313322-1-david@redhat.com> <20230913125113.313322-3-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230913125113.313322-3-david@redhat.com> X-Rspamd-Queue-Id: 93EAE14003D X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: wq5so8cwyte3x6n9qhco7muqh5nqpmj3 X-HE-Tag: 1694615535-174380 X-HE-Meta: U2FsdGVkX184VGBBu0uXO5XKVQP/NLFbvbS4P1uh66uIZhANTq0Cez21pz1M2tSsd+NzdVGAO3dimmszBJ6HtnhZszpBtcCDeKgo5raIsmxWzmqkSka4OFNlD+axwA3ev558rTA74mtHvPdS2/OTLIXoJArCS2tfFgOMuQnXco8of1wyZ0r8gLRREcQAk/tNKxJaftcXJM/uQJmsI7+GxZgIb3grm5tFr73QZzU/rEmpkVk5RozQ6XehDbsYJmOL7X1UlPzqzR7SaxDtl3jRAtuTwcFGWI77ru523liUWxwpkV20z9YOStKWFdjTpOcTUmXQRSmn/+lmbTGT/fAH7MQ2QPq70AIfrb80n7DKcBNctOVNJwt2bCiQ5U/gwKCZFOC4pYIVlsNH3XBLwvo5bWCG7rAY72A965sY82UOYdhqUboKdPyI0uUP4zonEioESCBGVR5x70bm20Mo28wBOqadi8ExKO2n1qP/8HEsF2ef2aN9JFp5FiSerF5nIrqfDHHRx07FfZpjFQ9jRV1xRUB7ZjrxUBMeVTfiDUHZjNRyisHfFy3QKk9ZlbTJupvdr2/DT06NpQAbhUlTlwULegnsud0gAPuTvbzP81y+2vuuFnFtbLepbuv6RsQsOeD5j7k9tysa2QGWMtajLaTmNe4jfo1qaKh8EHYjBenzGnNkXTJekFz1IAopfVc1nIqJlkp5ltPyHHCdcL8fYDnY6jfRScg7rmXVPzvxFQXbOPwhUAjwdDUQ1bDkYBNhMTlrvgxBGPq6K1mA9I7+FUEVcD1g5ryJxWWD5kXirLQxg41WxWCYiyOYjoCvkaqUwQW6rDzz26gIG/gXhYzvQIp0UwA60aXH34lUpZoUekRTRJbAFXFT6tiT4gusPrq8BpaMK5hnCkDOPik7nu5Dy15fNdu4H5hKwVOxFs9dpNqgTTFTLGCfLp4N3H5ZwbP9iQj9aEM0OdIR52idO4BSMaK S8vYetzg DJ1raqYpNLuzc3QFcNQbL6RBG30E8antb2j2Ydd0RkOxnNiOg+3GhCJ4/wwQFhFqn4GvyUV+Kz7nAQaGYWXXxCaUspdxn/A/TPBJuIkAUpnFIx7dLW5WR3TwU6zAgO/RAGvRy1MhIUeEYw+/bhLbTkCnvYTdvyTcooVdf9HbNT4RnZOcHaI1MNTiNbF0mxr/kqW8HdpveWBZ9QY0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 13, 2023 at 02:51:09PM +0200, David Hildenbrand wrote: > @@ -1246,11 +1241,13 @@ void page_add_anon_rmap(struct page *page, struct vm_area_struct *vma, > > if (likely(!folio_test_ksm(folio))) { > if (first) > - __page_set_anon_rmap(folio, page, vma, address, > - !!(flags & RMAP_EXCLUSIVE)); > + __folio_set_anon(folio, vma, address, > + !!(flags & RMAP_EXCLUSIVE)); > else > __page_check_anon_rmap(folio, page, vma, address); > } > + if (flags & RMAP_EXCLUSIVE) > + SetPageAnonExclusive(page); Won't we end up setting AnonExclusive on ksm pages, or do we make sure to never pass RMAP_EXCLUSIVE for ksm pages? Maybe better to move these last two lines inside the previous test, just to avoid the question.