From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E33C5EE01FD for ; Wed, 13 Sep 2023 17:56:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5D09B6B0141; Wed, 13 Sep 2023 13:56:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 57FC06B028B; Wed, 13 Sep 2023 13:56:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 447A46B028C; Wed, 13 Sep 2023 13:56:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 28C6A6B0141 for ; Wed, 13 Sep 2023 13:56:50 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id F3625A0886 for ; Wed, 13 Sep 2023 17:56:49 +0000 (UTC) X-FDA: 81232329738.28.9EA7716 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf05.hostedemail.com (Postfix) with ESMTP id 91592100004 for ; Wed, 13 Sep 2023 17:56:47 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=QeAR9aJr; spf=none (imf05.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694627808; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=j6TR8SsaVNvXoZXM4p/X/ufLRTS7CLck9GylhLcr1pc=; b=eEEWxQaNPO2vypFAVB/xl3H/h/mpKyz8Wfw4dRQ38Bzu0eNyR2rcokHHjg34mGZkOlCbea UnDmCnhJYIiBI+JHVSrUgeBMMecS1jzvf+krh117NuW7uz2ANrzLypaUqQ3hOPL7otXAxA 4QL4a4iH8IhkdmaM6BDYr8rARoVdjlM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694627808; a=rsa-sha256; cv=none; b=orDNUjlU0sOuL3G30ljXKi/Lqvlv7kTYc/hFvCsnsv8TeDlfP68Bia0lB9/ir7h9Qymkt8 OhIQ0y+vhmWka/eFuXUU102UMMOdiYkQRLPA4gsRu7MIpKtLULdoxUrXgSB9GB1xYyhDQK PHuNHIIBvyaF6erRaHsHlCaT8Kbo3E4= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=QeAR9aJr; spf=none (imf05.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=j6TR8SsaVNvXoZXM4p/X/ufLRTS7CLck9GylhLcr1pc=; b=QeAR9aJryEAZJrtFCudhXKDxSz H5VXRj/oxyS2qFjva1YVKSyydJvO/mb6S6E89Zcl5M0wGSgx0a/Mr9Aes8l0gqhFXtfdLqSxBPpLz pY4zFybsnQ7KsMfP2uHON558nFCdGHpl53X5MKFQbDywZIytry2FDPvi/ynDYoqf+c3l6USNb4iiK X//XRYh2fRmoJF3Nl2BfH/LQQAoIaxF5skuRyXOVR5oW9cR2F4hGw/zdue20NPVABOZD1uhDUGNxx RgOlO3y1xYLFGel/VHJRUyWj3XDXt/jcrbC0VM9bfXWH80InfSRLuaHuZQ1Sjr7g9eyln5CaMyWyY pUii1Ipw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qgU5s-00FIt1-Ok; Wed, 13 Sep 2023 17:56:04 +0000 Date: Wed, 13 Sep 2023 18:56:04 +0100 From: Matthew Wilcox To: Sourav Panda Cc: corbet@lwn.net, gregkh@linuxfoundation.org, rafael@kernel.org, akpm@linux-foundation.org, mike.kravetz@oracle.com, muchun.song@linux.dev, rppt@kernel.org, david@redhat.com, rdunlap@infradead.org, chenlinxuan@uniontech.com, yang.yang29@zte.com.cn, tomas.mudrunka@gmail.com, bhelgaas@google.com, ivan@cloudflare.com, pasha.tatashin@soleen.com, yosryahmed@google.com, hannes@cmpxchg.org, shakeelb@google.com, kirill.shutemov@linux.intel.com, wangkefeng.wang@huawei.com, adobriyan@gmail.com, vbabka@suse.cz, Liam.Howlett@oracle.com, surenb@google.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v1 1/1] mm: report per-page metadata information Message-ID: References: <20230913173000.4016218-1-souravpanda@google.com> <20230913173000.4016218-2-souravpanda@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230913173000.4016218-2-souravpanda@google.com> X-Stat-Signature: wbfbki86zqw6pnytnjjggz4m5m5y7oun X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 91592100004 X-Rspam-User: X-HE-Tag: 1694627807-242231 X-HE-Meta: U2FsdGVkX1/Rk6vbk1x6xK5ma6m/ShNga9DGZROF6QeDBkN06nIniYPG6/2F9Y3xgV7q6CYweFT9DEe9kxEFG3LanFYS3wUYShmas1lq37orKOVcOJp4Z5UyoNW1PURBlaRYELHRBKaPazrHJMJaDU+5Zowv42c/NXnDuZm54VUy4VEQmpIAkZOp7+CpxcdvKf1MvTPhV9bEZb5NWckwpU6Y7sj0nU2pMfibrgP4UASpRElCtW9NDg+qzi/ZDLf4ScAu9TaR5HMHhP6X8l9QPuhj7W/N1TiFHpciDEVxVAJEqL5bQOumuIObWihBouqm2JO3E7mUGIFTYi1odaioV/104gX2g44rBxBxhl4f6/gYQSwQrlz4iwvUrQ/cwMdZDTWraM6n4eWSGFeeojyi9eVzSoH6H9xYHKkn9vcGTsJMswS0XOg5rXpro2BJv5zQf4RJPpPlp6YN9Fo7DfSIyJFcOXR5v8MYtoEwxxte8cSJhJSwkxPwOHPQQPZm9QA1c1B4XQn3k3D17/jC+Lc9nY5UdVXtb07cwiq8OiUaAHaeotStywdyFMZ1AoizcXSflO7mVCQVAXCd0fYg71SDfYDHBUfh2Q7tSf8WQuoYDb1gvc/g3twHuF/pmPH+AnvajmmDUVDZC/meKU4PSHkscBigjV1jezNd2YiKUfg2VhSXo1DkdOnwkq+MfFpxpe4DFGEwGXouxUfLi0tXCamYyfdOg9eaiy/uMmGHVHZUFrC/WwJqsoJNXUiVwHw3zxy/gOA0YAXlwwag94GX3zY3Z/RKQ5kP0Z1PU7gNRXPm56/ehCgVLUJt6+BQxUQSm6SfKiklkSti7k/VauBO3E1LRJ75B6K3QTRUCAWKEQwvyyWlzrIwkNMG8q+Tyf/cyx7ggiESYk/k3be0/a8BDt0HuqZokEQ+4OkjO6F39vsjylTC5CqqSPrZ1KKG79r2nLsdHN6D0A1gjsgJ0EDzhp2 NatwFyzw QS0WpYgmlUwIf4XH+ekjYnkd5BZuO1qCqebVUjeUADK6xb3Whqfxe7XDfRNRFS6OtlvERKhTlwEfW60vRc91gB1rGGLDYD+uYFlCKZwEaAmC8PFaATNdSs3rrUg4rpDp/LXKmezjFL9gHOSkQz1dzzzbhP/igQrB3MZtIS31PcWC/TEDMH8MgAm335v0nIsC5koa2sKX4P2QGFulCxxusxruVUQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 13, 2023 at 10:30:00AM -0700, Sourav Panda wrote: > @@ -387,8 +390,12 @@ static int alloc_vmemmap_page_list(unsigned long start, unsigned long end, > > while (nr_pages--) { > page = alloc_pages_node(nid, gfp_mask, 0); > - if (!page) > + if (!page) { > goto out; > + } else { > + __mod_node_page_state(NODE_DATA(page_to_nid(page)), > + NR_PAGE_METADATA, 1); > + } > list_add_tail(&page->lru, list); What a strange way of writing this. Why not simply: if (!page) goto out; + __mod_node_page_state(NODE_DATA(page_to_nid(page)), + NR_PAGE_METADATA, 1); list_add_tail(&page->lru, list); > @@ -314,6 +319,10 @@ static void free_page_ext(void *addr) > BUG_ON(PageReserved(page)); > kmemleak_free(addr); > free_pages_exact(addr, table_size); > + > + __mod_node_page_state(NODE_DATA(page_to_nid(page)), NR_PAGE_METADATA, > + (long)-1 * (PAGE_ALIGN(table_size) >> PAGE_SHIFT)); Why not spell that as "-1L"? And while I'm asking questions, why NODE_DATA(page_to_nid(page)) instead of page_pgdat(page)? > @@ -2274,4 +2275,24 @@ static int __init extfrag_debug_init(void) > } > > module_init(extfrag_debug_init); > + > +// Page metadata size (struct page and page_ext) in pages Don't use // comments. > +void __init writeout_early_perpage_metadata(void) "writeout" is something swap does. I'm sure this has a better name, though I can't think what it might be. > +{ > + int nid; > + struct pglist_data *pgdat; > + > + for_each_online_pgdat(pgdat) { > + nid = pgdat->node_id; > + __mod_node_page_state(NODE_DATA(nid), NR_PAGE_METADATA, > + early_perpage_metadata[nid]); > + } > +} > #endif > -- > 2.42.0.283.g2d96d420d3-goog >