From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5AA5CA0EF1 for ; Tue, 12 Sep 2023 16:05:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4C4166B011E; Tue, 12 Sep 2023 12:05:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 44D236B011F; Tue, 12 Sep 2023 12:05:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 279826B0120; Tue, 12 Sep 2023 12:05:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0E79D6B011E for ; Tue, 12 Sep 2023 12:05:00 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id D2E8F1201AB for ; Tue, 12 Sep 2023 16:04:59 +0000 (UTC) X-FDA: 81228419118.12.3372D64 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by imf15.hostedemail.com (Postfix) with ESMTP id 3A45EA0035 for ; Tue, 12 Sep 2023 16:04:54 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=RAXu1Ud2; dmarc=pass (policy=none) header.from=intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf15.hostedemail.com: domain of feng.tang@intel.com designates 134.134.136.20 as permitted sender) smtp.mailfrom=feng.tang@intel.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694534696; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xGUfwF8Rvld5EkVxrTFn+xu/qRjLlYTds9lTwwsOgII=; b=IVVibPeVgWQ8S084TSFPROLQr66NEwnpcI1ZGA3HInqf4iqwDMUK7mdIrvysxvCq9+57OY LhIAu1cXvmqzC5+UEIea7lNbcJ8PHGhkWjnl5E7IoUv3e2prgcFI6ASzg+BW5R3JJJXtCy 3ysXm4qxQlh61Cbk9kii3hxxsaKFvH4= ARC-Authentication-Results: i=2; imf15.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=RAXu1Ud2; dmarc=pass (policy=none) header.from=intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf15.hostedemail.com: domain of feng.tang@intel.com designates 134.134.136.20 as permitted sender) smtp.mailfrom=feng.tang@intel.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1694534696; a=rsa-sha256; cv=fail; b=iE02EsCFdJF/YsGJK4aFjI7gD692JsmrGGK1csv3ywCfFzjQ5W3jcwK6bV51DhnzFTZe0J 60qXcJIGcVxlx02KOnzLOZd600VwSzbXTzHllTnW2onO4CaIwMcfV8ufNhFhDwp9tp/ACP E31FShkPSp1n8vh9DDXyaWghUfXlU6s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1694534695; x=1726070695; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=bUpqw5xzN+qkrhOAfG6rSYbYHPtyG2PShuGLDlguTTM=; b=RAXu1Ud2iUQDODKxEkxsgzBzPwL9/a8se/7KNQd40OExZ3UYgY2PqzV4 gcRSDtgEO4HBGYI9FRaMTqvPfczp+QyIGpT6YvsQ/58b3aCeps0IQhnEK e36uwrwh4ynZEN31TgmcbWUSttgx+qwlsG1yYuEDlQARyu/0ADFn0rIi1 Sas+u3Nfyr6xWWb3jR+fpLw0voOmPk12ez5HwzhEeLhudSafsiPHiRcRa 8HsSvlL/E1rP18X5aNdgGrtri42jw2MBZyhx4+8uwZPxg2wm4OWls1thG 1Ikeng2PrTAOHKDLe1fubHOki3Jd7ybqwKv2P8YTnzInVJzs9+VK4p8Sp Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10831"; a="368681850" X-IronPort-AV: E=Sophos;i="6.02,139,1688454000"; d="scan'208";a="368681850" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Sep 2023 09:01:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10831"; a="773088837" X-IronPort-AV: E=Sophos;i="6.02,139,1688454000"; d="scan'208";a="773088837" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga008.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 12 Sep 2023 09:01:45 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Tue, 12 Sep 2023 09:01:45 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Tue, 12 Sep 2023 09:01:45 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Tue, 12 Sep 2023 09:01:45 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.48) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Tue, 12 Sep 2023 09:01:44 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LpCLyPRznQ5tzepugqLMRjQ2u5Wp2VxX8HPcXfC2ViJf0ZrIsHiYcitF1g53N/WRRQ1HZNGpgxpCL4oqg8VAipmz/dTrU94rVJsGruvVcbP7s1uqGRjvt/kCexCIxdWSQhHV9N0/vGM0KwRzQdLVIzZruauyaUsgVCI3BRDdHh5U7CpjwjOxw8GwyGKlhdmTihaXxdUsEuOUW2qjerAv5AuBiZskGg4u0wkNKpp+jEzs13zwHpniUxLLALhKKZjkET9FolbLoOpkwWHbtb9+SJsIgFTWGgF5nvkvcUL0a4lEuh3xGkApGLIfTckNYwrJVOpP70Fz+GkzMjOijHIUiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xGUfwF8Rvld5EkVxrTFn+xu/qRjLlYTds9lTwwsOgII=; b=WFgOgQ4Xncq9srACMVLkmpOa5SmcmIpfxsTp9OAKdoEIH83cGLyR7VwDbeplQoEfbk3XuLGKctq2pj5mjiMNRhU63JsN288CDqMzQJCXgVKln9+SWf+jawbTh0QhwM9aLZSFfZI/wdSCitLXPluhj8GwCGPTNbWdOmHIti5VUnSnL6aEiGhm5KZVkhhzzuO5mk7N3pl4SiEGRetTzdlTuebVYM6nrwpOPToib87ITX9lmkRdRX1+beVGAu5VoaVUU1kMQRhMOAtxiVuhu/b7ZPRlgEz5/nrxMlgc/sBljQp+IV/DypUzzL5mEpo+CiMRvzlLU7Zeywz6Pf1kqIrhZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN0PR11MB6304.namprd11.prod.outlook.com (2603:10b6:208:3c0::7) by CY5PR11MB6234.namprd11.prod.outlook.com (2603:10b6:930:25::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6768.30; Tue, 12 Sep 2023 16:01:42 +0000 Received: from MN0PR11MB6304.namprd11.prod.outlook.com ([fe80::488d:7cde:d174:b775]) by MN0PR11MB6304.namprd11.prod.outlook.com ([fe80::488d:7cde:d174:b775%6]) with mapi id 15.20.6745.030; Tue, 12 Sep 2023 16:01:41 +0000 Date: Tue, 12 Sep 2023 23:52:09 +0800 From: Feng Tang To: Hyeonggon Yoo <42.hyeyoo@gmail.com> CC: Vlastimil Babka , Andrew Morton , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Roman Gushchin , , Subject: Re: [RFC Patch 1/3] mm/slub: increase the maximum slab order to 4 for big systems Message-ID: References: <20230905141348.32946-1-feng.tang@intel.com> <20230905141348.32946-2-feng.tang@intel.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: SGAP274CA0009.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b6::21) To MN0PR11MB6304.namprd11.prod.outlook.com (2603:10b6:208:3c0::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN0PR11MB6304:EE_|CY5PR11MB6234:EE_ X-MS-Office365-Filtering-Correlation-Id: 233ea5e0-ae82-4201-e819-08dbb3a98dfb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ijlYlX/1suc9loeKyGgrfUKO6tfHFH14/Bc5O2KIqdC/9azJetClvYDobmtvmqrt9zCAPnZVdPASIaqQaIFN1BnK7oLphrJd/3hEzsT0HcSOoW4gpP0445LVETifHzdjemO+ZqedEU8HYJIBCsPOD7SmlCj59hI7XnkBNxbl/TPv36DDpRjWUZGZ71b5J5lW/oO61l3iTD2iaswu0JvQVzGPbMIT+HAvZdfNcGY1Ko/lGWP9l171mKlLkTc6ag4Dm3HFavljcne6DqVi7JoihOe9gBXMkQp4DgJWxw22nOoQccr4xpjyvw6vycdFPYxppn537DKN6cPV8SSW0790tbaqTwQQn/RyWMRTAzqPAXcnE6Sr0UN+U1PF3EvG8srjSO1/ZBvukWpD/vS0kxwgn9gpNO2C8DGagJwsRo523VGrRNU/blz0plQxkvnnMzMK9s+i5lvNVXgPT5he/yMMSC+D3NKExTmmqG1O4tyUbpslESNsIuFcC+sPcCqOoWx1Vq9HP8uNpkJeP6fqu1UjERo2JkEbLrqv2zbklO7baKw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN0PR11MB6304.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(7916004)(366004)(136003)(346002)(376002)(39860400002)(396003)(451199024)(1800799009)(186009)(4326008)(82960400001)(6666004)(6486002)(53546011)(6506007)(33716001)(86362001)(38100700002)(478600001)(2906002)(8936002)(83380400001)(9686003)(6512007)(966005)(8676002)(7416002)(316002)(26005)(5660300002)(6916009)(41300700001)(66476007)(66556008)(66946007)(54906003)(44832011);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UUhReWlyQUZ6NmN1QThnSFlPOXhZKzd1ZnR5c3dadDhJVkdpY1JYQU1rR1dR?= =?utf-8?B?dFIzM3FiSkx2cG01bmN3UU1SYWtOVjNXdkorM01JaTNpQW5XWHJrU1B5Rjhh?= =?utf-8?B?Q1Z4RTBaM2xnWHRpdW81MlFZb0pkKzhuNHVOc0hoUnRvaW9TZzNEcGJnbHhB?= =?utf-8?B?MFhPbC9HUzdZS1J1R1cvTWkvZkpleHhKYTBYR0lkOCtCUzhsOUZYTWNlcXZu?= =?utf-8?B?TXFjL1J2Z1p6ajdrc0xHQ1hTeGNFWUp0WmR6LzJZTnBJd1RtZzZ5cFFKemRK?= =?utf-8?B?cE1FUW9uSStlSkU2NXdvbHdMbzYwNWh5b3JITnJPRHdhZ0tYeSs0N25vWTJD?= =?utf-8?B?NFdRUi8vT3h4QjhCYi8xeEpnYnRVVUxub0xVbHhPUDRuTVUxdGo0dUs1dUN4?= =?utf-8?B?VnJMWkQzSTBsaU1iWjNKOXBaaWdORERCbTRrcGtjUDdZaWlOS0RvN1ZjQWpV?= =?utf-8?B?QUs2aXB2MitYMGtzeVREOGNySVZCNUl6c0QzeTU3ZFhXVVdoclBFb0RsUFdo?= =?utf-8?B?SURzVHNxbGtwNVNxTGl1d0NYUHRrRHRRNWV3WWJzQXBhMFovUEcwcHZrTHVU?= =?utf-8?B?SHBzMytMcGs1d0k4bGdseEM2VWpYS2JQUFh0UmZ3ZlNybngremZWOUlFa3hv?= =?utf-8?B?bkQydTFwbTJnVlQ3Nm51RUNRdVkvcnVWTmVOWjFBTXVTazZWVUZwQkxRWDFk?= =?utf-8?B?a2hwcG9sQWhvWjBnTldkL24rcU9SSnA4dFdUU0NSQmozQnJIWU1mcEx4cU1l?= =?utf-8?B?alYyYTd4aGpGRkFRTVlsRGZnR2NEbnp2Vlk4UGZDRlRhaGpWekxpQ1VHUDJQ?= =?utf-8?B?b3VkYzg0d3FNa2pwRmF0UjJsa08wSVRjT0MyMUNWMTZteVM0WHp1dXhTeGYw?= =?utf-8?B?cVVhZ1ljQ2xMMnZxWFpHWFdXUUdKcGVtc0szVzdPYmo0UDdpWW1kWjBnTDJJ?= =?utf-8?B?UjBScVF1UHY0TDcyMVd5dW9TL3l0ZE8vOXVPWGtBNVllTEhlRFQ5RFJYSVJX?= =?utf-8?B?YldQaStRY21kYm9wNzRPdVhtREhjeWpUTzB0WGQvd3pMNEFEZnpwM3laa0d4?= =?utf-8?B?QjVWSEo5cDAydkYxWkY3NDB3SXEyZ0ZYbkZ0d3F0V21KUnl4eGRtY2Jrei9R?= =?utf-8?B?RzArNkdjR1ArTXJ0aHFsa2NoK2Q3TXNaSkZFOHIyYytla0FYYzRrdGFlanha?= =?utf-8?B?NWNUcmluWkpsTzk1YlJkV3VPWk1SMXBTTkxoWVcyNk9rWDRGaDNFeUNHb3M5?= =?utf-8?B?T1I0RzhhSisrajVPVFdYajQzT1N5ZnpYRzNMQThGb3FtNEtJQ0g0YlJ0RUxX?= =?utf-8?B?bDcybHFIU29VcWhpTWM5QnplbFpINzdjOGgwc0RnQXZsY0ViOWZQM25QQUo0?= =?utf-8?B?OW1QR2xGOVlEbk5MS3I4R0xHV3BtRDhscVFYbGJFVjhmUEV4WXZzS3dhRGxo?= =?utf-8?B?TUVGR0NxdUtHUllscE5DNWJ1TlFZNFR0L001eW9jOUZFeG9KVXdiV0krMDd1?= =?utf-8?B?YU40eG1LWjBYUGx4K2YvNmxCRnBVdis3K29kRVJHMG0xY0xHS2dsQVJTbElm?= =?utf-8?B?WC9lak5kbjc4aDRqRHgrbFoxS0dPdkplbFV2VzNvajIvZit6QkNBTDBzd3pp?= =?utf-8?B?Z0VFdmN4R2xQSU9lcXo1dDBQQVBPdnlvUzBNUVdyTTlZY0NpMHY5WVJCdWdT?= =?utf-8?B?ZnA5ZHJNeXRield2UTBCZnAxVjY2alN3emQ1OHNRMktCNTJrUU9hSCs1bHh5?= =?utf-8?B?K3ZGallwcHQ2VXcxV1ZNWndPbmQ1cDJwYklHSWZ0bjFSUE5mVjRSQ1I1YTZX?= =?utf-8?B?UVAxdVBvUEZCYnpvY2d0dUo2VFhuMnVObVZIOW1RSE1paXczY1FZUis0THZv?= =?utf-8?B?R2o3dlNsaGFpU29SVUllaUpNNHpGQkxsUkw4WDNCSUEwbkcrYnR5ZTJXenRk?= =?utf-8?B?SGJDR0ttd1IrTWNJOEdFNnMrL0k5RkFhK1VPQk9KQWUxNG82OTdWWThYUkNG?= =?utf-8?B?eUJnaE1xVnNRZTR3eEwvdTVPQTF6bVlpbmJ0YTVIb1Vzay9FWE10aWZTeFB5?= =?utf-8?B?aFZyL0hpL0Fya1pwWUEwYkdTZUF1SFdvV2pDaEhQS2hsdzlqQ3lCWTBEeUR0?= =?utf-8?Q?OM0boFe5FFBOR21mjuwXXwfgW?= X-MS-Exchange-CrossTenant-Network-Message-Id: 233ea5e0-ae82-4201-e819-08dbb3a98dfb X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6304.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2023 16:01:41.9085 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: y1k6cajq2V0vYDGPeFK5L3g1ubTLyD34MCj88mfioPR944yrtIT5z3DqDijap0k5sAoRIBPc7jP5hO3ljfOuwg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6234 X-OriginatorOrg: intel.com X-Rspamd-Queue-Id: 3A45EA0035 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: d81xas3mmgukbrnj6gh6fndypebjrokm X-HE-Tag: 1694534694-931693 X-HE-Meta: U2FsdGVkX1+ab8/k1dlLjUneyEIqiONhScDURKz8UkOIl6zdfzA8s4+vL/oon1zVL0+gW8P1fBvQJJigZoxMm0EpBWzEg9oz8cGyJYm0KPKLrjavAdwPR2zvGfOB4g07IL+/Qr+eUif94XzKxVdMIk50pJiUUzKgx/a9xIN5DCtuyufrBISbSs88Og8iysw33VFOcIV1VDEOyFiUKrS/FKcBjBxaAZLDuh4YOZptXxo59f+5lLNlMfwS028Ui2qUC6h87BsFsUf81oMQRUX64MOzFg9QFTF0Uw+ou1YNfgPCAVYqr5cBhmkrwpFkdlYsNdtwGScr5/YKi5HrYNmf/kSPqh5H8ES9LSwXgvtFVMBdoWNRX2/S6q2ZB5dZ4n7J0xr4K1n9BnyYmtlOsb/BViZbZ8DZVbiAkOlBAELipz1juZKAWlQLWDYo8hz7UNAoIoAUKdogBiDEjmqPGys0jO43e45QZ458Gu7HZwNMzxK3wE4SR7Tl+JfMPehV6NYReb58kxMGYPK2WMphFDI9WpQsL6+mMkhSSK0WYOPBBgS09ay8JAZy0xCGon+BTHQ87g4zOCdXZPtChQwXnhyAOD9YyM61Ox6jOawnwzr3FlfpsrTPpeAa7goyBfJ26uCZL+dRswQb1pbgnwBQBcQ1GHplCcBt6LhbNvF2qw9dz8OixUOgE0PYD+98UlIlhx/z7GEHGZEcJYc76OZPg2Bg2tDp3rJlxTAz3dY7ewqMeZALq2bZywiFjXj+Ulh7NFzmKxNQJMbtLd+fO2bB53GmshuN+WztSN9uWFAPi6DswzDUFbPduV1ychVDAHq4+yQ1iUQl6YGcuaZZ3N+hOH2tLIssjr0SBHDu6rCOaP+6hlaZz1U7Vt/TXfC1xOR3iEANeDA8JItGUsrOI65Nf6aINPzM8ThALUu1SljrbX44mcU3kYWBln+4duaCAuIueteJsUcGpLDCsmSKtjxX8Io HPGg5Vqm yJ9p3M4kRWWq8KmGIraokRMk6REbvke9zzknP28K2tbSOAJtJbf8JEgwLXYWafYriqzkSDQtR97Wti4DfI41cwleclrlGdOdw3xjVkQOz/1fB7pJrwJTw+wAVPBEgkhrwslVICbo99l2aXfbFH23POBd2FyFpjeJxfPeEJbEJIk9YPI+QZgY2x8Euhr+SoEAA/NtJ5b1LWyebSkKLymbveLrzBXO8xWE7xvoOqkON1RN9fF+nbLaW1Vuztu9cO0XBLboAGWlEN46FrXM5hqV+KnLOTNjmP9dAiRU30CQmOH3kunUiBZH9tcJcq4I6809qVJKOwL2Kob20j+UbIOrWw2zPv6/nuRb1i+driMSrqMrwAHyaDUI9PGIUtUq9PiZdgel5cDn51vRoIRCp3e8pV8G7ltKPWLtdl6iGUkvweoGzeqkDXHarj0Ljy/nsXTkxSl8LqpsXYdxfuFbrMod53zPO5gO1AwpBoMlhoPmA0Wx4kEdxf4UI/mEt1w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Hyeonggon, Many thanks for the review! On Tue, Sep 12, 2023 at 01:52:19PM +0900, Hyeonggon Yoo wrote: > On Tue, Sep 5, 2023 at 11:07 PM Feng Tang wrote: > > > > There are reports about severe lock contention for slub's per-node > > 'list_lock' in 'hackbench' test, [1][2], on server systems. And > > similar contention is also seen when running 'mmap1' case of > > will-it-scale on big systems. As the trend is one processor (socket) > > will have more and more CPUs (100+, 200+), the contention could be > > much more severe and becomes a scalability issue. > > > > One way to help reducing the contention is to increase the maximum > > slab order from 3 to 4, for big systems. > > Hello Feng, > > Increasing order with a higher number of CPUs (and so with more > memory) makes sense to me. > IIUC the contention here becomes worse when the number of slabs > increases, so it makes sense to > decrease the number of slabs by increasing order. > > By the way, my silly question here is: > In the first place, is it worth taking 1/2 of s->cpu_partial_slabs in > the slowpath when slab is frequently used? > wouldn't the cpu partial slab list be re-filled again by free if free > operations are frequently performed? My understanding is the contention is related to the number of objects for each cpu (the current slab and on the per-cpu partial list), if it's easier to be used up, then the per-node lock will be contended. This patch increase the order (I should have also considered the CPU number), while keeping the per-cpu partial numbers unchanged, as it doubles the 'nr_objects' in set_cpu_partial(). But the 2/3 patch only increases the per-cpu partial number, and keeps the order unchanged. From the performance data in cover letter, 1/3 and 2/3 can individually reduce the contention for will-it-scale/mmap1, as they both increase the available per-cpu object numbers. > > > Unconditionally increasing the order could bring trouble to client > > devices with very limited size of memory, which may care more about > > memory footprint, also allocating order 4 page could be harder under > > memory pressure. So the increase will only be done for big systems > > like servers, which usually are equipped with plenty of memory and > > easier to hit lock contention issues. > > Also, does it make sense not to increase the order when PAGE_SIZE > 4096? Good point! Some other discussion on mm list earlier this week also reminded me that there are ARCHs supporting bigger pages like 64KB, and these patches needs to consider more about it. > > Following is some performance data: > > > > will-it-scale/mmap1 > > ------------------- > > Run will-it-scale benchmark's 'mmap1' test case on a 2 socket Sapphire > > Rapids server (112 cores / 224 threads) with 256 GB DRAM, run 3 > > configurations with parallel test threads of 25%, 50% and 100% of > > number of CPUs, and the data is (base is vanilla v6.5 kernel): > > > > base base+patch > > wis-mmap1-25% 223670 +33.3% 298205 per_process_ops > > wis-mmap1-50% 186020 +51.8% 282383 per_process_ops > > wis-mmap1-100% 89200 +65.0% 147139 per_process_ops > > > > Take the perf-profile comparasion of 50% test case, the lock contention > > is greatly reduced: > > > > 43.80 -30.8 13.04 pp.self.native_queued_spin_lock_slowpath > > 0.85 -0.2 0.65 pp.self.___slab_alloc > > 0.41 -0.1 0.27 pp.self.__unfreeze_partials > > 0.20 ± 2% -0.1 0.12 ± 4% pp.self.get_any_partial > > > > hackbench > > --------- > > > > Run same hackbench testcase mentioned in [1], use same HW/SW as will-it-scale: > > > > base base+patch > > hackbench 759951 +10.5% 839601 hackbench.throughput > > > > perf-profile diff: > > 22.20 ± 3% -15.2 7.05 pp.self.native_queued_spin_lock_slowpath > > 0.82 -0.2 0.59 pp.self.___slab_alloc > > 0.33 -0.2 0.13 pp.self.__unfreeze_partials > > > > [1]. https://lore.kernel.org/all/202307172140.3b34825a-oliver.sang@intel.com/ > > [2]. ttps://lore.kernel.org/lkml/ZORaUsd+So+tnyMV@chenyu5-mobl2/ > > Signed-off-by: Feng Tang > > > --- > > mm/slub.c | 51 ++++++++++++++++++++++++++++++++++++++------------- > > 1 file changed, 38 insertions(+), 13 deletions(-) > > > > diff --git a/mm/slub.c b/mm/slub.c > > index f7940048138c..09ae1ed642b7 100644 > > --- a/mm/slub.c > > +++ b/mm/slub.c > > @@ -4081,7 +4081,7 @@ EXPORT_SYMBOL(kmem_cache_alloc_bulk); > > */ > > static unsigned int slub_min_order; > > static unsigned int slub_max_order = > > - IS_ENABLED(CONFIG_SLUB_TINY) ? 1 : PAGE_ALLOC_COSTLY_ORDER; > > + IS_ENABLED(CONFIG_SLUB_TINY) ? 1 : 4; > > static unsigned int slub_min_objects; > > > > /* > > @@ -4134,6 +4134,26 @@ static inline unsigned int calc_slab_order(unsigned int size, > > return order; > > } >