From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA02DCA0EC3 for ; Tue, 12 Sep 2023 12:28:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E33476B00E0; Tue, 12 Sep 2023 08:28:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DE3B06B00E1; Tue, 12 Sep 2023 08:28:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CAB656B00E2; Tue, 12 Sep 2023 08:28:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id BD1636B00E0 for ; Tue, 12 Sep 2023 08:28:22 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 8B82BA0251 for ; Tue, 12 Sep 2023 12:28:22 +0000 (UTC) X-FDA: 81227873244.07.33E714E Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf23.hostedemail.com (Postfix) with ESMTP id E1A28140022 for ; Tue, 12 Sep 2023 12:28:20 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=erCwDK5d; spf=none (imf23.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694521701; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Z8ryHLZvoZYaYVMPT2DZpm/JtTShBG1m5lfT41YyXTQ=; b=URB9Nw7dmcuJq66DwxdxcNKICGmhzlLtdHtGTT+uK1HxDEIskCRvAEqjfTLNwafd5FID1R EK5cTYAJ1TDhI+dki+/SKHtdWeuz0XOo0m6202FjUwP/iqoXSCmaUORv2o4wkeMlP7h6Eq Y2PJkVha8vDtx3DWWYcVnzhUt5iMxC4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694521701; a=rsa-sha256; cv=none; b=oS+Wcid8tgB0KPJ1T/ew8Aa9BTJi5wedU8CJeAgcN/Imrg/2Z3QAP5zJ2rdHOL9Z6hKtLq MNVckEzveZjvTfviXc3KSxqTgdMdGAcSO7zv06bFknhzg7SXGy1ERRlevOpzXeVIvVl2s5 3Th9OPLGOx0OwlJvuGGfPrr6I+xpn6Q= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=erCwDK5d; spf=none (imf23.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Z8ryHLZvoZYaYVMPT2DZpm/JtTShBG1m5lfT41YyXTQ=; b=erCwDK5dpDueftgDg08gml1I+V arhJrULil/JMQj5sB6V10l8iCXZXlF9ROkiDC1IHUDqRQb9g6npPOA3odnUB63pKKOx8f/Nqg8l5B D8Q1uV4eaZZ6/ezbZli7/EAoFBJD3Ym4nEG6GeajOmsXjPq8Qy8voPKW8Xn5zGeX1iOH6JV2crvEW B5k5hZIYgGfbAn+N/U1rqxv3FZDaf5SmnRNet1nSakFLg6pO4OIS8xa+n/w3kd9TPYfxcfUkMVOCm E518FlHYGY2p91T32c1IK/eu51UlMjjKTA0j8QZZGCu8gr+eWNJR6VCSFtby7tyViqiF5nFGw8y0z qGweLZBw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qg2V3-007XrA-8B; Tue, 12 Sep 2023 12:28:13 +0000 Date: Tue, 12 Sep 2023 13:28:13 +0100 From: Matthew Wilcox To: Peter Zijlstra Cc: Dave Chinner , Waiman Long , Ingo Molnar , Will Deacon , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Chandan Babu R , "Darrick J . Wong" , linux-xfs@vger.kernel.org Subject: Re: [PATCH 1/5] locking: Add rwsem_is_write_locked() Message-ID: References: <20230907193838.GB14243@noisy.programming.kicks-ass.net> <20230908104434.GB24372@noisy.programming.kicks-ass.net> <70d89bf4-708b-f131-f90e-5250b6804d48@redhat.com> <20230912090342.GC35261@noisy.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230912090342.GC35261@noisy.programming.kicks-ass.net> X-Rspamd-Queue-Id: E1A28140022 X-Rspam-User: X-Stat-Signature: xdjuefrgpy43zsj4af4e6q85i9mfpsmj X-Rspamd-Server: rspam03 X-HE-Tag: 1694521700-977887 X-HE-Meta: U2FsdGVkX1+ZRKS1seJgVdMZRLpyfE+CbcZ4vw+JzSAMPf0OF4HsK8f3hajFyzqS3iojn7PSTMp4BZeRsDpGZCtBMGmJ17kuBkEcTUNCEKxTptA//6uEUoysN4zCabu8FLk09Iv/FfxzQmfMGo2sAMra5OQvijEaXDStuTihTDSc39+bTK2KvNkp04XqwfZBb4avXlBDE5cMq/fTPYilG7Os+lQ0ACnmv14m3adQlsgdEguV/cT2mRCAxvleLMEZCMRHMvy71qODMLC/40EBKWZ4Dlkzjsm/khl1rDLnFwiZ3yVtHDEWTZDUtr0R9BClbJkX8mgmqEvkKE9VYy3VT5RSyRH3G9WQSsLIg6ZIySGbJYQ+wL75CQWbx24Dev5QV/EQCgxqpEY3f67g/clyEtajxwQ5r8bheY8YQc/D5WTQrwB0+C4g56Y28PpFhbPzZZLq8A2lrwGUp/RyP77adtEaaicfpfzjvk/zyHKDYpZuPWS94Zsl6TozsHxkFznQQ4CMjL5fzF9FJKexgVN1/xesneleO/VG31b7EQfCv5OakanKu1MpsHGHcOrgszMVEClbQlGoo6QxwUb/W0+9JhQucnn28RfhyF1JQjakFbR7uP+9DyYCgTCckuRnjhFe2zRHEwo14YHTiCc51MBOaXir3c+Z3TAeGEgBgct7Na4CTE+l0gL4fbR+dxi9IRM8erzp4Ekp88STaJbaDjCe771nEs95q8+1u0j/DktEV6fCf26JlIDSP/LazbZ3cPXc8qK/P0eVTCoSH75trm+OKLlt3g563k7vZg37MofMuu+l65FFvNBkKq8f7n/Z9cOTqdqbH5bINfmFlATbcF6Pb3DEjor1UwO8AU6Q/Vx9AytWOl7WD9TtXsrf0DG5NxyTv+e8jhXxWs1NeDmJCDChmCdOsRZoRNjkyWKI47nPH2lK5kYlWtsG8Ba2tFDA2op326MKG1N0fHqn6jWK0Ak pd0cx6Y5 3SnNuFKlpTve8GoV52Fg2XQkesRg9hxRab8fOy8xRQdBcd9OEOb6WV+N64g2Lc5w5sE4z3Tx8vthhogmKLdocy3EtoYWF7qC081sFgxnWOTdZbyd2Lib5f/mVpIqqHqMAdSJyqXcfitpOa3WdQ3GbiLxS3AQwnxun/a+aObXDaXA0sXjdkWmRjzvGkQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Sep 12, 2023 at 11:03:42AM +0200, Peter Zijlstra wrote: > If not, then sure we can do this; it's not like I managed to get rid of > muteX_is_locked() -- and I actually tried at some point :/ > > And just now I grepped for it, and look what I find: > > drivers/hid/hid-nintendo.c: if (unlikely(mutex_is_locked(&ctlr->output_mutex))) { > drivers/nvdimm/btt.c: if (mutex_is_locked(&arena->err_lock) > > And there's more :-( Are these actually abuse? I looked at these two, and they both seem to be asking "Does somebody else currently have this mutex?" rather than "Do I have this mutex?".