From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 821D6CA0ECA for ; Tue, 12 Sep 2023 11:03:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C996D6B00D5; Tue, 12 Sep 2023 07:03:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C220D6B00D6; Tue, 12 Sep 2023 07:03:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AC3356B00D8; Tue, 12 Sep 2023 07:03:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 99E0E6B00D5 for ; Tue, 12 Sep 2023 07:03:05 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 5AF83A0E49 for ; Tue, 12 Sep 2023 11:03:05 +0000 (UTC) X-FDA: 81227658330.13.7E3BE0B Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf25.hostedemail.com (Postfix) with ESMTP id 7A753A0037 for ; Tue, 12 Sep 2023 11:03:03 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=QtRF3jYd; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf25.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694516583; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2ueVFGBowAWqGipfNQqUaUPs7n50soYsOXj5+ijJC44=; b=q5vv665JUQ4R5lybhB43hRR4ARg6c5cJtUW7XrY/CPVYuj/IiAawwiV4I6No24uKnGz952 HzjE3VOA+4vjSJqsPocUYXtsOXFtM9wFazRWb1zLwAcVeQUH/9B8rKr1synSsDqqiOBpJe EhJgdU6Tmp7XWowbnz4oYHvW575NbAE= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=QtRF3jYd; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf25.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694516583; a=rsa-sha256; cv=none; b=dN+htge1SAP47hQwSrASP9LeSNc4wMnV25qBqiVsuboo35vEB4rQkIW+QKWkTK9LdZ41yO vg8by+v5IOVI1doABtxJolhgR9fswwfNBDMqAlQreXAsF8SMsEbLYNFn3njgNJGLFmnuhV 3StuBpeqXMYTWXiPj050wptMAQhtf5Y= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 33DFD212AE; Tue, 12 Sep 2023 11:03:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1694516581; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2ueVFGBowAWqGipfNQqUaUPs7n50soYsOXj5+ijJC44=; b=QtRF3jYdgfuACICva/StORZig/bbcCipPnzhVC2F+GBibpItfwEZroTW4ipaKaDUcEYrci CIdZ6hWQ6nZI17dJMYDjydq7tl5/V9H1nOPckllPAQlAkuUNPxXzDulaN8ZBxrsOXiLp91 A+MUbTATQKvgsJiK3kpJGdkLyxR3GwQ= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 24CF313A39; Tue, 12 Sep 2023 11:03:01 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id UHFZCGVFAGX9ZwAAMHmgww (envelope-from ); Tue, 12 Sep 2023 11:03:01 +0000 Date: Tue, 12 Sep 2023 13:03:00 +0200 From: Michal Hocko To: Tejun Heo Cc: Wei Xu , Yosry Ahmed , Andrew Morton , Johannes Weiner , Roman Gushchin , Shakeel Butt , Muchun Song , Ivan Babrou , Michal =?iso-8859-1?Q?Koutn=FD?= , Waiman Long , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Thelen Subject: Re: [PATCH v4 4/4] mm: memcg: use non-unified stats flushing for userspace reads Message-ID: References: <20230831165611.2610118-1-yosryahmed@google.com> <20230831165611.2610118-5-yosryahmed@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Stat-Signature: 9rk7sgaaj9ymacmdrxg5a6b8wntei3xs X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 7A753A0037 X-HE-Tag: 1694516583-280009 X-HE-Meta: U2FsdGVkX1+dMiP/Q1VZTfLwUiOyEPdIWRVIZwDFMbhEh6zed8ikyKh6sHqocJnfOSVjbRp7fTG4U5DAHlc2ZTtdI3myh0vpBAN7MxiQrY6rjuZ46mO5qTRzrWhyBWkYDHXUiWvn5XkYaMRp/YTnJBPuLTbiFooSJIWDnqGrHRbVBiVEkLYYXq7P4BmntaIiZwYmwQS+g6o9tZvzQX9nL354Jn5+NfV5xgVEWAUXHdm41s9U58iuMHoFR4DLuUMECzxcKSMY0NpSn+9ixp/ejyapWqaoLo7zVkXaWxsszAkJUYl1BwYUS17ZaYExOmYNXacl+NbGJ3dzMIYgD6E2nss/idLESz4lODPu6IgRvhzGh4b6JSDxPQIloKrB30q2uBxEtMJ+NsMkf2mNqOSYxrf7OnI2CXgjrjqncJ85m+IJZSbzw9VNULz25WuALe76PpOO4Npxznx98h0bgIObij0l2GOUIw0bfXT89Xh0XV/IpoWMFcwaJ4aMn9pJzwEoyBHzDPuEnKVmek8s15mavnmxRyijw85S1ay/zNlCzWlo38fofsZ2vLN2t1i9nYLjmiYJoAYYkZcDGaorq5geyy9+8kVahM6M7DjRw/RzxQkJt852TREGu8EsGI4g5suHOzk3jIKKnGFa9vdzp5gcr7Dz/1EGZk7qqoHZ0wIBzTR89S+XMwuywbEV3MVf+80vpdgFAjgVPrlfqR3Tbd5kXla/iS2/JsC5M52KIJ/PeTIm7KUAy46KFQlWQqb2+pkXdnwwO2PbW3SADKJSsroswdOJ0vVTDz+FCX4kxpxQ5XRPJML84Qy8oBZtLweqR1e8Xy7ihe1v/LOkzYLA7eJp1oUXOplaXFofHyec73LlfBYBIZ/CvtEaJGMQuMT6UNhmR2QmSq9bDj0IOyAIYZ6HzNEmGM9nzmiPwTXQxjYeZUBphniQh29PHDY9eaCDkVYMj/mYe1k+ewxsbYD2OPQ dmrVbCSf 4vOjeIDW7DYqmM5acC5tJBNnv6tEKOo/JrzDAcBHV3Li88bmAnNWP+gm6m5TmspjvSuuSEjZ3SwqHkv7nTtvbCweeC1ojYsrBMgelGZD/YAmfD/O3mScwZLTkYg9SOMcfK8qaByVYQIBIQoe9w8jlXi5dvQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon 11-09-23 10:21:24, Tejun Heo wrote: > Hello, > > On Mon, Sep 11, 2023 at 01:01:25PM -0700, Wei Xu wrote: > > Yes, it is the same test (10K contending readers). The kernel change > > is to remove stats_user_flush_mutex from mem_cgroup_user_flush_stats() > > so that the concurrent mem_cgroup_user_flush_stats() requests directly > > contend on cgroup_rstat_lock in cgroup_rstat_flush(). > > I don't think it'd be a good idea to twist rstat and other kernel internal > code to accommodate 10k parallel readers. I didn't mean to suggest optimizing for this specific scenario. I was mostly curious whether the pathological case of unbound high latency due to lock dropping is easy to trigger by huge number of readers. It seems it is not and the mutex might not be really needed as a prevention. > If we want to support that, let's > explicitly support that by implementing better batching in the read path. Well, we need to be able to handle those situations because stat files are generally readable and we do not want unrelated workloads to influence each other heavily through this path. [...] > When you have that many concurrent readers, most of them won't need to > actually flush. Agreed! -- Michal Hocko SUSE Labs