From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E95EE6FE2F for ; Fri, 22 Sep 2023 13:42:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BFC526B029C; Fri, 22 Sep 2023 09:42:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BAC136B029F; Fri, 22 Sep 2023 09:42:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A73F06B02D1; Fri, 22 Sep 2023 09:42:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 978FE6B029C for ; Fri, 22 Sep 2023 09:42:00 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 67F3BC1109 for ; Fri, 22 Sep 2023 13:42:00 +0000 (UTC) X-FDA: 81264346800.13.2605B16 Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) by imf11.hostedemail.com (Postfix) with ESMTP id 8596C40015 for ; Fri, 22 Sep 2023 13:41:58 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=McbG1r+n; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf11.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.53 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695390118; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mNyatKE1jxYtMSShNIBuDi669vU2qZU1RTH/jHEa998=; b=s4rUUM2vokmjsPTulGtmywQp5e0Emx1uSxqihhDWx8YCcofS/1fFpcUB0GzW3HXiQYC0RH InSohOlZeB/d9cmQcIBAtA4vk9Vym2LVedq4AWrb5uq1UKwA/m7n5M4iDtA5Sfs/0cMUSO yqUAoJm5u78A0G2YM6MWLP6Myuitni8= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=McbG1r+n; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf11.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.53 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695390118; a=rsa-sha256; cv=none; b=NRQ2FJz/t1Rhmn6IY5FDnNzmQ0109/i9EsTKZiyb4377af5Gzvwrt193fzyhlLh3D+WNHc pOPBWzPlTtzZ6jYYtWYsgNE7HigkBBwlSEYdaRSpYmFMrUl4kzZmPjeu6J3k5QnXtxqxLj ybTlpE0YLZwySU0r5g4Ec/33n4FMqAQ= Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-50306b2920dso2995592e87.0 for ; Fri, 22 Sep 2023 06:41:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695390117; x=1695994917; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=mNyatKE1jxYtMSShNIBuDi669vU2qZU1RTH/jHEa998=; b=McbG1r+n3SJfNIYAjzZFZRr3lgcFRx3NmhrQPP2vZpI0wk2DfvXjMv+qTWQRxdSptB oT5aIRjDCRUP4frN4kHUnBy+pN3oEt3U55wP+jPJCa/MjIIbbjsKRRZzRy2GzZm7Veie HxLJ6iTXkTXCq5KkiuHQChTXXxprWvE+hx+PgtziftT2jBXGNPYaVaZj83ASbfBqw4q/ gYWQ/WRdDmcESiv1UaSSQ86l5z5WZqiT278Vz3Cv4n94C8F+44RoURZZgC30hi1IZ+Jw pZsicC+V0Hx/KiWtKOpU492ATtln59UgdHSe/fF+Wgkwd0GmGznQan28YCWNtOMXAuCb 9BTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695390117; x=1695994917; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mNyatKE1jxYtMSShNIBuDi669vU2qZU1RTH/jHEa998=; b=N7UPz9MfBNz5pAe5l9yLwQVxcNqLPgE4NJ6ExHvPLmdI5I8kdvKHsKrX58cpzqAFW7 Tat0shF+QPMSupoCqXWwGZwMQc1YSYter54R4Vde+BUzY5NDGz8btwaOEIdPbdOeRhxf Grisf74FGFsa+8zygigfEGzaJPSgto9NeGN4bU3ljosnP633aTm65TmtX02ixJjYB5o9 z+Lne0auUASzW1mfF4XD7soFhcX2tCrfpdaJbnfdtuIUYUZFuDN/v0ab43Nn9lHXdabB 57MUgMRomwF0Id5dO/TWh/P4fJkcWKBaN9DIxvB9smAmagrkjnYxFH+3H4L7HnUKKRR3 GZLw== X-Gm-Message-State: AOJu0YzdwD/Or30a2YqZAiqLYr8igkBWY0JC8kaXz0Yxii5+neVVcxPc 9cfIF5iJZOsa6VSOryFVCe0= X-Google-Smtp-Source: AGHT+IGLEvMlHwkAzpSnQrKJflkM7c9m/I6oKmtnlycjlNzOy+Wgu2dsmNFZMhkINl9Fhb3oF9AaOw== X-Received: by 2002:a05:6512:2210:b0:503:16ec:7153 with SMTP id h16-20020a056512221000b0050316ec7153mr927525lfu.31.1695390116452; Fri, 22 Sep 2023 06:41:56 -0700 (PDT) Received: from pc636 (host-90-233-214-51.mobileonline.telia.com. [90.233.214.51]) by smtp.gmail.com with ESMTPSA id x24-20020a19f618000000b004fdb85646f1sm731972lfe.201.2023.09.22.06.41.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Sep 2023 06:41:56 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Fri, 22 Sep 2023 15:41:53 +0200 To: Jaeseon Sim Cc: "bhe@redhat.com" , "urezki@gmail.com" , "akpm@linux-foundation.org" , "hch@infradead.org" , "lstoakes@gmail.com" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Jaewon Kim Subject: Re: [PATCH] mm/vmalloc: Remove WARN_ON_ONCE related to adjust_va_to_fit_type Message-ID: References: <20230922062704epcms1p1722f24d4489a0435b339ce21db754ded@epcms1p1> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230922062704epcms1p1722f24d4489a0435b339ce21db754ded@epcms1p1> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 8596C40015 X-Stat-Signature: wifjb1osjf6t33cthgs8buhekob3fnkz X-Rspam-User: X-HE-Tag: 1695390118-152635 X-HE-Meta: U2FsdGVkX18Loi0BnRSqEOA7vDkuqWft7KYzyqvz0Z8aK7TBIJfGlRuxgi6bCz5ZBWv7w3pZ/1c3pi2/aMdoACpTnMCN6QR0puuomNFchc+NkleJzjxiQCell5On0MtPY9T9Ssliian7jQ6LIFOEU5CaJrh8R9I/1+lPK4flNC/ENAMrEgUnA0+HHj0YZ+GHbnM3mxLx2QpzJ7PiS3WquwDl4OWH0I1W0XCq3XQPl3+TFEqbGNgX54e9d9iFOIBxoDxy0RJXMYOAQNA0myUdxCQ19WJxb7wYorFCaEJ7NceLj8dcOGROF/0TvlZKN/Ff+Gm3alcRwqCb3iqFG/Ex4UJRiqMln7bPSSyZ3Ueg78EHQ4s7Cu1+7U767MwI7Zj9lPQY3uJBynGUt5UOg7V89dunwlcJVGFu+N/9Ou2uBeQZtmbo37B1Nbr+pFm3Jc9yNIEbyqX1IFhvDCDMnE0cWG0+agfHIeB4hee6rQ0lRAmJTAsiTNRBmAkwogVKInYp/W8HpfWJQpFbmDU4gQp+y24BtdIXFHGE7KnVL06Kky3SGRrFywwUJRG/vSER9Wv163/PEAGFsvE3GAM6878GfX98Tm9fJz30RmVJHhGkMY8IxJarkVd/4w63PhYcQ4afeXgSs7agHI6JBPWTG+siCOmBhPmxQ8fXWeQMDSdwowUcu1LTPIqVkiY7RRCABXyVDDP2AuyNt7wqfOFo78huVLjVoA4yyZIEUuFEW3LfBRlKGqAIjHde3IPrbXBRJovyDTi89F5IwJjoDDXE4Pjuiy9jILtHJyOyxkQCmwX7tYdBDKt15cOEKqB/C4lGGVpK1STrBmCgV/nDDmhjMhqu70CqifdTC86HuMpgaYujYYxcl+YVkbB9SilqxbmdQgfIjK1GJ0clgOgiFnCmRmnlW3jPpceIC8742YXC9VLTugNwFsO677SAi1I45hvoNU4D5Zen1wCJ93L+eFHAKak Tpcic5J5 tbtWBUvvIoe4MH1i7CkHgttqYFn3nY+07/vAw4Jts0j2YMit+tVzWOG0vCCrNjwVsjuQRZZf2VPnEFHLjPRMkroasKsioLL5tf7HfUyzcJd2DD2Q2ZGGLMh9xWpkI5M4DHJakLkB5RnEZDuTrqW8d1IHmooGjSp3DzP0RYw29szuQr6eagJuuY69L4+VDXFyJcM9YyVunBymSv59Mzk6+4bzoc09vcRGUa18/ORAP+XxuYJ39X5OACEad/vFTTJ0gqalNlJmtQgCRWcjQZhs0D81QJMH9VOs4A69ZH4OyXxabMvNUqafsXtKZNd63vH/SSNW/knDUGSr+bWX5HkFvSXkQyP+lHNNHltnnShGVXsxWaVk2PcQadDkBw9gDRqQ1TE2VNtergwOy2dwO0k0aGe41JA1Wb/AWC8MQsmJctA2zDJQGZTuse9WYFBiLffAejW+JiUQqeJVvdp5yb5bDhxu/BeNrxNwhB8oVkfWfo2YIC79DnewTSbRKg97qbWN5LeHl X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 22, 2023 at 03:27:04PM +0900, Jaeseon Sim wrote: > There's panic issue as follows when do alloc_vmap_area: > > Kernel panic - not syncing: kernel: panic_on_warn set ... > > page allocation failure: order:0, mode:0x800(GFP_NOWAIT) > Call Trace: > warn_alloc+0xf4/0x190 > __alloc_pages_slowpath+0xe0c/0xffc > __alloc_pages+0x250/0x2d0 > new_slab+0x17c/0x4e0 > ___slab_alloc+0x4e4/0x8a8 > __slab_alloc+0x34/0x6c > kmem_cache_alloc+0x20c/0x2f0 > adjust_va_to_fit_type > __alloc_vmap_area > alloc_vmap_area+0x298/0x7fc > __get_vm_area_node+0x10c/0x1b4 > __vmalloc_node_range+0x19c/0x7c0 > > Commit 1b23ff80b399 ("mm/vmalloc: invoke classify_va_fit_type() in > adjust_va_to_fit_type()") moved classify_va_fit_type() into > adjust_va_to_fit_type() and used WARN_ON_ONCE() to handle return > value of adjust_va_to_fit_type(), just as classify_va_fit_type() > was handled. > > There is another path in adjust_va_to_fit_type() which could > return failure and will be handled in alloc_vmap_area(). > Remove WARN_ON_ONCE() for this case. > > Fixes: 45c62fc2897d ("mm/vmalloc: Remove WARN_ON_ONCE related to adjust_va_to_fit_type") > This is i do not follow. The stack shows the warning in the __alloc_pages() path. What does this patch fix? -- Uladzislau Rezki