From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4F6ECD4F27 for ; Fri, 22 Sep 2023 07:47:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1E0666B0296; Fri, 22 Sep 2023 03:47:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 191DF6B0297; Fri, 22 Sep 2023 03:47:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 07FF46B0298; Fri, 22 Sep 2023 03:47:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id EAABC6B0296 for ; Fri, 22 Sep 2023 03:47:35 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B8603409AA for ; Fri, 22 Sep 2023 07:47:35 +0000 (UTC) X-FDA: 81263453670.08.4C189ED Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf02.hostedemail.com (Postfix) with ESMTP id D7B2880015 for ; Fri, 22 Sep 2023 07:47:33 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=cxr2t9Sc; dmarc=none; spf=none (imf02.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695368854; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=67+5P8IA4r3ycxzRXf9uS+CTU1WKObU4FRulN1vPJqY=; b=Bw1SeMV9u+8Yav6LW33KOQnvrBHuClCYMx+PmsTtci5je9h1xVR1lJPklZSKb63GpWvHWd 7di9m1FbcxLmLXhVLfC8UdyIlMjDpuhxvEB1OvxV/JgyBIjJyWx0l4eSLnXBNXkMDvjOrE mBCdIfZIgcd6XnHdriE3lTnTek6hm4w= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=cxr2t9Sc; dmarc=none; spf=none (imf02.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695368854; a=rsa-sha256; cv=none; b=DATaki2ZpbJzaXpnmA8R2JXAYT5bR0H4lHshSOwrGoLI9pl9cEiLI9+QlYO5yRNXgwM9ZK MGWP4/Aq/L8bUVdqCgwfs1ezoQ36SPhNrf4Oc4qYy99fiUqvxTbfmXSXJTTQZfO/YWjmbP 8ru+dt3kgJUdvclLreGA9YPKes3FObc= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=67+5P8IA4r3ycxzRXf9uS+CTU1WKObU4FRulN1vPJqY=; b=cxr2t9ScchXsLUU+e23rbVT7xR waa3pq1G0/U4lpu/hr8mLFb0NK8610MBJ9/aNrfANM6JOzPGUww5F/J0MlLFPTcHiAxnjggB2ACGf jcjBEU5J9pdpaQ4n5IavkDn7lB5M1Otr+oKn2MSDRAQ2UpaElZpwRxLC/+s7uNBlCaZw+cSGnSCgn ZHNRvW+Eik4mgACbxn8iSwOoAc8mromv2wPhREoGW7JH5bfOtWu6jJWbfFjdRf9fi/fOg81nPl/5W /9ugviXGfIKw1uulzx9num4yJu4nrYXHTrYk1xerZVYQnd2GbG+apqj16/1OnakmcMYmcOHC/ia4n HI0pI04A==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qjasd-00H0QI-U7; Fri, 22 Sep 2023 07:47:15 +0000 Date: Fri, 22 Sep 2023 08:47:15 +0100 From: Matthew Wilcox To: Yajun Deng Cc: akpm@linux-foundation.org, mike.kravetz@oracle.com, muchun.song@linux.dev, glider@google.com, elver@google.com, dvyukov@google.com, rppt@kernel.org, david@redhat.com, osalvador@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com Subject: Re: [PATCH 1/4] mm: pass set_count and set_reserved to __init_single_page Message-ID: References: <20230922070923.355656-1-yajun.deng@linux.dev> <20230922070923.355656-2-yajun.deng@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230922070923.355656-2-yajun.deng@linux.dev> X-Rspamd-Queue-Id: D7B2880015 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: du8jm9yf8tiww4rgz3mwsenyxwq34t4e X-HE-Tag: 1695368853-906285 X-HE-Meta: U2FsdGVkX1/gfK0iNowzRcUlPP7K4CGmDgxiRkL2Vscy4vVuSwd0N1PqzIF1QhFYHkiYqwX/7aerS603guy3Z9IGs68qKnu5aB1AGHR0LQiFshJm04aCS0sIkj8n1mTMGIGjR7wEc2SYbWqSiffjiJAzkfr+nY5+UdFDYJ8JXxvMOVrRvXkpsBW0N55cywf9/j3+bK1XuF3M3RJ7vZhZYO3KiFTtMr9IkAH8YOguvIrF887rvBezik0FNBr3hNvddw+zC7aOEuMddzbKjR+gEDP58PCusuOLlNKSR9Fn/TQvrXMsQ92u6RfFosQWXr61NoVtMvLPBk5rhJwjnbd+sGsXAGxrd6sQHmPp8o4Culi1+Ar/p59hXvIqOZ0g7wCEvcpoDGDWizR/NHCW9CrQYUg9pIzgFLRxFXkkstyjqSevV5IYjL9lLOH9m8faHACaRVOe7v4v8cyG53rj9rrBIoWH24NZaMnXVf6dxhKZpqzNkHyLi6kMXQOVFc0X1MLiK6Yspy4wmHuDoFe/gHbu1OSwjqgZqY1BGtXB2hBGsf6wLYsTg0bYOp9ssWdvlneLVhArHLC1v56beNMCpSCTa5id5kTl0LiAK3zY8TQ5vRNPn5Guu0Hy2Lj0K/LfWZcT7c3Ou9TQtuSwb087IogJU1p+EmfnOd4N64TKyqpaXzyJuz8lo8ulQZeaLcntwTvEUUU6ZVjnEJPFOeSCWaCaRg3/dIDr/jMvYANWUK9GneU2f0JJ8Lv6QozpcHDCbIwBzCOyvzcbYUf5KaGD87u5EwAJ1of8+XqtoH1R4v6qBmSAhFmjrj+a60nilPRM2/KYDNKzVylFz7fUSwYcl/9IEWZGf0gnXD3UALjIKZsASX622tneHwd6Pdb5RUNgy+/SFZ73Sxoi8DDLK70/zmd0W/CkEx/ROkRdGHHXtel+oErarPceXs8JhnAzj4Rru+lfPnaTqehdqXPOMUsmD3T fl2UJIxC uiwVuumXLED0OYWeS0XwPNu34tyM818nYJzzgvzlJG67dV33nQp6lSBuubEQ/mtC/DE1xqQyWdBYuo8NJK7SQna4lX55Bpt3JFqMd/Djaf/dC+ESNBNvYQ87THxj46ykWieSFuEMdwYpdFxbM1d3jrTMFRxv96qy3pkiYwmb4wKvYf4V0mGQG3dXNZg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 22, 2023 at 03:09:20PM +0800, Yajun Deng wrote: > - __init_single_page(page, pfn, zone, nid); > + __init_single_page(page, pfn, zone, nid, true, false); So Linus has just had a big rant about not doing bool flags to functions. And in particular _multiple_ bool flags to functions. ie this should be: #define INIT_PAGE_COUNT (1 << 0) #define INIT_PAGE_RESERVED (1 << 1) __init_single_page(page, pfn, zone, nid, INIT_PAGE_COUNT); or something similar. I have no judgement on the merits of this patch so far. Do you have performance numbers for each of these patches? Some of them seem quite unlikely to actually help, at least on a machine which is constrained by cacheline fetches.