From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A6CAEEB565 for ; Sat, 9 Sep 2023 01:16:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4AD1F6B00E4; Fri, 8 Sep 2023 21:16:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 435FD6B00EB; Fri, 8 Sep 2023 21:16:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2D67B6B00EF; Fri, 8 Sep 2023 21:16:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 200606B00E4 for ; Fri, 8 Sep 2023 21:16:08 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E2DCA1211D5 for ; Sat, 9 Sep 2023 01:16:07 +0000 (UTC) X-FDA: 81215292774.21.405A6D7 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf28.hostedemail.com (Postfix) with ESMTP id 9B77CC0017 for ; Sat, 9 Sep 2023 01:16:05 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=HIx2xQuW; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694222166; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/ZsYp9xBq3K/Mmd51vPcTXkWWi9Dav9b/gzTkFLb0g4=; b=G1h6XmlULXdJSYR8aK8KEeqZJymuHBZzfwDKX/3NW5xGEYfee4c2X4HJRFQKPG314CxN6S IIl+wdtReyc+dwd4BSgDVC/HDn/PO2Dl7EiiYa/r8WsWxBZO1GweazY8tUaK1EtpMlQ+t7 3j/7qKoOmAwseCNurLsWUt44fxlj8Qs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694222166; a=rsa-sha256; cv=none; b=QiglflUUXY4JftEk5op3AgFrKObk06oBPTtJ/L3cUmYta/mkEn0pOyB+ZcbXSzpd/oqYCh SxWwqZxqlqKjzyafh6YveTzLIr15Uhzmu0efhY04WEKn4vOWfXgpnkmzZFWWWAF8DnF15H 98m8wgdn8kp3xjKBoS7tQQyFBtZjVqo= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=HIx2xQuW; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=/ZsYp9xBq3K/Mmd51vPcTXkWWi9Dav9b/gzTkFLb0g4=; b=HIx2xQuW1+qoR+282kB7any4BQ HHCetLGZTA33zrVKRzeqRMdqwLeSLkCEBXhgtIx0/ZOME7crgTH40F40uSimGk8IZDPVYKsvXe5nu TthRRLUSK1HpmQ1Dri8oiSDb4NHyLB9bsrrkK+aVu6jO5V9QOkJOKNv+PPOOuvXhe+tyKShoOMn7u 81RbY8VvkDmjnOl8vvMRzBrjvpITP6luVPnHLZcG1YOz/EHvsNJGEZn7SFoeSeU/9n2Bgj9iBjzxy 9YDhH63ZOdTrMGpdqbECkXQFFiz4bjwdlk/qKkPTliz5xed+R+qm80buzZ9AkiU5zmTYvkru1VTJs 5DsGbXJQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qemZs-003Qnj-5p; Sat, 09 Sep 2023 01:16:00 +0000 Date: Sat, 9 Sep 2023 02:16:00 +0100 From: Matthew Wilcox To: Rafael Aquini Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Vlastimil Babka , Waiman Long , Rafael Aquini , stable@vger.kernel.org Subject: Re: [PATCH] mm/slab_common: fix slab_caches list corruption after kmem_cache_destroy() Message-ID: References: <20230908230649.802560-1-aquini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230908230649.802560-1-aquini@redhat.com> X-Rspamd-Queue-Id: 9B77CC0017 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 8qhpqd1orin7nepphxay1jzajhba31wj X-HE-Tag: 1694222165-314015 X-HE-Meta: U2FsdGVkX18WSTtp0QzBWSCRojlAf8XDNoQqCtfwSy4+6zhDQBN23mN1t2pDoHJ7TKZzGRHIceE8p9d+HYo4JuL4wz2gVbHQSlqlMMc550wPllL/xEYdYJH3f/3U4EwwNsNeIoz5Hlmfaavc6Xn/HfnATDbr33vJGsIaEgkxBljR4eVcK6Z4Pa0GHS+SUyNnFAMpN2kg66ICs1ZdxREBK+nqDUc5z/N7t4lPz92FMM1JsxP5FB0EzJwdjMT8cEQ//8EmG+ZTsCksSQXKKbF+DOcRp11X7KEuwd7Gnei1S5X28JfLRsueTnDBpFDCiW5i+zCR6U4B9zgh8/ub7L+et83nIhaqn1qZ+7celSKS4rIw0txzyFRgUDYw+KPJTCKB8ka9fqAXHr1sbewGPeFsZnu53f/w8cIg0ikKqaUjKYjshhkjEEHMNlqoVIKKI6We3z89/MP6bHzXYByWafJrLYvGI0QEOMJSb9kk/i7EW/uB9a5ZrMJK2pTr3uQj3hhFPXG+mMEBZKRBrfTGusuUGTUGAOURHYofAUv0OCo3mRjZPPL6MhNBvDxzuW3pgP0qSNxWhQSZJA5nyUqXiJ031axoRXyGUb93G97xZaLhnu5B09Vy/SAbMuWnpt/SmDiJk/OuekzDh8XriQmQ6XRzN0tQdESVJ06bhUL96xY4+GOLam/ZyqaTYVHDlax5yXtmuVTaQiAcFI5Qk8bvkfFwfHxLreWARd9iD6xerMFebIBljVRE7Cc2uLvbCsYiExlRe32SulrxXPfcOfvd1ITAiQhjgvTaISU9rRBdwkWQCxmF3iprTRF+XX4AxMV7MFAcpLC9xBgn256qsGTNhuCnLUk8cQJD03LYuYkCn3u5tais4drEQ/m2tDAU+V1PvWI0PyK7gXOT6VLFsYKYaKZgjH8GXCOB7KClRc3VGoqen5oj/hoDEuT5yLovBIsA+YqxVOFy2vj637IvOVcCCxw y53rpkVw wnfMPV1cv5LKVDLiNUWSe060wDq6doLTnZF1CTgVADisHKeST5vIP2gBU5D3pDLcup7vIMz7kuYK9iRmVb/LP5DAa8Pt9z1E7LanMV4ikdLGZ9SnU7O/NrfaspcWaAj9YOdf28hpLVREZ9zFZPFjCNvir9f3b3WIhjY9cbnoNrhzl7GH6fdLWTfvO/DLHV1+1kAPeL/erMdnLn/Q= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 08, 2023 at 07:06:49PM -0400, Rafael Aquini wrote: > This patch fixes this issue by properly checking shutdown_cache()'s > return value before taking the kmem_cache_release() branch. Is this the right way to fix this problem? If the module destroys the slab cache, it's not going to be possible to free any of the objects still allocated from the cache. I feel that we should treat this as implicitly freeing all the objects that were allocated from the cache rather than saying the cache is still busy.