From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2771BEE7FE3 for ; Fri, 8 Sep 2023 13:10:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9599A6B00C3; Fri, 8 Sep 2023 09:10:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 909216B00C4; Fri, 8 Sep 2023 09:10:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7F8386B00C5; Fri, 8 Sep 2023 09:10:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7185B6B00C3 for ; Fri, 8 Sep 2023 09:10:04 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 44971A02EE for ; Fri, 8 Sep 2023 13:10:04 +0000 (UTC) X-FDA: 81213463128.26.2EABE43 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf02.hostedemail.com (Postfix) with ESMTP id 3E21780016 for ; Fri, 8 Sep 2023 13:10:01 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Hdnr4ID2; dmarc=none; spf=none (imf02.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694178602; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QRChBe5PZMuw+zPsASEy2dEzmm9n/h3rkYmxC0tWOYs=; b=3dV5CESHK0vjFrwC8gUfSWKk8Stjn8ldapqUbpWiGiguSTwwyN7WLrF6DWCpPJL//8B3aX mu391UxY2wye6j2WUvdSMwNXKLuDzmzpWQ1r9KLurrxVEEn783E33JXsrtiCCk7VWVf2kg 5aNmYFwYLPJUCaoM5VGpflZzSt9y0wU= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Hdnr4ID2; dmarc=none; spf=none (imf02.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694178602; a=rsa-sha256; cv=none; b=jnr4MU/VIT7UWpMfcCBZUN3U2AdgReYqovAbgCfPpY77FB4GVR+zQGOrYcLcsO899begPw 3wKO8acvTjWoHPAs0YmXnt+tJus3+76K3urQxXIUCpvkoFpC7K+WgaHZBgRrFL8K3dLWtn cj6lPpWDQc0bjtPlDNCiWR9MmRQOXfU= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=QRChBe5PZMuw+zPsASEy2dEzmm9n/h3rkYmxC0tWOYs=; b=Hdnr4ID2aydT9hhHxq/HiSr6nU bDqb2vDxhqGdqAR+KQMM0w/2ASZoQnHLYp2wKk9Dr1eiiE0xldEpXPAnEVkJ2ld1eLFt7Ey+6pkAO UJ4qRm4wQJRhY3UHRXUuhPjgECoUVqXfa+pR2YiVMylpHa3kpyAvSQK2m+vUy3Q69Kgu4UB/B0fxB eM3F+a2vlX7pWcgVnFeIn4hLq1UJXLG78tQMD8A44lwv4PHOfbGqPewjG1feq9GN4bIW+gT866lNV giXQUgFsNPX6DC44yKe9AFFzttXmqVPT/5aP83Q08/XIo4g/0kn/NqqaURNgRB+BY3YpfLeAKoUOe kEG3cBdA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qebFB-000HDw-0T; Fri, 08 Sep 2023 13:09:53 +0000 Date: Fri, 8 Sep 2023 14:09:52 +0100 From: Matthew Wilcox To: Ankur Arora Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, akpm@linux-foundation.org, luto@kernel.org, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, mingo@redhat.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, mgorman@suse.de, peterz@infradead.org, rostedt@goodmis.org, tglx@linutronix.de, jon.grimm@amd.com, bharata@amd.com, raghavendra.kt@amd.com, boris.ostrovsky@oracle.com, konrad.wilk@oracle.com Subject: Re: [PATCH v2 3/9] mm/huge_page: cleanup clear_/copy_subpage() Message-ID: References: <20230830184958.2333078-1-ankur.a.arora@oracle.com> <20230830184958.2333078-4-ankur.a.arora@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230830184958.2333078-4-ankur.a.arora@oracle.com> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 3E21780016 X-Stat-Signature: 8k4shhncfxp3fnfdb9oq8qu4jc7zufaw X-HE-Tag: 1694178601-230186 X-HE-Meta: U2FsdGVkX1+eK7ONZZ7HsnW3Q5mdEWTxCOrfXmHSUoYdj6voTjdjudxAEqa1WyaEa7Zu9jcSpbW2IpDXYMNXxyLoGkyTql9tTbNyfj5fX4bDQBBiwAbwxeeybr9/dpGLGhqPh581H5h7K7bZw947CUUSDFuhDyfNaMutbV2x0wKhcWQfenZzMkNClo9pwh9tWayj5kTPWFgTXdW7aEngw9XESWzUxUEFh88JbAnD+bCkU31erAsbr35yOL1yVPIEpslx8WqvnO4Fg6Yxp79UckjYzMnitaUSRivt8dgWbafzC5r7jBPXd04OOdUMaxCUptecwL4AqzgaSLq0Y/8LiTWVjNGjmzEZrJKRii+Te4rz5/9032MG3Ri+uSSYbNvz+3kfuMnJiEekEM3Tp+WP/JRAw42kHbdCh1ax+Yk43AoOHXDntMuaO09EDGTTh+z3UuCVtB2zwNGqYEZlFKOtAjHtvfgsY5VlnqNT2jh9qvUZmKjVzPIZyeqiwA8ysQNcBe9yLIAoqUoXvAP+QdN/GPuPwjAZQuLWXLBvg6anuSK+z2r8v5DxeJ2ngfmEuUYbZD3HLafo8JI1sAU19ZDz916ORkzqcRM53Br5WQ2Ck7HDc7AwASUmKldsYRck0ZNVAixwLR5K9D1uI1LP1AXNBvNu6FwQ7HdYyspr1NwUOpNitsP8xTMroMNLUaGHpaIrtE6cuAAOI12tDE+zL7l8id/IG9rFUEBnu3K0jZOjuH0WunGOh/IIet7EqjjkNuOXrEiUNdeEnTUmAUzn6uzHUQAkMan/WTexlesauXuR7NYkgAECRwQwgWLonX+/L5LmgLGq5TNbur7VtsY7KQl5Jn4tc0+/QhVg7cmWxtuLcKrzHayQyOnWHXvmh8Qi6HIa9ojI4wzrDG2UfbDnevGXRJdcJC2e9eY/dy6ckdUyVgYp1n6kv6TtYEbjzYkpaUlj6Jh3Kh0AQUyux9KU4H4 9v+M2UlJ l7CNkfim1uaaM4yYdm8f+FV5k+8qVDIJNSLCKtbYoi1u550DdjYaO0oBneE80izo8hsM2dUr4fmGfdWhpiWvYt0a6pI58yRiGjqWxds3dyzQNpqJrhmamJM6H395PuUCp6ofVmuBUefuLtnjn7D758bfXnTgRSvDhAymk/WEY9WQp9D7T7U2Ms8tTLQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 30, 2023 at 11:49:52AM -0700, Ankur Arora wrote: > @@ -5945,9 +5935,7 @@ static int __clear_huge_page( > /* Process subpages at the end of huge page */ > for (i = pages_per_huge_page - 1; i >= 2 * n; i--) { > cond_resched(); > - ret = process_subpage(addr + i * PAGE_SIZE, i, arg); > - if (ret) > - return ret; > + clear_user_highpage(page + i, addr + i * PAGE_SIZE); It's possible for a 1GB page to cross a memmap discontiguity. This needs to be: clear_user_highpage(nth_page(page, i), addr + i * PAGE_SIZE); (similarly in other places)