From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 469FCEE57E6 for ; Fri, 8 Sep 2023 09:10:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7E9AD6B00A6; Fri, 8 Sep 2023 05:10:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 79A066B00A7; Fri, 8 Sep 2023 05:10:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6BA3E6B00A8; Fri, 8 Sep 2023 05:10:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 587596B00A6 for ; Fri, 8 Sep 2023 05:10:41 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 26C80B441B for ; Fri, 8 Sep 2023 09:10:41 +0000 (UTC) X-FDA: 81212859882.16.5DBAC8A Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf14.hostedemail.com (Postfix) with ESMTP id 354E710002B for ; Fri, 8 Sep 2023 09:10:38 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=w7IEhWIw; dmarc=none; spf=none (imf14.hostedemail.com: domain of BATV+1f1fc35dc63b9a4cf306+7320+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+1f1fc35dc63b9a4cf306+7320+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694164238; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hAaUM/xyOWpmkE94iyN0z7EBoyIh/DBzvfJchcaSLnI=; b=WrrZ768ArCsKm1OGn509R1ep2flof8XtJIRfKmqch+46AhSBapZ/z58xPiXnxsr4C6BRMc cd+YTaz833xbYkzWaa16xJU6CY16ozw2wDgpHXvAfNiYzwoTf96lv0FtsTshDDnHOK1/Oz MtHqJqvvCx05VOrSKAfTe3JP/qoBHic= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=w7IEhWIw; dmarc=none; spf=none (imf14.hostedemail.com: domain of BATV+1f1fc35dc63b9a4cf306+7320+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+1f1fc35dc63b9a4cf306+7320+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694164238; a=rsa-sha256; cv=none; b=yF2ywBAPRbmIQlV++XGZGQdY40HS76noL6tM/T4LW+qhLaUVp2PMEfYm19Tq2fUsYSULQj kOtaLNKwLny36GSr3WMFR1iqR7WPErcx4aol7dwq9fc4NcloaOh6zR11wgkVsJofPKfFmA shjflmTZeScMMDAFMqFugBP2WanH2Dg= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=hAaUM/xyOWpmkE94iyN0z7EBoyIh/DBzvfJchcaSLnI=; b=w7IEhWIwyYzV1mqWUUDTmle+K4 nh12QqYUrZCafvBdnLhPmyuzVnZpqjdBFMKQBFXZkT5jts7GX7zcA4EvB6gbDB4mSPVmVc3CetgGE DZI2E3CYxErjrkhA/hQLqI3jkOtli/9ZlD9csNUnuXG2CZC2ylm8A9jQawE8yb/Q+7zRQFd3vnMdX kD/1xrVm7CKO+uc7uWSr+X+g559gWgu+013EJ9GUffF9HX9exuDdy8vhjHMpIRle1tfTYqAAcTdHw 1WNy9p5pAHg3MdCjuwNuUard8afRpHckNG7VTO3ZZ4bJ4Y8hmg6Ur8/CnSrd7UGoVnpajLMv8/khU kH6TpFMQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qeXVV-00DNeh-0X; Fri, 08 Sep 2023 09:10:29 +0000 Date: Fri, 8 Sep 2023 02:10:29 -0700 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: Peter Zijlstra , Ingo Molnar , Will Deacon , Waiman Long , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Chandan Babu R , "Darrick J . Wong" , linux-xfs@vger.kernel.org Subject: Re: [PATCH 3/5] xfs: Use rwsem_is_write_locked() Message-ID: References: <20230907174705.2976191-1-willy@infradead.org> <20230907174705.2976191-4-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 354E710002B X-Stat-Signature: ysupu3f5xpsqqb6bnh1gbjgzndxbbwp5 X-Rspam-User: X-HE-Tag: 1694164238-656740 X-HE-Meta: U2FsdGVkX18h6rHIJ8FpFL95IMLwqRWNVf7I2/s3XNdECmDBxB3mNPMIGSxV1OauvC1BpEYsdoKt8fhUqfkHk/i/UzNuh+9cGVoubCv9nhqHWDqhATpT4TVoRO+wK/24CJH+8A/szCjp9xUTa+f5Z/WHWjXEvZZrFxrY0J5B29U+FodhNmEtBdWHJpNYfVGg8Um/cEkHRNjbvXTc4qlcw8/mgXuXmTu1jr1173W5Tf8cM/AkP3KzX5iSPjHjPAiBhkdHS4XFYIyzFK2mAa3Zq4vMP1Zddj6HohrQyGoMdNaxJy0dpKKWbNkmTlLqyMhnP2g+vCMIVdCK7pKyYuck7iXXax2crQzBB0tdDRp3rcc85Wws59hl+KD742x2nMnen7lTBJYXUx5dbLiSOSJCC8Adgddg0nQ3vmgXTGoqYbc/bFHK2tsSy4ixlgL0+elG+fXNKk37rf4nB3OnUJ0gA9v481Aq+TVYZLvUhmhA68WCieYqWtB1aZrO7AZ+y8FVF+Juww0Xj/K8RDzlpQ70qwXWP4leRyxbmDcmMgsp/42QQnhfvOhk8pFICHgIOYhJAB31jLcfeUkVGCply7YKT8nw7rZh7KBPo5PvKHQEYyihb+koydtatb7zcrkrww2LRq9k9bUqGGyBLyQI6D6cvD86F0P1KMsPBr8mQ+7u/AXFkvPkGm8a/u/+j9At9q53CsBVnZ+zEKCo5tn0BQ2+GYK+3FTvQlkelv6RFiVM+Eic8yJxM57ZolpNQMGGpt6bjPSdwQJV5Oh0FnbZgk2KnyC3pePyRoPnmni0I8P76I8NhE9PFs75aM+Cs22Yql1qmRtpo10x0l9xCxFjSy5tgYfEmuzQx1cjqdAoDc28OSP9tRmIeaVfiKMYmtGh7HtycE+AxMn6UO95ddK7+0YeXCL+yb/VDzwGTBVyaJauo2SxFV0EaTJdMKaGF8ZU+hPouwzNU21mNN0gKkuOfkD BgB/AgdP 87Epmd4AgzjZmpRvh3pL3eGMdHL9L1zqtf99QEaCr8k7a7eovCQ+xnbWwRd1c4y0HRwdmWzQxJF5YQmUudeN+9BI9wvIFonR4rMRJU+/49hoAaDAuQBgA3qRUTi0wI3NCoaqrtc+RZ3alBoVQugZ2/AIS0/5XDRBu04NNXtYS0PY8ejhS2sW+VTa8i4BLKzHTW7U0ZSUEXHEMB71HevCqaeittTw09O9F81uAsm2NRo+KfE6czjDI2V4zV6SLhJ9WYwE8HiPVeDVzjI2S9WhEYhQC0VT4LlmqTcdeWR3G9b7SCCv1UxlfXQR+3iS5byl6ikuNynOFvl5K3G+DAAsQIx+5KzXt+n4rLi/+WCLrRFn2NmhMFOcM8b7ivsesGB77oTUEUK3ERB3+RwYMqOHJmB6vzQniqGS78UN5yI7JOMj7v6GMUbGHT5RmF35C/pUfZUFGkDWQQDcPtwv2DYzLskW3G9kgZ3BJLDWMNI7qO1ijIFp0JL9DpIoBV998L+TEj3tB X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 08, 2023 at 02:09:51AM -0700, Christoph Hellwig wrote: > On Thu, Sep 07, 2023 at 06:47:03PM +0100, Matthew Wilcox (Oracle) wrote: > > This avoids using the mr_writer field to check the XFS ILOCK is held > > for write. It also improves the checking we do when lockdep is disabled. > > Hmm, is there any reason to keep the lockdep-based version of > __xfs_rwsem_islocked around now at all? Ok, looks like the last patch fixes that.