From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8AA2EE57E0 for ; Fri, 8 Sep 2023 09:10:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D17EC6B00A6; Fri, 8 Sep 2023 05:10:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CC9C26B00A7; Fri, 8 Sep 2023 05:10:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BB7596B00A8; Fri, 8 Sep 2023 05:10:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id AB6346B00A6 for ; Fri, 8 Sep 2023 05:10:07 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 6958C160FF3 for ; Fri, 8 Sep 2023 09:10:07 +0000 (UTC) X-FDA: 81212858454.20.ACC590C Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf16.hostedemail.com (Postfix) with ESMTP id 1E802180022 for ; Fri, 8 Sep 2023 09:10:03 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=vpKMwzJF; dmarc=none; spf=none (imf16.hostedemail.com: domain of BATV+1f1fc35dc63b9a4cf306+7320+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+1f1fc35dc63b9a4cf306+7320+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694164205; a=rsa-sha256; cv=none; b=sg5jFihfEwNFTmuvggq9U61nsLfNfTALC+shB05S9DRaGAkzjNDvMMsJ7c/ZVQweQAXRTj adQ0e9NwN1UMbyyO4QgVolaahnQYECvuzpQkdbeYLpMbjXZuZSaD8YqcNu8H2jjBJLnIWv oyEET2hByyRYrFmt9gtbIn++U13xqqA= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=vpKMwzJF; dmarc=none; spf=none (imf16.hostedemail.com: domain of BATV+1f1fc35dc63b9a4cf306+7320+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+1f1fc35dc63b9a4cf306+7320+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694164205; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SNFKFru0V8yFM5Jxy9HQDNqfkXEy96EgFoBM/yR0Dic=; b=NXTiQkAJMpfZecGF4PYcw8b5LfPMtAFTbnrYdnpj+iBybTZaPF0vqCLyQ+Alap6zrfJy8q eXzkJHinxx/QSxj0CXGtYQUyPgFu5MmCOh8HxvKFQYttKsdp555bI1CNq0eY+vvwVHCgEm 3GCaZ5ujeZSs7OLq2IzTw4btsFjgSTI= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=SNFKFru0V8yFM5Jxy9HQDNqfkXEy96EgFoBM/yR0Dic=; b=vpKMwzJFIZmLAnoT8pEmaj+B9d QNeU6TLY1MwSVlwOJxnIWabYGk6FSzffxBZcaPywnEbC2fxeXkgoXrhbfJ/ubmJTdAsujLxMVZwzX MhfQuT/wTwBeABJ9wATpn/rIHXID+stqYJcu4/hSilmyFnveGqob1tMbj1S5AoKCIbfnonTghYEEE 5dmzSby7AQPHenXASKZILG0aMSuM4l3Xz0GIpLs9TQadspYvE5GQiAVmlwYYHqamtl9/YhJHAvX9h vEeGGJGOJ0x7T3QRXs/FDuZdntYVW2AI4/TJTKA1L4dTEn+kTBgprG3xZbWFDV0Y0dDP/Ds96+yHv 09W4wg1w==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qeXUt-00DNXn-1d; Fri, 08 Sep 2023 09:09:51 +0000 Date: Fri, 8 Sep 2023 02:09:51 -0700 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: Peter Zijlstra , Ingo Molnar , Will Deacon , Waiman Long , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Chandan Babu R , "Darrick J . Wong" , linux-xfs@vger.kernel.org Subject: Re: [PATCH 3/5] xfs: Use rwsem_is_write_locked() Message-ID: References: <20230907174705.2976191-1-willy@infradead.org> <20230907174705.2976191-4-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230907174705.2976191-4-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 1E802180022 X-Stat-Signature: zia3x8kbownhhrjfn7fqj7b3egncuhdb X-HE-Tag: 1694164203-865067 X-HE-Meta: U2FsdGVkX1/RStWziw5vVtMjReSPl8L4g+X51EOU5aVrKBsFJVM/LH11IQfhV1QK1oeHC+iIeAJWRYhW3E1hj/rNTg+WuV1iQSq1LOa1VTcBDgysNl8TB3hI3PwC0CejfWsbtFxIAVLJpyFmjfb7mFx6KVyZifXawWuuSn515sAnMm0cuhYRPkCbcoiQ6FofLc7zrFhRe4FQTN+QgHPe106FPG3s+OgvLWBtyz8Nc0NoSXAm7N27/avaKyj9dB6e1X+mdUDcRF+230g2eH1Pz6zmhWWisP2ub8//G4J2S5nYyBTBX5KtzEKVZa/C94gBisAwyfNlPmZeZcQIIJQKIv5Su9DeSsYIwCi5L6EOdFlNGFJ6Y1N2+mw6FFr0fYjsOMIYTcitCmP7IKOv3U2cSftsdyXBMDMUZ5GgSs9LocLwHJjQNK2zgP8waBo75jyMK+WYlQsVUdbCKuw9+ZOY4lYIAgEnvyLBvmN0mSI3ks2XU3hYAJ3tGxiJrH91JJMgCBOBobNH6xHVYbzOjxyAvYvNa20DBkZd1l0fHWZE/9bg2NaXB8c45iRWG95uZIjwc6z5qCTohhwD/n2r7+4LhM4BtxFrL1ewHZZ4gxS9c7OKaPnAmfHAE7UW4Txbi80OpP8SdVB9ccWvijsIGN/H7GbNe17OtikO5Iaon/VW+JVJPDyy8KLDRcchRTvsZxMlnx9vYSoBM5GHsvHeLWsqpT8tv37W5lrfhIOWOaiPhQNleK9plZzHJCwYxZnFCAQM+CYvvP3yv+8ai+pXStM1o/zAsWfF3DZBaI69k6MFQqxA6nclp4WpGchx6xG89eqDcFYUXNaNxqolJ5/cGYX2eWlD3iWP6AtwUy1wdT/y+CNTFbxqYZ/3BnndF7Uro7ImdWLH3i8v5jp+hTQee6JVvq4uAkgLSTIz7P4VuFyRGeOUeA5PNkiSIRyJG7EMHQRPJIEkBFe1B67hRi8O3F6 D7WeBS4/ NDw3vpnSuHElgABMLkuzbbpUn40N7lzBqYm//1pK7ZmVUOpwHeEngilqIYZYnLmz3P1xDtpg2FJM+dBokWmPEkw4jywjQTqlWSIetAptIeKQklqRjC1zdjpF3IbWX3thJVfLTphrAncRBt0iRUM09bhQzh6gnC1WvVz6PhYJytx/OnkozMLsZSUgOrVSKNS7opbhkVBJS1NIkKzIApj+m3+K0lfGvO/bS5J/jaBjYOGCwdNfBFG+c8WYb854VQc96RvnrxTAi/8OkwULIA/0bxRZXQ3xGhFPDDiYCPL4dzhK0Z610tcKPJ68oq+4dI+EUKLPTzTtXuAv2UiLN8lfu/e1rWQcu9dhtXuP00Rrb1baVPkaTd1nDqi0qXq0HYaVsJeYC72rIKpP+PrysJZ7FV2fUhXZoxfS/gJ81L2KLjr76hXARX3u9+kKYxAD7lJ0DFSirvWebvZYtGjNx66pG5xgt7CnP22Hi4ZUsyC+stDGpKWiWaHyJu8zcwu824jfgibul X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 07, 2023 at 06:47:03PM +0100, Matthew Wilcox (Oracle) wrote: > This avoids using the mr_writer field to check the XFS ILOCK is held > for write. It also improves the checking we do when lockdep is disabled. Hmm, is there any reason to keep the lockdep-based version of __xfs_rwsem_islocked around now at all?