From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12EE0EE14D4 for ; Thu, 7 Sep 2023 04:50:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6BB5C440175; Thu, 7 Sep 2023 00:50:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6442344014A; Thu, 7 Sep 2023 00:50:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4E46F440175; Thu, 7 Sep 2023 00:50:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 3BB5544014A for ; Thu, 7 Sep 2023 00:50:40 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id C89AD40103 for ; Thu, 7 Sep 2023 04:50:39 +0000 (UTC) X-FDA: 81208575798.29.E1AE86E Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf26.hostedemail.com (Postfix) with ESMTP id C6443140002 for ; Thu, 7 Sep 2023 04:50:37 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="D/6XY7fg"; dmarc=none; spf=none (imf26.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694062238; a=rsa-sha256; cv=none; b=w49j52gdTixvWfLFp5mU/ECcfbADhmhhHUeLB0YPpUsuoNk58hv8sshJtTQDbN/YFcfWls aJHz2Z7KXdnr4V8jqk4PawXyyrDQ0BbckWTerGTjSEG54Yti5Dlx1mF2RVISIWCFJnVxgb qfLiQeDw65khfChuTklOdNyFp4PUK/M= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="D/6XY7fg"; dmarc=none; spf=none (imf26.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694062238; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=agMaBjuOFtJtue/FbP/i4deiq5fFLhiBf3GHw58yzas=; b=QlF8FvQanQcsRvh+CQ/j6ZL7RGAoykpoOVudB34q5elEZjP+vN1PpZa35GQRnY6PuIzlQf NWpFsbEZ7+Xnmh9yoQUVsJNpTQoHwoirdmdXxoHwTzFyh1u9rsDmP0T2RY5FaVAco2nail rj2qsZKdW7nRtQPLr1W3SGQQgjSRXA0= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=agMaBjuOFtJtue/FbP/i4deiq5fFLhiBf3GHw58yzas=; b=D/6XY7fg3+OTdCcL78r6ouJI2a j0nJKQ+qd28Vgv+PMWDEBtTCK+tZY0hOR5uHlnBAHjjglP2qVDHLYoXj/Vt3q/SknQGaPkf6TVszX KrQztPoXiKWNJBij9WZHFNM3mHtf/fbFk9sGADOqlc3C5S3KTTTGfMaQofHQYX2M9xjgEQ5tzTdcW jmf+VRuuWmb7o7yp9F9DE/hPpUqG3equByVOkb61Fflcn4EFtklrT2VaR9fLddfpsLVU7o5RSIGvV /eq0T3G2n1E8QCqSgYDJvMs1rOqurAD5A6RlSVXxvXLmgbzuhcz2sxZCKMhvwWQBDqS+FpceWFbKY 6zSVKG7w==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qe6yP-008I3S-1s; Thu, 07 Sep 2023 04:50:33 +0000 Date: Thu, 7 Sep 2023 05:50:33 +0100 From: Matthew Wilcox To: Zhiguo Jiang Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, opensource.kernel@vivo.com Subject: Re: [PATCH] mm: vmscan: fix get_swappiness() return value type Message-ID: References: <20230907044045.709-1-justinjiang@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230907044045.709-1-justinjiang@vivo.com> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: C6443140002 X-Stat-Signature: u11tatdhtgigcn5o3k9qcgunuxydwje5 X-HE-Tag: 1694062237-617187 X-HE-Meta: U2FsdGVkX1/vpHJJKhvec10NW3a5y/Cun+Sgm5sxUk5OoESPEQuYKW6vCEjmiw9gJTGakcceolksU8ZkyrKVGBvwagRe4Dt/8NQ5n6YnWAxCP2fxEZVwCH3KQWzNcyUvCmJVT8+1wOqstl19o+W6JQMUeO36GRnpB+fGvDX34kHrga+3LCIjpM/fjLKV8uvlMPuW4PCo0jMT7tdey/sVeez/VTCFTXSmoVXmqAFdsWtPYDHTL51Jlv63R8qa7B+/55A0se16z8iWtAy4+Zh7XENbHpqMX4pIqK0P6KSykSSd2hjlThS9kfYiZQfOppMw8eXuTqEPoZTL99JhX9n6BiE5Xyv8Z2Ckcq4rEOuUVh2r3K+9h9S5k3W9BlJ1QwjBeDRKK5jC0sFYw1js4jH8SUpeKLBxXtAmAZ0u+6yWZLPJPzoUPpOTrSb76kpMIMIhpy9Lv4xzi2erq7hQcd6H/K2etxC1G9paibcD7c9SUvCo5axsm8g8hPDnsTtZpdxTMnE4NlEZlssVcbf8HJmTZYn2ElPZGDHe+mMXonZE1rjG4pk9FWojz2/nHYSGxDMyeaL0eIbcxoaQU2boVjJK7cVKRVKtuUei+o4gmLMYZfZ/WQVTl3af6svepbPM8b1HWxQt6HO1ByHqhLFyuCqi7BpAwSNg8B5FbdyUHWMRL9ifichR+j89pOhXHpHXoPEKlMf0w1ziBabg3MQffaN/s0J9XPXSzg4g5X+tFWeewPrMBh+Qi90ivcBWOwFo/8IZJD2xB8re9gsCSuM/8E11+D1M3GXWQ86JhxB9HrvBF8wQk8VepYeIg+XZE5FCKN5A1kjtOTrQKhGRqalTN2/w8sTDr+kcdUbAbHNgHFrM28EreEwXz8wItIGqxGTacqFfm1S+9CipN6TUBGMA4p88E8ayOwlq6bws9PrupHAObvO3h6eU+ARaEj5pLx59Oid9ImTHNBrBFjk8e3/NII0 qiqUQf3K un8OAYuKjndT4dAnP7PFJ5pjImJzoh+HmSM7BCH/b6U6GKYKnBgzrRt8woF8Kg4+xk/yoLA6NmzWBiIzIUOR7Vz4MEqm6gsrs+C8yw7v/CGqrMNpi61+KSh1ZLulwryy7sUJQ9VyYYH6LwoZfN3MBo8KhiGRNaOUX9qeDp3YtrlNJ/5iuO1uoSPjEtg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 07, 2023 at 12:40:45PM +0800, Zhiguo Jiang wrote: > Fix bool to int of the get_swappiness() return value type in > lruvec_is_sizable(). > > The get_swappiness() return value type is int, but the > get_swappiness() return value type is bool in lruvec_is_sizable(). > So there is a possibility of value overflow. Have you looked at how the C spec defines int->bool conversion?