From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC0A6EE14D3 for ; Thu, 7 Sep 2023 04:10:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4539F440170; Thu, 7 Sep 2023 00:10:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3DC5D44014A; Thu, 7 Sep 2023 00:10:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2A44C440170; Thu, 7 Sep 2023 00:10:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 186D644014A for ; Thu, 7 Sep 2023 00:10:57 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id D90B2A00AE for ; Thu, 7 Sep 2023 04:10:56 +0000 (UTC) X-FDA: 81208475712.27.EEDA67C Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf13.hostedemail.com (Postfix) with ESMTP id 3D64A20015 for ; Thu, 7 Sep 2023 04:10:55 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=NxbZcGmt; dmarc=none; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694059855; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9UzaIJHInJlgwQfLKiyRFrgprSJsNB4MmXDA+n+Rqa8=; b=8TTbbXvnapsTu42UB/GPFqG3kZjKclQr0kSGeb0uKP9rYytjNFx2zRfzxBh5daG/n3HSPe h1KFvd2lXTz9+EUS5/tUCo4FkZNfKNEy8DQV8vW1yEoD5vYHWgOVy+T6YoaDwjBMXeNfru 8ahhHuXJfy4bCeWmEm+e28tlXawrkoo= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=NxbZcGmt; dmarc=none; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694059855; a=rsa-sha256; cv=none; b=X4bEZccrdp3aCF8kPbCp/LLx3m/9+KJepX2Q23IoKt7x6+W0SgYUeTOjxg8F9CrqpkMpDB YugxwiFQ4Js/M5ITKwp4U+Z4VITz7kddASduvuLKef5we2urlV0hfmcM2Kf43a/9vQiOdw VKWVwjw8zHcbgS7YDnHUfgeMyQE+1Tg= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=9UzaIJHInJlgwQfLKiyRFrgprSJsNB4MmXDA+n+Rqa8=; b=NxbZcGmtObKKKMrOvJ4xI4xAVD BtXfbfHyyWOqXFD8wSsX7y+5BcvzIuBPwKYz5OB5RsNrOgQb7l3Jb+NEbK0SY0rKOasI/0alHzm7J 6e2l78Dbr0lyi4IRrFdu9H0eYlrKK5vzstp4QJ44jY1ss5V8M8yhBmY4z1P7Hr8wbo4+2Pd3AMCAb lrdoMuTHYMFncAofbakz8JPzNYQ7/MDSf584PYJ/PCwMr2pNF5ogkBAL9bX5F3mpYGD64EkST+t+T 0HTlJleUKJJRmVknlB6nSlHsqtdyhLviKK2levIK/tNF4w+h8vCkPuZK8QxO4Uk+qwonCTTdBerEt 0S9cwQ/g==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qe6Lk-0084Ax-QE; Thu, 07 Sep 2023 04:10:36 +0000 Date: Thu, 7 Sep 2023 05:10:36 +0100 From: Matthew Wilcox To: Peng Zhang Cc: =?utf-8?B?7Ius7J6s7ISg?= , "liam.howlett@oracle.com" , "surenb@google.com" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "jaewon31.kim@gmail.com" , "maple-tree@lists.infradead.org" Subject: Re: [PATCH] maple_tree: use GFP_KERNEL on mas_node_count Message-ID: References: <20230907033914epcms1p61c5eed4d34d5c4212436c201f33292b3@epcms1p6> <06a8624e-00bb-a332-4271-860847faf4a3@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <06a8624e-00bb-a332-4271-860847faf4a3@bytedance.com> X-Rspamd-Queue-Id: 3D64A20015 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: rs7jt513o9j31eb7zg6xfrkj5tqx35we X-HE-Tag: 1694059855-560670 X-HE-Meta: U2FsdGVkX19CfLKoBgu/bfkIUypZRt3TLXBo/R94bILRgnorrNejGz4u04G/Ll8RqHPjw/MVEJD+VSMKQulJXAhKsU5+N6x+do22AUpo8QuU0ODS5X/7E9UpfMlycyyVoY+g2IU/OSYGvjxPD/PqVq701vRvuR6u/EP+ygTxVgDCwutH3JMRI3K9gK/FwNrs5wJ5hPtknZkJVbODOGov2aDZnJ4d0xuqBTUlCkIbj4xRyXqV8y/yj1z6dxW49H9ggzjBjlk+mWPeBatHMRbBT0nPPMRG5N6XS/5ZNFcoYFsOtNH6ldH7PAFf8WAtS+nav/zYFY+46fJHbzh3xEC5DuGi6aN2HnFm4jR3nOEOEDCPvZGBOxFGahidqB2StiARUCVwzI0nosYH7jyPTu5LQn8dU+020qTVmudY3zbO8pY802Cp5BzGLqh1c3vcEPfe2UBWszC06y6R4uTdCsDyDnmCTAJVSsOS2zgKwTYseV+zR+UECwslFwxI6ih5jriAWTN5cpe+hjfCKXFos8U6W4Qrz78BFe10ppk1Brgu+R+Brcz+jhP5R4Wqelk7WXnnGcGF1JDwV6b1XvH5jjPjUg+5DGD26PwId/x1VoWVnGZO5Qy+1acMYETssoE47a+3eqthkcXbxSXPf9ZVMzCSGZa3sHJgJAB5MtrQFGj+p0VcntNr8ApA3QooizFyN9fml4is88ebB4Gtxk9QHkOJ4At7rziLB7kguIf7fPXjy+dNgfAh3gjRUgtD1k2D4EjGq47Oo2mZLlMNs7ALf7wgCkBXoMhcakqjX3jDRpCQ7kesfoNkkjJ4gj2gz1UBF67fw6M6AVibd4h50O4g/ThbI0Y7zkRF8GJy0D+yUJkyxznJJhVgvlr8/jPwjhrQyTbfjjRXaIpbVGwWhjLkYM53d2i/NCZ0a/sXYpYDFZ/YK4ea2sK2aMKoYzO6GbxUBtXIOHj288spHINyl87LwHL JNmCVC7S O5ecAlu9PGd21O91JJQkMqYIK+4teMy/4RpIQfydNNoPNmrvjkqIBmBP0cxbR8/nHmARrjjLQnLDR6lJmUc9AFFhlC0IRq/ufmhSiLBNSbOJVfdeu4UjbilWyskZvgYWg0+5PrsTCVkNlktRJZ84TRRg25pM8lTulpDwYHGxD9LUg/C+0Z6bJt1QczIwDQqopDIUfKvdMv3gwWSFqsTcg7VHdMyz91MhSviQdFvjaqeo9CkRUFeuzPTH+zYsDlGXgumwRytVcHTIEmmDpk/rye3zi/M4LpdbC2kvjYBDwBPHL1lo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 07, 2023 at 12:02:02PM +0800, Peng Zhang wrote: > > > 在 2023/9/7 11:49, Matthew Wilcox 写道: > > On Thu, Sep 07, 2023 at 12:39:14PM +0900, 심재선 wrote: > > > Use GFP_KERNEL on mas_node_count instead of GFP_NOWAIT | __GFP_NOWARN > > > in order to allow memory reclaim. > There are many paths that call maple tree's mas_node_count(). Some paths > cannot reclaim memory. Right ... but we should be handling the ENOMEM inside the maple tree and allocating some nodes with GFP_KERNEL instead of failing fork(). > > What testing did you do of this patch? In particular, did you try it > > with lockdep enabled?