From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EA77EE14A5 for ; Wed, 6 Sep 2023 16:27:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8F4E58D0014; Wed, 6 Sep 2023 12:27:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A4BA8D0005; Wed, 6 Sep 2023 12:27:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 745388D0014; Wed, 6 Sep 2023 12:27:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 622828D0005 for ; Wed, 6 Sep 2023 12:27:56 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 2AFAF120B49 for ; Wed, 6 Sep 2023 16:27:56 +0000 (UTC) X-FDA: 81206704152.24.8A278B7 Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) by imf08.hostedemail.com (Postfix) with ESMTP id 34736160008 for ; Wed, 6 Sep 2023 16:27:52 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=SlG96W3k; spf=pass (imf08.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.178 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694017673; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KQUJGsaeOMbl6qMMpIZHhehLszW3RKPl2I1rjdhDUEc=; b=LdJ9vHKRj09NU3WicUeGKy5ciTqClcVosi7z5U39hy0V+YG/lTrL5GEjVLEvlAzIB/9m+C efPm/AxoRf5Vzt2WP2oc51TsOaY0Kni8+rbQMFbhsf+mSxvaCqC05vDCPgP2QbFp+denjw 8VH4L6VAIay4AyLHPvbZ6+xpDScAkik= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694017673; a=rsa-sha256; cv=none; b=E5/DRuvWhq5S5N/WDCpDMsV2X25G0g166/ID3sh9kFhnlDRl6POU2MrWxhqaVFufdEumvW iAwmwx4Q3eeudjd1XYH/EqvnA83g+i70aD+u2arIyR0Hpn+icKb4DXq3YgRwFLrjYbSn9u YzW7w5A+xrsZlJ19fBQsAR15tCTOkts= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=SlG96W3k; spf=pass (imf08.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.178 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-lj1-f178.google.com with SMTP id 38308e7fff4ca-2bcc4347d2dso1222241fa.0 for ; Wed, 06 Sep 2023 09:27:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694017671; x=1694622471; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=KQUJGsaeOMbl6qMMpIZHhehLszW3RKPl2I1rjdhDUEc=; b=SlG96W3k8/u1CaCHr9inmcKWLoWcyBW9Xb7Aau6CcUh+NIiJXHey9oguZQMowdx1VJ HK4vnZfoNloEpD10uR5twi1sEb9qzdOp54yID5v/YmyvArJ60wNqDCrqWxW3j9JgBGvN kb0ZR2KS4b3wAO5OAVO+2Tg5g1GiS31/USIsYbS4EvyvG0Zt9hjM7vJPbzj+LzcQxdob qpZ1D8+jAaLI79bpTuC7/EdDb0/8ElTbfWrHjn39ViH5zsuEGP2Ys0zTFLkQuGGQ6MbE bjHw8W7rh5VxH2Uth04BgB0qeWzNo7Alzf2Z0ayH82cUdCxClFUNXchmzxqW2gFPb7Oq c/5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1694017671; x=1694622471; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KQUJGsaeOMbl6qMMpIZHhehLszW3RKPl2I1rjdhDUEc=; b=Woh+HnawI5RQwKWNKyAmrEgWwZxQzq4L5yqtu8Hh5Q2AFju0MRTbcjPvQXXUtf+SeT 04dMO1ht5HLXGVsgP568Xk6Y/ZLq6BtrhJh8CprnUISQlHs7wW/Fax+QDq6yk6+Oneme 41R6vwu2j7wLWHiwxFTkoalBvIkGRzPDB+MfR9GSouCIDgiVS4cO97D0tBk4elgsVlTn +g28+39aeQqUkNII1cX2+9ZkFpiBoALku9v6WgwayyaEnQE3BpxpVNBEU1c+iER/rrmw 6vDhshXD0Ec7HSnrbvLj+LhPLE+QvN+r3TLlO6fwu7nIYykuX+12SIFLan5t0ccKSKTm tN2w== X-Gm-Message-State: AOJu0Yz72rwxl2RkuSqHKjCpb745SaEaMs8Q4ugRBmiKCY0yFQGyrVCQ v1Vo1C/2l0pcDFzEVKRys9Q= X-Google-Smtp-Source: AGHT+IEpHqMyLdhZtcT4lemXIkiKYTsPGbY2zZdPT1tHOfKzfGZp4ZO2HiFFCKcLFBfh1ximufsj7A== X-Received: by 2002:a2e:9dd9:0:b0:2bc:c004:cc22 with SMTP id x25-20020a2e9dd9000000b002bcc004cc22mr2732460ljj.33.1694017671028; Wed, 06 Sep 2023 09:27:51 -0700 (PDT) Received: from pc636 (host-90-235-20-237.mobileonline.telia.com. [90.235.20.237]) by smtp.gmail.com with ESMTPSA id n15-20020a2e878f000000b002b6eb5db863sm3501421lji.43.2023.09.06.09.27.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Sep 2023 09:27:50 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Wed, 6 Sep 2023 18:27:48 +0200 To: Baoquan He Cc: "Uladzislau Rezki (Sony)" , linux-mm@kvack.org, Andrew Morton , LKML , Lorenzo Stoakes , Christoph Hellwig , Matthew Wilcox , "Liam R . Howlett" , Dave Chinner , "Paul E . McKenney" , Joel Fernandes , Oleksiy Avramchenko , Christoph Hellwig Subject: Re: [PATCH v2 2/9] mm: vmalloc: Rename adjust_va_to_fit_type() function Message-ID: References: <20230829081142.3619-1-urezki@gmail.com> <20230829081142.3619-3-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: 4ghjkjrqqf9mtiu9nyu6cbgmu53hxdaz X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 34736160008 X-Rspam-User: X-HE-Tag: 1694017672-980357 X-HE-Meta: U2FsdGVkX1+LSb+hKUIq666c5i0M4qGkiseVtGAfd5MG3kPCeyf2T2jkxfgabWFfOSu0nSSJ/ig40Xai7N+xDBcfJmZdj3yRgK6chcISUPxDkGHMp1SBYg4hItnFLsPYm2zL4M0h1nb+4iGQidIwh/YzKMREdfQt6TNgbzclcSm78X7THxqhR+xzbGB+ccsk08RFmvpPjQxRfSuW9uqO7utzRUV8XkzOjZPEnTsVykS537FbCbGlPzLS1nfOVEo63DV7ok7gEnca7fYfkNUvsqO+WpT1LQK91CNM7c0t3h76Xdocfyn9GukI+7zKd6oqKb96fLckeu/AqU9u5F2rm42Cmw5OWKlG9eomf/XQj+TQs5wwD7QXd3oVcyrNusB3LIXLjakMMlKkuhxbq5CZuRWBn79bu9aRxjC3NzRYmBfBj8PMjcMjZGVqQVLl26Nn4EDY5Mi/QwpSMAUn8xeZLU/nH20acpZyPACEBNQx4eEWxhdbAe1QFF9t+p1TGiRb+Ru/YJVhlnpbAVtebCu8a3Fa36uew3x6G1tGNb46L/yOCloLp4F7WtsLQVP8HLCLIMp98uqyh4DR4dmnLcHbEq4/gjRsXc6cktLCgxk4mmTv9NIJdIWGtGRTNXtkbqX1WkPVCRzzBFQUuXDFFx0aGLeRNeudGzMc+V6saTjPilMCb8tFPrUq0hrAFbVTVrQtjOnGbjas1Lsx0HWX+ndmFeFI5sDxwCny2wfbhGKAisAFFYlipyCDP10xI9RTf3flCOS4wj8aMExAB8BmXRUJyyatz4uYMU7cMDXE7BB6n6yH7h1IN6FmqQ3LTowqc1WIlS8uEktGUM9RvFVeWaBCK6RgrM8Fwsh9vAENN3GMz4/vgWwbL0rPzzPlyuFlNX0oW6dkGW9JtdAcEfwLwZj/NXAChuBc4RgU8TdspTr3vxOLlNa3ZYznePvZSb4LLoeX36NVzxc/F3V/4m9fHJh s920qbD8 EufEs3z+hERG75GRlso77ZpMvJfBm7CDQjdxpiGj9KCcSGaYtF3LR+Ajq7AirLR2pKlwJnizdlMVxXeaI6D9yqx2XTnEvPVVh28pbQ6xYOeLjryE55MY8PCMPbcY/t/JxbkPy/WAdVt5ET8pcGQCU8hwtgiYV/kfWipNWgpxy7ezjaiOpusyEsL9VAWzSf44YktsNKEv+8WONOtTb270tdbSYCx+Xqz90jqkhK0sRHRzh6ex2vZz94hRyGR9dsjYfZkHqte3/87QXjDe08UCtNuamLKNSfMEzZYy+1x7h/AE4ZNPnIJ7gSajxjQcBh4IwV8eCoHsg2K8j7dU6dXYOHcW5m3kqV6oiSNq0qY+3ABPNPxLDoaIR0HmQ43hw6RKjGrHl1IoqvUCldhtz0psBHJlM//DNnGZWqKJUqpElqnJAS3VCoyuciDpszMH4XHa55y3vJqv6ElvZOyjI2qUedlCvdSOs7aB0e2Ylwmp824MNMIIK80wgq1mxFBre+ZfbjToHtOForr9xE+QamgBuXOo1eg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 06, 2023 at 01:51:42PM +0800, Baoquan He wrote: > On 08/29/23 at 10:11am, Uladzislau Rezki (Sony) wrote: > > This patch renames the adjust_va_to_fit_type() function > > to va_clip() which is shorter and more expressive. > > > > There is no a functional change as a result of this patch. > > > > Reviewed-by: Christoph Hellwig > > Reviewed-by: Lorenzo Stoakes > > Signed-off-by: Uladzislau Rezki (Sony) > > --- > > mm/vmalloc.c | 13 ++++++------- > > 1 file changed, 6 insertions(+), 7 deletions(-) > > > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > > index 00afc1ee4756..09e315f8ea34 100644 > > --- a/mm/vmalloc.c > > +++ b/mm/vmalloc.c > > @@ -1382,9 +1382,9 @@ classify_va_fit_type(struct vmap_area *va, > > } > > > > static __always_inline int > > -adjust_va_to_fit_type(struct rb_root *root, struct list_head *head, > > - struct vmap_area *va, unsigned long nva_start_addr, > > - unsigned long size) > > +va_clip(struct rb_root *root, struct list_head *head, > > + struct vmap_area *va, unsigned long nva_start_addr, > > + unsigned long size) > > { > > struct vmap_area *lva = NULL; > > enum fit_type type = classify_va_fit_type(va, nva_start_addr, size); > > @@ -1500,7 +1500,7 @@ va_alloc(struct vmap_area *va, > > return vend; > > > > /* Update the free vmap_area. */ > > - ret = adjust_va_to_fit_type(root, head, va, nva_start_addr, size); > > + ret = va_clip(root, head, va, nva_start_addr, size); > > if (WARN_ON_ONCE(ret)) > > return vend; > > > > @@ -4151,9 +4151,8 @@ struct vm_struct **pcpu_get_vm_areas(const unsigned long *offsets, > > /* It is a BUG(), but trigger recovery instead. */ > > goto recovery; > > > > - ret = adjust_va_to_fit_type(&free_vmap_area_root, > > - &free_vmap_area_list, > > - va, start, size); > > + ret = va_clip(&free_vmap_area_root, > > + &free_vmap_area_list, va, start, size); > > if (WARN_ON_ONCE(unlikely(ret))) > > /* It is a BUG(), but trigger recovery instead. */ > > goto recovery; > > -- > > 2.30.2 > > > > Reviewed-by: Baoquan He > Thank you for the review. Picked it up. -- Uladzislau Rezki