From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BFB7EB8FD5 for ; Wed, 6 Sep 2023 14:10:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 49348440169; Wed, 6 Sep 2023 10:09:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 442EB440151; Wed, 6 Sep 2023 10:09:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 331CB440169; Wed, 6 Sep 2023 10:09:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 27768440151 for ; Wed, 6 Sep 2023 10:09:59 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id DF095C02D1 for ; Wed, 6 Sep 2023 14:09:58 +0000 (UTC) X-FDA: 81206356476.24.2040CE2 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf15.hostedemail.com (Postfix) with ESMTP id 75B88A003F for ; Wed, 6 Sep 2023 14:09:56 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=snaVG0C+; dmarc=none; spf=none (imf15.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694009397; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2KICmQPQioM7Mq7IhbLtSPWvHTI3/EB2itOUb98EMvs=; b=xSkDFMF9ICEsrWiGSZA7e6aOgNJdlRy0U/qt0LKh0YqkYvevK6oxpuMnmJg08sGiHNKapX iRyV5GozerRFRrqMNGuYY7R85iwreUVi8m+xqMZwurif9M0K+BvS9EKzeMK78CJJXK67PZ t47owp35W8JldUqmZPeNdpyF1yIuLeU= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=snaVG0C+; dmarc=none; spf=none (imf15.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694009397; a=rsa-sha256; cv=none; b=KT2YNgnI7fLBYcxtalPaQyNEbc20v/ro5JnMBwwXNTELIcq2dTRrN8WoGkQEoHpLyGiBEc yod8RhD20eFQea8IYw5ZAgnv4zVzFWqk3+m/5qMKa+YIDAZ4cp0x18kDZZsA8uKskKF7lv pTAJCAPLbGUKAMDwuu21bwJRabLjxi8= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=2KICmQPQioM7Mq7IhbLtSPWvHTI3/EB2itOUb98EMvs=; b=snaVG0C+Qb1kuAlYoIf4ZBkavW PHRJKqf1J/Q7gcIbsNBrdD8EbUm0KPzHYSRQjRTjeQSVgxlNS6AZkWoZOgvYaYt+NkSlirle1gCOr XiPYgyREJqxkls5Xd0J0y9iuWH7zwz97v5MOvbVZ/ZLjU/tDavRzbP7Ow1Iy9Mu7EYm73r38B6AA6 9Na99VoLgn5DwGQP5dSmEIztgLczEz5yFq81EoHku3QzeYY2h2oBSPm9GKxmXayus6fUKDTNTOy5x zYWZP4fnXWYhgqGXyptKuzdIACY9RuyapQx8bClo0hZECwYL9eCzMJGqdfDS214Ny0ylwVinB/iOt yXLqxbbA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qdtDz-002vwD-EY; Wed, 06 Sep 2023 14:09:43 +0000 Date: Wed, 6 Sep 2023 15:09:43 +0100 From: Matthew Wilcox To: Mike Rapoport Cc: Jonathan Corbet , Andrew Morton , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] docs/mm: Physical Memory: add "Memory map" section Message-ID: References: <20230906074210.3051751-1-rppt@kernel.org> <20230906125214.GK3223@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230906125214.GK3223@kernel.org> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 75B88A003F X-Stat-Signature: rttabrxqaxpztpcjmzrj3kji1rz8m7wh X-HE-Tag: 1694009396-687171 X-HE-Meta: U2FsdGVkX19C9C4rZA9DeGN/BI7tO0eY2i+Ro+1USAP418CIkb6Rp0dwxBpIIeb3u6psNMX+nN2nYadsroItbY4szlFxZeUpQkDDJZD2CcNrfMTNZpDvTjPfcyZLoAdx2lI/yD7Pb5scvj9hn3wqeuBdzY5HH2+IyR5i2b7yjYjp85H+EZ8kxqz2qo6MivGcyBy0f6S04dZpQMtbEni++FCs/xQTLUBLkGgcJIhOVigTpmUs09tjEnf4hssZ/zoKffL59BpiUh/g0I635RRc4VipoCP44+PN5ZCk7lgz/dvem3250ofPbAr5OFiCNAFvmn5nEoaQSD2nrL8zbjoTiZXB+id6cc/yFJrs/Mo0ztlEdP6VA9oP4PRVwEih0eKtKW8/MIhTVaEWrY8Kw1u+4vJBoe4DqlHVetbp2GF1mLmu4nBDWxOnv8mPtbWP3Y4SQHdFlFDkjLfHFTO5UlVMHChqGOZ0NlmPH/u7I/fEwssk68mK5zH/exCeXxlsRnoqEoGxjARDLS2gSRCKhdStABwEngveiC+52x/RnEWN5xWNWFPZ7nnCeoeCpXLAaV5CuHE95zVJHscsglkLCJCtalqm/5D12W3glpvTr9I9SuwYF1eXl3dNisTdT4UZ8UwASutN8lOmBeShh9C8EV+PHvfiElAbboBQJjKuxOWtklGXIIqCUK+5xdCWXW6fTh6cJj+4wveTLSoqnVVrtIdnOE5LNwRQDsOBT1WrjN6ua8aST1E91CeLKjJV27xycjd0fz3bifyBdfTPsNXZ+Sk5i3A6q5cC+GvSrchFfyPYmdoWM8fQIfg7U25Pxz++t/flX33unQuIvv+4/95Yhvu0iEPg7Vz5iaECblq74oLJQFm0fvcMjgn7LZuVltXk6PiN+9/e4uqLbQT6k71WntULqhRz7t7nTWMFI0iVXexim4sndPuuEzFnvoc7Y6b9ESMG9+6OjxfoUHhs5XI054f wIcU2c8v GmoN9Tbm2RBKXcK0NhlRoxtumP9Rp2wuHb1Cdr4NUTNvCGqXrzXu0udhXZfTWaboC+qM7rzC4INJYtgZM8i2o+6BlO5BhjYHEXRYBIvD8KPemALIEBMNmxkeKGlcJGahw4xEVzCqW9oUlie0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 06, 2023 at 03:52:14PM +0300, Mike Rapoport wrote: > On Wed, Sep 06, 2023 at 01:21:02PM +0100, Matthew Wilcox wrote: > > I don't understand why you've done all this instead of linking to the > > kernel-doc I wrote. > > We can't have it both in Documentation/core-api/mm-api.rst and here without > sphinx complaining: I didn't say "include it here", I said "link to it". I don't see the value in documenting all of these structs here. They should be documented in the subsystem that actually uses them. Just a note that there's per-allocation data stored in struct page should be enough, I think.