From: Matthew Wilcox <willy@infradead.org>
To: Edward AD <eadavis@sina.com>
Cc: syzbot+b591856e0f0139f83023@syzkaller.appspotmail.com,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, syzkaller-bugs@googlegroups.com
Subject: Re: [PATCH] mm: as the same logic with queue_pages_range
Date: Wed, 6 Sep 2023 13:06:48 +0100 [thread overview]
Message-ID: <ZPhrWDYL+JfI6upH@casper.infradead.org> (raw)
In-Reply-To: <20230906061902.591996-1-eadavis@sina.com>
On Wed, Sep 06, 2023 at 02:19:02PM +0800, Edward AD wrote:
> Only dealwith queue_pages_range locked vmas.
What?
> Signed-off-by: Edward AD <eadavis@sina.com>
> ---
> mm/mempolicy.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/mm/mempolicy.c b/mm/mempolicy.c
> index 42b5567e3773..13050b968479 100644
> --- a/mm/mempolicy.c
> +++ b/mm/mempolicy.c
> @@ -1342,6 +1342,8 @@ static long do_mbind(unsigned long start, unsigned long len,
> vma_iter_init(&vmi, mm, start);
> prev = vma_prev(&vmi);
> for_each_vma_range(vmi, vma, end) {
> + if (!vma || start < vma->vm_start)
> + continue;
#define for_each_vma_range(__vmi, __vma, __end) \
while (((__vma) = vma_find(&(__vmi), (__end))) != NULL)
How can this produce a vma that is either NULL or has a vm_start after start?
next prev parent reply other threads:[~2023-09-06 12:07 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-06 1:03 [syzbot] [mm?] kernel BUG in vma_replace_policy syzbot
2023-09-06 6:19 ` [PATCH] mm: as the same logic with queue_pages_range Edward AD
2023-09-06 12:06 ` Matthew Wilcox [this message]
2023-09-12 5:20 ` kernel test robot
2023-09-13 9:10 ` [LTP] " Cyril Hrubis
2023-09-14 5:53 ` [PATCH] mm: extpand queue_pages_range() to find and lock the vma range Edward AD
2023-09-12 5:30 ` [syzbot] [mm?] kernel BUG in vma_replace_policy Matthew Wilcox
2023-09-12 6:09 ` syzbot
2023-09-12 14:55 ` Matthew Wilcox
2023-09-12 15:03 ` Suren Baghdasaryan
2023-09-12 16:00 ` Suren Baghdasaryan
2023-09-13 16:05 ` Suren Baghdasaryan
2023-09-13 16:46 ` Suren Baghdasaryan
2023-09-14 18:20 ` Suren Baghdasaryan
2023-09-14 19:09 ` Matthew Wilcox
2023-09-14 20:00 ` Suren Baghdasaryan
2023-09-14 20:53 ` Suren Baghdasaryan
2023-09-14 21:24 ` Matthew Wilcox
2023-09-14 22:21 ` Suren Baghdasaryan
2023-09-15 4:26 ` Hugh Dickins
2023-09-15 16:09 ` Suren Baghdasaryan
2023-09-15 18:05 ` Suren Baghdasaryan
2023-09-16 2:43 ` Hugh Dickins
2023-09-18 21:20 ` Suren Baghdasaryan
2023-09-15 18:26 ` Matthew Wilcox
2023-09-16 2:54 ` Hugh Dickins
2023-09-16 1:35 ` Yang Shi
2023-09-16 3:57 ` Hugh Dickins
2023-09-18 22:34 ` Yang Shi
2023-09-19 0:34 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZPhrWDYL+JfI6upH@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=eadavis@sina.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=syzbot+b591856e0f0139f83023@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox